Product import: Only the first additional image is validated.

[engcom-Kilo]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Product import: Only the first additional image is validated #28236

Manual testing scenarios (*)

1. see Product import: Only the first additional image is validated #28236

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Kilo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Kilo]

@magento run all tests

[irenelagno]

@magento run all tests

[zakdma]

Maybe it would be better check all images and add messages for all invalid images
Now it just break after first invalid image
Please also change test accordingly.

[engcom-Kilo]

There is no sense to show all errors as they are not related to every image, but to row in csv in general.

[engcom-Bravo]

✔️ QA Passed

Manual testing scenario

1. Navigate to System > Data Transfer > Import
2. Select 'Products' from Entity Type drop-down list
3. Select 'Add/Update' from Import Behavior
4. Select a file to import and upload csv file with multiple additional_images set where the second image is invalid
   
   use the test file attached to the issue description import*break_add_image.csv.txt
5. Click on Check Data button

Before fix:
The second image is not validated, no warning about the wrong path

After fix
A warning message appears, Wrong URL/path used. Import is interapted

[zakdma]

@magento import code to https://github.com/magento-tsg/magento2ce

[magento-engcom-team]

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31397.

[m2-assistant]

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.