Fix problem actions dropdown positioned incorrect #31413

mrtuvn · 2020-12-23T07:04:38Z

Issue seem related with styles code. Before this patch dropdown position always show in right of grid and not correct position anymore when we move action to left.
Annoying issue when owner store move action column to near center of grid and grid have lot of columns
Issue can reproduce at cms page listing page with draggable actions column with some extra additional column

Before the fix

After apply this fix

Only small problem but i think this can acceptable
at the last item row. When click on actions link, downdown show but come with scroll vertical overlap some parts of dropdown content. May require user have to scroll down a bit to view entire all actions.

Here is example grid in product variants configurable product page in admin

Test case 1
Actions column drag to middle of grid have multiple columns
Previously: When user click active action, dropdown moved to far right side, unaccessable to click require scroll to last column to visible
Current: dropdown show in correct position right below action link

Test case 2
Re-test in smaller screen (1200px)
Actions column at last position when active dropdown display correct without jump of of block

Test case 3
No overflow with table have long width. Scrollbar horizontal will auto-show on demand at small screen resolution

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Actions dropdown positioned against the last column, not against "Actions" colum #31379

Manual testing scenarios (*)

...
...

Questions or comments

As long as this action column at the last of table this issue will not able to happen. Dropdown will show correct as we expected
Should we allow admin can draggable this column ? In some case we will drag it to the end

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-12-23T07:04:40Z

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mrtuvn · 2021-01-06T23:30:54Z

code rebased

ihor-sviziev · 2021-01-12T08:29:15Z

@magento run all tests

ihor-sviziev

Hi @mrtuvn,
It seems like this change caused a regression - some links became not clickable. Could you double-check and fix that?

mrtuvn · 2021-01-13T09:35:38Z

Can you share any screenshot ?
From my setup actions link can clickable

ihor-sviziev · 2021-01-13T09:43:22Z

@mrtuvn as you can see in test results - the issue appears for the latest element:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/31413/8ceded9f681dd8029b5056e3928fff89/Functional/allure-report-ce/index.html#categories/c6c6553a02a7680a5874353a75791825/ab4ba1e873f6ce24/

mrtuvn · 2021-01-13T10:00:27Z

i will check that again

ihor-sviziev · 2021-01-13T10:35:18Z

@magento run all tests

magento-engcom-team · 2021-01-13T12:45:46Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8626 has been created to process this Pull Request

ihor-sviziev · 2021-07-26T11:05:48Z

@sivaschenko @gabrieldagama @sdzhepa , can we increase priority for this PR? It significantly improves user experience, when you're working with long-width grids.

PS: This issue was already fixed in 2017 in #10082, then it came back :(

magento-automated-testing · 2021-07-27T01:03:50Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mrtuvn · 2021-07-27T01:34:47Z

@magento run all tests

magento-automated-testing · 2021-07-27T01:34:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-07-30T07:18:42Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

magento-automated-testing · 2021-07-30T07:18:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-07-30T11:32:36Z

@magento run Functional Tests CE, Functional Tests EE

magento-automated-testing · 2021-07-30T11:32:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-08-10T13:34:54Z

✔️ QA Passed

Manual testing scenario:

Go to Admin >> CMS >> Pages section or any grid
Try to see the position of Action column's options when Action column is dragged to almost center of grid or towards left side.
Try to see the position of Action column's options when grid have lot of extra columns in it and Action column is dragged to almost center of grid or towards left side.

Actual Result: ✔️

Action Column moved to left side with original grid settings.

After: ✔️

Before: ✖️

Action Column moved to left side with lots of extra columns added to grid.

After: ✔️

Before: ✖️

See the Action drop down in smaller screens

After: ✔️

The Action Option's link are working fine. Ex. Click on Delete of Enable Cookies record.

After: ✔️

Tested all the manual scenarios, no impact on regression testing.

sidolov · 2021-10-14T15:17:52Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-10-14T15:17:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

m2-assistant · 2021-10-24T04:28:02Z

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Area: Design/Frontend Release Line: 2.4 labels Dec 23, 2020

m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Progress: pending review labels Dec 23, 2020

mrtuvn force-pushed the fix-action-dropdown-position-against branch 6 times, most recently from 07ef2c1 to 034f3e2 Compare December 26, 2020 05:54

mrtuvn force-pushed the fix-action-dropdown-position-against branch from 034f3e2 to e3b6de7 Compare December 30, 2020 15:49

mrtuvn force-pushed the fix-action-dropdown-position-against branch from e3b6de7 to 0931730 Compare January 6, 2021 23:30

ihor-sviziev self-assigned this Jan 12, 2021

ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 12, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 12, 2021

ihor-sviziev added the Award: bug fix label Jan 12, 2021

ihor-sviziev requested changes Jan 13, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 13, 2021

mrtuvn force-pushed the fix-action-dropdown-position-against branch from 0931730 to 291f3d1 Compare January 13, 2021 10:33

ihor-sviziev added the Progress: review label Jan 13, 2021

m2-community-project bot added the Progress: ready for testing label Jan 13, 2021

mrtuvn force-pushed the fix-action-dropdown-position-against branch from 52f2147 to 2c67e3c Compare July 27, 2021 01:03

Fix problem actions dropdown positioned incorrect

8428645

mrtuvn force-pushed the fix-action-dropdown-position-against branch from 2c67e3c to 8428645 Compare July 27, 2021 01:29

sdzhepa added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Jul 29, 2021

engcom-Charlie self-assigned this Jul 30, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Aug 10, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Aug 10, 2021

Merge branch '2.4-develop' into fix-action-dropdown-position-against

354fb8e

sidolov mentioned this pull request Oct 24, 2021

Actions dropdown positioned against the last column, not against "Actions" colum #31379

Closed

5 tasks

m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Oct 24, 2021

magento-engcom-team pushed a commit that referenced this pull request Oct 24, 2021

ENGCOM-8626: Fix problem actions dropdown positioned incorrect #31413

12eb8cd

magento-engcom-team merged commit 0eeb76f into magento:2.4-develop Oct 24, 2021

pmzandbergen mentioned this pull request Aug 16, 2022

Action drop-down in grid partly hidden (but scrollable) #35955

Closed

5 tasks

Fix problem actions dropdown positioned incorrect #31413

Fix problem actions dropdown positioned incorrect #31413

Uh oh!

Conversation

mrtuvn commented Dec 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Dec 23, 2020

Uh oh!

mrtuvn commented Jan 6, 2021

Uh oh!

ihor-sviziev commented Jan 12, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

mrtuvn commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev commented Jan 13, 2021

Uh oh!

mrtuvn commented Jan 13, 2021

Uh oh!

ihor-sviziev commented Jan 13, 2021

Uh oh!

magento-engcom-team commented Jan 13, 2021

Uh oh!

ihor-sviziev commented Jul 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magento-automated-testing bot commented Jul 27, 2021

Uh oh!

mrtuvn commented Jul 27, 2021

Uh oh!

magento-automated-testing bot commented Jul 27, 2021

Uh oh!

ihor-sviziev commented Jul 30, 2021

Uh oh!

magento-automated-testing bot commented Jul 30, 2021

Uh oh!

ihor-sviziev commented Jul 30, 2021

Uh oh!

magento-automated-testing bot commented Jul 30, 2021

Uh oh!

engcom-Charlie commented Aug 10, 2021

Uh oh!

sidolov commented Oct 14, 2021

Uh oh!

magento-automated-testing bot commented Oct 14, 2021

Uh oh!

m2-assistant bot commented Oct 24, 2021

Uh oh!

Uh oh!

mrtuvn commented Dec 23, 2020 •

edited

Loading

mrtuvn commented Jan 13, 2021 •

edited

Loading

ihor-sviziev commented Jul 26, 2021 •

edited

Loading