MC-30127: Product Price is mismatch in invoice and invoice PDF magento for Bundle Product #31455

engcom-Golf · 2020-12-24T13:32:38Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Product Price is mismatch in invoice and invoice PDF magento for Bundle Product 2.2.1 #12856

Manual testing scenarios (*)

Create tax rule for CA
Create bundle, simple, downloadable product
Create order with these products for CA shipping address
Invoice order from admin
Configure Taxes to show in invoices(test different scenarios)
Stores->Configuration->Sales->Tax->Orders, Invoices, Credit Memos Display Settings
Display Taxes & Display Subtotal
Print Invoice

Expected result

Prices for all products in pdf file should be the same as in admin
All text should be drawn correctly (font, align, padding)

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-12-24T13:32:41Z

Hi @engcom-Golf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Golf · 2020-12-24T13:32:55Z

@magento run all tests

engcom-Golf · 2020-12-24T14:32:50Z

@magento run all tests

engcom-Golf · 2020-12-24T15:33:36Z

@magento run all tests

engcom-Kilo · 2020-12-28T11:43:53Z

app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php

 use Magento\Tax\Helper\Data;

 /**
 * Order invoice pdf default items renderer
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)


Please try to find different solution without adding new dependency.

engcom-Golf · 2020-12-29T08:21:35Z

@magento run all tests

engcom-Kilo · 2020-12-30T08:31:23Z

app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php

@@ -7,6 +7,7 @@

 namespace Magento\Bundle\Model\Sales\Order\Pdf\Items;

+use Magento\Framework\App\ObjectManager;


Redundant dependency. Please remove.

engcom-Kilo · 2020-12-30T08:33:32Z

app/code/Magento/Bundle/Model/Sales/Order/Pdf/Items/Invoice.php

+                $this->_item = $childItem;
+                $feedPrice = 380;
+                $feedSubtotal = $feedPrice + 185;
+                foreach ($this->getItemPricesForDisplay() as $priceData) {


Could you please try to refactor this piece? This method already has ExcessiveMethodLength suppress.

refactored draw method

engcom-Golf · 2020-12-30T11:34:46Z

@magento run all tests

engcom-Bravo

❌ QA Failed

The Printed Invoice doesn't contain one of the products.

Manual testing scenario:

Create a Bundle product with two options.

One dropdown option
second checkbox option containing two products

Place an order selecting 1 product from the first option, two products from the second option
Submit and Print the invoice.
Observe the invoice

Actual Result
The first product from the second option is not displayed in the printed invoice

…o for Bundle Product 2.2.1

engcom-Golf · 2020-12-31T14:47:13Z

@magento run all tests

zakdma · 2021-01-04T09:13:54Z

@magento import code to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2021-01-04T09:18:50Z

@zakdma, an error occurred during the Pull Request import.

magento-engcom-team · 2021-01-04T09:20:02Z

@zakdma, an error occurred during the Pull Request import.

magento-engcom-team · 2021-01-04T09:21:01Z

@zakdma, an error occurred during the Pull Request import.

engcom-Bravo · 2021-01-04T10:05:02Z

Manual testing scenario

From Admin Panel, Go to Stores - Tax Rulles, click Add New Tax Rule
Add New Tax Rate, for example, for:

US Customers
All regions (*)
16%
Save Rule

Go to Stores - Configuration - Sales - Tax. Expand Orders, Invoices, Credit Memos Display Settings, and set Including Tax for the following options:

Display Prices
Display Subtotal
Display Shipping Amount

Go to Catalog - Products and add a new Bundle product:

Drop-down option
Radio button option
Checkbox option
Multiple select option

Place a new order with a US Customer, configuring several options from the Bungle product. For example
Go to Invoice and Submit Invoice
Go to Invoices tab and View the previously created Invoice
Print the Invoice
Compare the Invoice from Admin and the Printed document

BEFORE applying changes provided in the PR, the price in the printed invoice did not contain TAX. Thus, the Proce was different

AFTER switching to the PR, the price in the printed invoice is identic with the price in the Invoice from Admin Panel

zakdma · 2021-01-04T10:38:47Z

@magento import code to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2021-01-04T10:43:20Z

@zakdma, an error occurred during the Pull Request import.

magento-engcom-team · 2021-01-04T10:45:58Z

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31455.

m2-assistant · 2021-01-05T13:20:50Z

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Component: Bundle Component: Downloadable Component: Sales labels Dec 24, 2020

magento-engcom-team added the Release Line: 2.4 label Dec 24, 2020

m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Progress: pending review labels Dec 24, 2020

engcom-Golf force-pushed the MC-30127 branch from 6336340 to 7f99bf6 Compare December 24, 2020 14:31

engcom-Golf force-pushed the MC-30127 branch from 7f99bf6 to a64d561 Compare December 24, 2020 15:33

engcom-Golf requested review from viktorpetryk and engcom-Kilo December 28, 2020 08:21

engcom-Kilo suggested changes Dec 28, 2020

View reviewed changes

m2-community-project bot assigned engcom-Kilo Dec 28, 2020

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Dec 28, 2020

engcom-Golf force-pushed the MC-30127 branch from a64d561 to afdc58e Compare December 29, 2020 08:19

engcom-Golf requested a review from engcom-Kilo December 29, 2020 13:03

engcom-Kilo suggested changes Dec 30, 2020

View reviewed changes

engcom-Golf force-pushed the MC-30127 branch from 4276750 to 8023d7f Compare December 30, 2020 11:33

m2-community-project bot added Progress: review and removed Progress: needs update labels Dec 30, 2020

engcom-Golf requested a review from engcom-Kilo December 30, 2020 11:35

engcom-Kilo approved these changes Dec 31, 2020

View reviewed changes

m2-community-project bot removed the Progress: review label Dec 31, 2020

m2-community-project bot added the Progress: testing in progress label Dec 31, 2020

engcom-Bravo requested changes Dec 31, 2020

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: testing in progress labels Dec 31, 2020

Viktor Kopin added 2 commits December 31, 2020 16:35

MC-30127: Product Price is mismatch in invoice and invoice PDF magent…

7988743

…o for Bundle Product 2.2.1

MC-30127: Product Price is mismatch in invoice and invoice PDF magent…

1ce3e1f

…o for Bundle Product 2.2.1

engcom-Golf force-pushed the MC-30127 branch from 8023d7f to 1ce3e1f Compare December 31, 2020 14:37

engcom-Golf requested a review from engcom-Bravo December 31, 2020 14:47

engcom-Kilo approved these changes Dec 31, 2020

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Dec 31, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jan 4, 2021

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Jan 4, 2021

m2-community-project bot added Progress: ready for testing Progress: testing in progress Progress: extended testing and removed Progress: testing in progress Progress: ready for testing labels Jan 4, 2021

magento-engcom-team merged commit 2c3bb67 into magento:2.4-develop Jan 5, 2021

		@@ -7,6 +7,7 @@

		namespace Magento\Bundle\Model\Sales\Order\Pdf\Items;

		use Magento\Framework\App\ObjectManager;

MC-30127: Product Price is mismatch in invoice and invoice PDF magento for Bundle Product #31455

MC-30127: Product Price is mismatch in invoice and invoice PDF magento for Bundle Product #31455

Uh oh!

Conversation

engcom-Golf commented Dec 24, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Expected result

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Dec 24, 2020

Uh oh!

engcom-Golf commented Dec 24, 2020

Uh oh!

engcom-Golf commented Dec 24, 2020

Uh oh!

engcom-Golf commented Dec 24, 2020

Uh oh!

engcom-Kilo Dec 28, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Golf commented Dec 29, 2020

Uh oh!

engcom-Kilo Dec 30, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Kilo Dec 30, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Golf Dec 30, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Golf commented Dec 30, 2020

Uh oh!

engcom-Bravo left a comment

Choose a reason for hiding this comment

Manual testing scenario:

Uh oh!

engcom-Golf commented Dec 31, 2020

Uh oh!

zakdma commented Jan 4, 2021

Uh oh!

magento-engcom-team commented Jan 4, 2021

Uh oh!

magento-engcom-team commented Jan 4, 2021

Uh oh!

magento-engcom-team commented Jan 4, 2021

Uh oh!

engcom-Bravo commented Jan 4, 2021

Manual testing scenario

Uh oh!

zakdma commented Jan 4, 2021

Uh oh!

magento-engcom-team commented Jan 4, 2021

Uh oh!

magento-engcom-team commented Jan 4, 2021

Uh oh!

m2-assistant bot commented Jan 5, 2021

Uh oh!

Uh oh!