Invoice for an order that contains only one configurable product is not generated correctly

[namlier]

Description (*)

When you placing exactly one configurable option two order items appears in order model - one of them is dummy, that just provides useful information about the order. Such kind of dummy items are defined as not the last in invoice model that brings us wrong flow of a total calculation.

Fixed Issues (if relevant)

1. Fixes Invoice for an order that contains only one configurable product is not generated correctly #31143

Manual testing scenarios (*)

Preconditions

1. CE 2.4-develop version
2. Install extension module with feature which can add extra fee on order, for example - https://github.com/mageprince/magento2-paymentfee
3. Add a tax rule
4. Create configurable product
5. Add extra fee on orders, for example - Price type : fixed price, Payment method fee:
   payment method code: "checkmo", fee amount: "30"
   Calculate tax: yes
   Steps
6. Place order with one of options of configurable product, so that the Tax Rule will apply
7. As Admin try create an Invoice

Expected result
Extra payment fee created by the module includes the Tax from the Tax Rule.

Actual result
Extra payment fee created by the module doesn't include the Tax from the Tax Rule

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mastiuhin-olexandr. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[namlier]

@magento run all tests

[engcom-Kilo]

Should be verified with PAT tests.

[zakdma]

@magento import code to https://github.com/magento-tsg/magento2ce

[magento-engcom-team]

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31472.

[m2-assistant]

Hi @mastiuhin-olexandr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[akgola]

@mastiuhin-olexandr , same issue is coming in Report section where custom tax is not getting added even after fixing this by
app/code/Magento/Sales/Model/Order/Invoice.php .
could you please check it.