Skip to content

MC-30104: When using MysqlMQ messages are always set to complete even if exception occurs #31480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2021
Merged

MC-30104: When using MysqlMQ messages are always set to complete even if exception occurs #31480

merged 2 commits into from
Jan 5, 2021

Conversation

engcom-Golf
Copy link
Contributor

Description (*)

Stores lock id in lock object after creation

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes When using MysqlMQ messages are always set to complete even if exception occurs #18140

Manual testing scenarios (*)

  1. Add to \Magento\Catalog\Model\Attribute\Backend\Consumer::process exception throw
  2. Create product
  3. Update attribute by massaction
  4. perform cron:run 3 times command in case if cron is not installed

Expected result:

Status of message in queue_message_status table = 6 (error)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 29, 2020

Hi @engcom-Golf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Dec 29, 2020
@engcom-Golf
Copy link
Contributor Author

@magento run all tests

engcom-Kilo
engcom-Kilo suggested changes Dec 30, 2020
View reviewed changes
dev/tests/integration/testsuite/Magento/MessageQueue/Model/ResourceModel/LockTest.php
*/
class LockTest extends TestCase
{
public function testSaveLock()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't cover initial test case. Please add more specific test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added test that covers original case

@engcom-Golf
Copy link
Contributor Author

@magento run all tests

engcom-Kilo
engcom-Kilo approved these changes Dec 31, 2020
View reviewed changes
dev/tests/integration/testsuite/Magento/MessageQueue/Model/ConsumerTest.php Outdated
}

/**
* Tests running of specific consumer check status if after retry is not in success status but left in progress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is confusing. Please add more clear one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@engcom-Golf
Copy link
Contributor Author

@magento run all tests

@zakdma
Copy link
Contributor

zakdma commented Jan 4, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

@zakdma
Copy link
Contributor

zakdma commented Jan 4, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

@zakdma
Copy link
Contributor

zakdma commented Jan 4, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31480.

@magento-engcom-team magento-engcom-team merged commit d224147 into magento:2.4-develop Jan 5, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 5, 2021

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Kilo engcom-Kilo engcom-Kilo approved these changes

@viktorpetryk viktorpetryk Awaiting requested review from viktorpetryk

Assignees

@engcom-Kilo engcom-Kilo

Labels
Component: MessageQueue Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: review Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using MysqlMQ messages are always set to complete even if exception occurs
4 participants
@engcom-Golf @zakdma @magento-engcom-team @engcom-Kilo