Skip to content

show or hide password widget created #31482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ajithkumar-maragathavel
Copy link
Contributor

@ajithkumar-maragathavel ajithkumar-maragathavel commented Dec 29, 2020

Description (*)

Added a jquery widget that will display a checkbox below the password field in the forms to show/hide the password.
Users can able to toggle between showing/hiding the password.
Below are sections that are affected by this widget:

  1. Customer Login Page.
  2. Customer Registration Page.
  3. Customer Edit Page (Change Password section).
  4. Customer Set New Password Page.

Screenshot:
Customer-Login-show-password

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/451

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Navigate to the customer login page and enter the email and password and then validated the show password functionality.
  2. Navigate to the customer registration page and enter the details in the form and then validated the Show password functionality.
  3. Navigate to the customer edit page and clicked the Change Password checkbox and then validated the Show password functionality.
  4. Navigate to the New Password setup page and validated the Show Password functionality.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] show or hide password widget created #31557: show or hide password widget created

@m2-assistant
Copy link

m2-assistant bot commented Dec 29, 2020

Hi @ajithkumar-maragathavel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ajithkumar-maragathavel
Copy link
Contributor Author

@magento run all tests

@ajithkumar-maragathavel
Copy link
Contributor Author

@magento run all tests

@ajithkumar-maragathavel
Copy link
Contributor Author

@magento run Static Tests

@ajithkumar-maragathavel
Copy link
Contributor Author

@magento run all tests

@gabrieldagama
Copy link
Contributor

@magento create issue

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 7, 2021
@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 7, 2021

Changes were approved by Magento Product Managers

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a nice feature @ajithkumar-maragathavel ! Can you please add an MFTF test covering this functionality?

@ajithkumar-maragathavel
Copy link
Contributor Author

Thanks for a nice feature @ajithkumar-maragathavel ! Can you please add an MFTF test covering this functionality?

Thanks, I will update the PR with the MFTF test. @sivaschenko

@ajithkumar-maragathavel
Copy link
Contributor Author

@magento run all tests

@ajithkumar-maragathavel
Copy link
Contributor Author

@sivaschenko I have covered the changes with the MFTF test. Please review it and let me know your comments.

@sivaschenko
Copy link
Member

@ajithkumar-maragathavel looks great!

@magento run all tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked cases from Manual testing scenarios
Result:
Customer Login Page

  • hide the password
    Screenshot from 2021-02-25 10-35-53
  • show the password
    Screenshot from 2021-02-25 10-35-59

Customer Registration Page

  • hide the password
    Screenshot from 2021-02-25 10-34-09
  • show the password
    Screenshot from 2021-02-25 10-34-18

Customer Edit Page (Change Password section)

  • hide the password
    Screenshot from 2021-02-25 10-37-43
  • show the password
    Screenshot from 2021-02-25 10-37-51

Customer Set New Password Page

  • hide the password
    Screenshot from 2021-02-25 10-46-42
  • show the password
    Screenshot from 2021-02-25 10-46-50

@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@m2-assistant
Copy link

m2-assistant bot commented Mar 7, 2021

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Customer Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Type: Feature/Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] show or hide password widget created
8 participants