Fix delete special prices only for specified store

[engcom-Charlie]

Description (*)

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/448

Fixed Issues (if relevant)

1. Fixes CatalogSpecialPriceStorage API delete does not delete by store id #25907

Manual testing scenarios (*)

1. Set Catalog Price Scope to Website ( Go to Admin -> Stores -> Configuration -> Catalog -> Catalog -> Price and set Catalog Price Scope to Website);
2. Create website, store, store view
3. Create simple products (for example) :
   Simple 1 with Special price = 80$ for previously created store view and 60$ for default store view
4. Call POST V1/products/special-price-delete API specifying previously created store view -> Execute

ER:
The special price for previously created store view was deleted.
The special price for default store view wasn't changed.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run all tests

[coderimus]

Hello @engcom-Charlie
Thank you for the fix and refactoring 👍 I also like the way you modified notification messages construction with iteration them and translate. This makes, as for me, code more friendly.

[magento-engcom-team]

Hi @coderimus, thank you for the review.
ENGCOM-8603 has been created to process this Pull Request
✳️ @coderimus, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Charlie]

@magento run all tests

[engcom-Alfa]

✔️ QA Passed

Case 1

Manual testing scenario:

1. Set Catalog Price Scope to Website ( Go to Admin -> Stores -> Configuration -> Catalog -> Catalog -> Price and set Catalog Price Scope to Website);
2. Create a website, store, store view ( Second Website - Second Store - Second Store View for ex.);
3. Create simple products (for example) :
   Simple 1 with price 100$ and Special price = 85$ for previously created store view ( Second Store View "id = "2")
4. Call POST V1/products/special-price-delete API specifying previously created store view -> Execute
5. Clean cache

Before: ✖️ Special price was deleted for all stores

After: ✔️ We received a response - 200 OK, and the special price was deleted only for the specified store .

Case 2

Manual testing scenario:

1. Set Catalog Price Scope to Global ( Go to Admin -> Stores -> Configuration -> Catalog -> Catalog -> Price and set Catalog Price Scope to Global);
2. Create a website, store, store view ( Second Website - Second Store - Second Store View for ex.);
3. Create simple products (for example) :
   Simple 1 with price 100$ and Special price = 85$ for previously created store view ( Second Store View "id = "2")
4. Call POST V1/products/special-price-delete API specifying previously created store view -> Execute
   

Before: ✖️ Special price was deleted for all stores

After: ✔️ The correct error message is shown

[m2-assistant]

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.