[GraphQl] Add wishlist item to cart Implementation #31584

shikhamis11 · 2021-01-07T12:39:05Z

Description (*)

Implement coverage for this new mutation

https://github.com/magento/architecture/blob/master/design-documents/graph-ql/coverage/customer/Wishlist.graphqls
addWishlistItemsToCart( wishlistUid: ID!, @doc(description: "unique Id of wishlist") wishlistItemUids: [ID!> @doc(description: "Optional param. selected wish list items that are to be added") ): AddWishlistItemsToCartOutput @doc(description: "Add Requisition List Items To Customer Cart")

AC

The field wishlistItemUids in the input can be null. Which implies that all the items in the wishlist will be added to the cart when wishlistItemUids are null.

The status field in the response conveys the result of the operation true/false

The addwishlist_items_to_cart_usererrors field should aggregate all the errors occurred when adding the corresponding items to the cart.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/449

Fixed Issues (if relevant)

Fixes [GraphQl] Add wishlist item to cart Implementation #31331

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-01-07T12:39:07Z

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Added Test for wishlist items add to cart

shikhamis11 · 2021-01-07T12:44:19Z

@magento run all tests

shikhamis11 · 2021-01-07T13:35:20Z

@magento give me test instance

magento-deployment-service · 2021-01-07T13:35:23Z

Hi @shikhamis11. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-01-07T13:40:11Z

Hi @shikhamis11, here is your Magento Instance: https://f0f79f6ed3c10bbb471a47d4dda1253d.instances.magento-community.engineering
Admin access: https://f0f79f6ed3c10bbb471a47d4dda1253d.instances.magento-community.engineering/admin_4c28
Login: d12b5983
Password: 2f5cf47f2051

cpartica · 2021-01-07T15:20:17Z

@magento run all tests

keharper

My comments on the attribute descriptions.

keharper · 2021-01-07T19:46:04Z

app/code/Magento/WishlistGraphQl/etc/schema.graphqls

@@ -23,7 +23,8 @@ type WishlistOutput @doc(description: "Deprecated: `Wishlist` type should be use
 }

 type Wishlist {
-    id: ID @doc(description: "The unique ID for a `Wishlist` object")
+    id: ID @deprecated(reason: "Use `wishlists.uid` instead") @doc(description: "The unique ID for a `Wishlist` object")


Should the reason be "Use Wishlist.uid instead"? If yes, I'd prefer the reason to be "Use uid instead", since both attributes are in the same data type.

keharper · 2021-01-07T19:46:59Z

app/code/Magento/WishlistGraphQl/etc/schema.graphqls

@@ -35,7 +36,8 @@ type Wishlist {
 }

 interface WishlistItemInterface @typeResolver(class: "Magento\\WishlistGraphQl\\Model\\Resolver\\Type\\WishlistItemType") {
-    id: ID!  @doc(description: "The unique ID for a `WishlistItemInterface` object")
+    id: ID!  @deprecated(reason: "Use `WishlistItemInterface.uid` instead") @doc(description: "The unique ID for a `WishlistItemInterface` object")


Same as above regarding the reason text. "Use uid instead"

keharper · 2021-01-07T19:48:19Z

app/code/Magento/WishlistGraphQl/etc/schema.graphqls

@@ -60,6 +62,15 @@ type Mutation {
    addProductsToWishlist(wishlistId: ID!, wishlistItems: [WishlistItemInput!]!): AddProductsToWishlistOutput @doc(description: "Adds one or more products to the specified wish list. This mutation supports all product types") @resolver(class: "\\Magento\\WishlistGraphQl\\Model\\Resolver\\AddProductsToWishlist")
    removeProductsFromWishlist(wishlistId: ID!, wishlistItemsIds: [ID!]!): RemoveProductsFromWishlistOutput @doc(description: "Removes one or more products from the specified wish list") @resolver(class: "\\Magento\\WishlistGraphQl\\Model\\Resolver\\RemoveProductsFromWishlist")
    updateProductsInWishlist(wishlistId: ID!, wishlistItems: [WishlistItemUpdateInput!]!): UpdateProductsInWishlistOutput  @doc(description: "Updates one or more products in the specified wish list") @resolver(class: "\\Magento\\WishlistGraphQl\\Model\\Resolver\\UpdateProductsInWishlist")
+    addWishlistItemsToCart(
+        wishlistUid: ID!, @doc(description: "The unique ID of the requisition list")
+        wishlistItemUids: [ID!] @doc(description: "An array of UIDs presenting products to be added to the cart. If no UIDs are specified, all items in the wishlist will be added to the cart")


Suggested change

wishlistItemUids: [ID!] @doc(description: "An array of UIDs presenting products to be added to the cart. If no UIDs are specified, all items in the wishlist will be added to the cart")

wishlistItemUids: [ID!] @doc(description: "An array of UIDs representing products to be added to the cart. If no UIDs are specified, all items in the wishlist will be added to the cart")

keharper · 2021-01-07T19:56:39Z

app/code/Magento/WishlistGraphQl/etc/schema.graphqls

+    addWishlistItemsToCart(
+        wishlistUid: ID!, @doc(description: "The unique ID of the requisition list")
+        wishlistItemUids: [ID!] @doc(description: "An array of UIDs presenting products to be added to the cart. If no UIDs are specified, all items in the wishlist will be added to the cart")
+    ): AddWishlistItemsToCartOutput @resolver(class: "Magento\\WishlistGraphQl\\Model\\Resolver\\Wishlist\\AddToCart") @doc(description: "Add items in the wishlist to the customer's cart")


Suggested change

): AddWishlistItemsToCartOutput @resolver(class: "Magento\\WishlistGraphQl\\Model\\Resolver\\Wishlist\\AddToCart") @doc(description: "Add items in the wishlist to the customer's cart")

): AddWishlistItemsToCartOutput @resolver(class: "Magento\\WishlistGraphQl\\Model\\Resolver\\Wishlist\\AddToCart") @doc(description: "Add items in the specified wishlist to the customer's cart")

keharper · 2021-01-07T19:58:03Z

app/code/Magento/WishlistGraphQl/etc/schema.graphqls

+
+type AddWishlistItemsToCartOutput {
+    status: Boolean!
+    add_wishlist_items_to_cart_user_errors: [CartUserInputError!]!


Suggested change

add_wishlist_items_to_cart_user_errors: [CartUserInputError!]!

add_wishlist_items_to_cart_user_errors: [CartUserInputError!]! @doc(description: "An array of errors encountered while adding products to the customer's cart")

keharper · 2021-01-07T20:01:28Z

app/code/Magento/WishlistGraphQl/etc/schema.graphqls

+}
+
+type AddWishlistItemsToCartOutput {
+    status: Boolean!


Suggested change

status: Boolean!

status: Boolean! @doc(description: "Indicates whether the attempt to add items to the customer's cart was successful")

shikhamis11 · 2021-01-08T06:07:30Z

@magento run Static Tests

keharper · 2021-01-14T19:28:27Z

These are my opinions only. It's up to Maura and the development team to decide whether to accept or reject my opinions.

This mutation moves products from a wishlist to the cart. Consider renaming the mutation to moveWishlistItemsToCart.
The mutation should return the updated wishlist. I presume this mutation would be run on a wish list page. On Luma, the stops displaying the items that were added to the cart.
Consider returning the cart. The addRequisitionListItemsToCart mutation does this.

prabhuram93

Nice work! couple of comments needs to be addressed. Thanks!

prabhuram93 · 2021-01-20T23:01:49Z

app/code/Magento/WishlistGraphQl/etc/schema.graphqls

@@ -23,7 +23,8 @@ type WishlistOutput @doc(description: "Deprecated: `Wishlist` type should be use
 }

 type Wishlist {
-    id: ID @doc(description: "The unique ID for a `Wishlist` object")
+    id: ID @deprecated(reason: "Use `uid` instead") @doc(description: "The unique ID for a `Wishlist` object")
+    uid: ID @doc(description: "The unique ID for a `Wishlist` object")


@shikhamis11 Good work on the PR! I see you have introduced uid for wishlist, but it will complicate things at this point as it will welcome conflicts on existing mutations. @mauragcyrus We need to have a follow up story, if needed. @shikhamis11 Can you remove this uid here and on the wishlist item. If there are any concerns please reply. thanks!

@prabhuram93 thanks for review. I added uid for Wishlist and WishlistItemInterface as in addWishlistItemsToCart mutation we require wishlistUid & wishlistItemUids

yeah agree. I think that's confusing. I will work with @cpartica on renaming that to wishlistId & wishlistItemItds.

prabhuram93 · 2021-01-20T23:02:05Z

app/code/Magento/WishlistGraphQl/etc/schema.graphqls

@@ -35,7 +36,8 @@ type Wishlist {
 }

 interface WishlistItemInterface @typeResolver(class: "Magento\\WishlistGraphQl\\Model\\Resolver\\Type\\WishlistItemType") {
-    id: ID!  @doc(description: "The unique ID for a `WishlistItemInterface` object")
+    id: ID!  @deprecated(reason: "Use `uid` instead") @doc(description: "The unique ID for a `WishlistItemInterface` object")
+    uid: ID!  @doc(description: "The unique ID for a `WishlistItemInterface` object")


Even this needs to be removed.

prabhuram93 · 2021-01-20T23:04:44Z

app/code/Magento/WishlistGraphQl/Model/Resolver/Wishlist/AddToCart.php

+
+        /** @var AddProductsToCartOutput $addProductsToCartOutput */
+        $addProductsToCartOutput = $this->addProductsToCartService->execute($maskedCartId, $cartItems);
+


How are we removing the items from the wishlist after it is added to the cart?

Actually not removing wishlist items now. I missed that part. I will push changes for this today

shikhamis11 · 2021-01-22T05:52:59Z

@magento run all tests

Fixed test failure

shikhamis11 · 2021-01-22T08:44:56Z

@magento run all tests

dthampy · 2021-01-29T23:55:50Z

app/code/Magento/WishlistGraphQl/etc/schema.graphqls

@@ -60,6 +60,15 @@ type Mutation {
    addProductsToWishlist(wishlistId: ID!, wishlistItems: [WishlistItemInput!]!): AddProductsToWishlistOutput @doc(description: "Adds one or more products to the specified wish list. This mutation supports all product types") @resolver(class: "\\Magento\\WishlistGraphQl\\Model\\Resolver\\AddProductsToWishlist")
    removeProductsFromWishlist(wishlistId: ID!, wishlistItemsIds: [ID!]!): RemoveProductsFromWishlistOutput @doc(description: "Removes one or more products from the specified wish list") @resolver(class: "\\Magento\\WishlistGraphQl\\Model\\Resolver\\RemoveProductsFromWishlist")
    updateProductsInWishlist(wishlistId: ID!, wishlistItems: [WishlistItemUpdateInput!]!): UpdateProductsInWishlistOutput  @doc(description: "Updates one or more products in the specified wish list") @resolver(class: "\\Magento\\WishlistGraphQl\\Model\\Resolver\\UpdateProductsInWishlist")
+    addWishlistItemsToCart(
+        wishlistId: ID!, @doc(description: "The unique ID of the requisition list")


The description should be "The unique ID of the wish list"
Shouldn't the field names match with what the architectural schema dictates : "wishlistUid" and "wishlistItemUids" ?

hi @dthampy thanks for review
I have updated wishlistUid and wishlistItemUids to wishlistId and wishlistItemIds as per change request by @prabhuram93
#31584 (comment)

shikhamis11 · 2021-01-31T14:47:50Z

@magento run all tests

prabhuram93 · 2021-02-16T16:06:19Z

This pull request is being processed internally. Please do not add any more commits on this PR.

m2-assistant · 2021-02-16T23:06:46Z

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

shikhamis11 added 2 commits January 7, 2021 17:57

magento#31331:[GraphQl] Add wishlist item to cart Implementation

1cb56ce

magento#31331:[GraphQl] Add wishlist item to cart Implementation

87827ee

m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jan 7, 2021

magento-engcom-team added Component: WishlistGraphQl Release Line: 2.4 Partner: Cedcommerce partners-contribution Pull Request is created by Magento Partner labels Jan 7, 2021

m2-community-project bot added the Progress: pending review label Jan 7, 2021

magento#31331:[GraphQl] Add wishlist item to cart Implementation

111ecf3

Added Test for wishlist items add to cart

keharper reviewed Jan 7, 2021

View reviewed changes

m2-community-project bot assigned keharper Jan 7, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 7, 2021

magento#31331:[GraphQl] Add wishlist item to cart Implementation

7b66243

keharper mentioned this pull request Jan 14, 2021

GraphQL: Mutation for adding wishlist items to the cart magento/devdocs#8519

Merged

prabhuram93 suggested changes Jan 20, 2021

View reviewed changes

m2-community-project bot assigned prabhuram93 Jan 20, 2021

m2-community-project bot added Progress: needs update Progress: review and removed Progress: review Progress: needs update labels Jan 20, 2021

magento#31331:[GraphQl] Add wishlist item to cart Implementation

bc9567f

magento#31331:[GraphQl] Add wishlist item to cart Implementation

19ab24d

Fixed test failure

prabhuram93 approved these changes Jan 26, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Jan 26, 2021

engcom-Bravo added the Project: GraphQL label Jan 26, 2021

dthampy suggested changes Jan 29, 2021

View reviewed changes

m2-community-project bot assigned dthampy Jan 29, 2021

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Jan 29, 2021

magento#31331:[GraphQl] Add wishlist item to cart Implementation

d9b7a5b

m2-community-project bot added Progress: review and removed Progress: needs update labels Jan 31, 2021

magento-engcom-team merged commit 50efec2 into magento:2.4-develop Feb 16, 2021

	wishlistItemUids: [ID!] @doc(description: "An array of UIDs presenting products to be added to the cart. If no UIDs are specified, all items in the wishlist will be added to the cart")
	wishlistItemUids: [ID!] @doc(description: "An array of UIDs representing products to be added to the cart. If no UIDs are specified, all items in the wishlist will be added to the cart")

	): AddWishlistItemsToCartOutput @resolver(class: "Magento\\WishlistGraphQl\\Model\\Resolver\\Wishlist\\AddToCart") @doc(description: "Add items in the wishlist to the customer's cart")
	): AddWishlistItemsToCartOutput @resolver(class: "Magento\\WishlistGraphQl\\Model\\Resolver\\Wishlist\\AddToCart") @doc(description: "Add items in the specified wishlist to the customer's cart")

	add_wishlist_items_to_cart_user_errors: [CartUserInputError!]!
	add_wishlist_items_to_cart_user_errors: [CartUserInputError!]! @doc(description: "An array of errors encountered while adding products to the customer's cart")

	status: Boolean!
	status: Boolean! @doc(description: "Indicates whether the attempt to add items to the customer's cart was successful")


		/** @var AddProductsToCartOutput $addProductsToCartOutput */
		$addProductsToCartOutput = $this->addProductsToCartService->execute($maskedCartId, $cartItems);

[GraphQl] Add wishlist item to cart Implementation #31584

[GraphQl] Add wishlist item to cart Implementation #31584

Uh oh!

Conversation

shikhamis11 commented Jan 7, 2021 • edited by cpartica Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jan 7, 2021

Uh oh!

shikhamis11 commented Jan 7, 2021

Uh oh!

shikhamis11 commented Jan 7, 2021

Uh oh!

magento-deployment-service bot commented Jan 7, 2021

Uh oh!

magento-deployment-service bot commented Jan 7, 2021

Uh oh!

cpartica commented Jan 7, 2021

Uh oh!

keharper left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shikhamis11 commented Jan 8, 2021

Uh oh!

keharper commented Jan 14, 2021

Uh oh!

prabhuram93 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shikhamis11 commented Jan 22, 2021

Uh oh!

shikhamis11 commented Jan 22, 2021

Uh oh!

dthampy Jan 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shikhamis11 commented Jan 31, 2021

Uh oh!

prabhuram93 commented Feb 16, 2021

Uh oh!

m2-assistant bot commented Feb 16, 2021

Uh oh!

Uh oh!

shikhamis11 commented Jan 7, 2021 •

edited by cpartica

Loading

dthampy Jan 29, 2021 •

edited

Loading