Skip to content

[MFTF] Adding AdminClickAddNewPageOnPagesGridActionGroup #31595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Jan 8, 2021

Description (*)

Tests have been updated with AdminClickAddNewPageOnPagesGridActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] Adding AdminClickAddNewPageOnPagesGridActionGroup #31627: [MFTF] Adding AdminClickAddNewPageOnPagesGridActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2021

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 8, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Semantic Version Checker

@AnnaAPak AnnaAPak force-pushed the add-AdminClickAddNewPageButtonActionGroup branch from 76cb31c to 68de5b2 Compare January 8, 2021 16:39
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 8, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Semantic Version Checker

@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Jan 9, 2021

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Semantic Version Checker

Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnaAPak. Good job. I would recommend focusing on more complex refactoring than replacing clicks with separate action groups. This particular activity might be postponed to the "very end".

Thanks

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8613 has been created to process this Pull Request

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 12, 2021
@sidolov
Copy link
Contributor

sidolov commented Jan 12, 2021

@magento create issue

@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Functional Tests B2B , Functional Tests CE and Functional Tests EE are failed

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Jan 14, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: Cms Component: Widget Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Type: Test Coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Adding AdminClickAddNewPageOnPagesGridActionGroup
7 participants