Skip to content

Removed State/Province of shipping address when not added in billing address by customer #31615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Removed State/Province of shipping address when not added in billing address by customer #31615

wants to merge 9 commits into from

Conversation

saphaljha
Copy link
Contributor

Description (*)

Removed State/Province of shipping address when not added in billing address by customer

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Shipping address region leaking into billing address #31608

Manual testing scenarios (*)

  1. manually tested

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 12, 2021

Hi @saphaljha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 12, 2021
@coderimus coderimus self-assigned this Jan 12, 2021
@saphaljha
Copy link
Contributor Author

@magento run all tests

@saphaljha
Copy link
Contributor Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

1 similar comment
@saphaljha
Copy link
Contributor Author

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

@saphaljha
Copy link
Contributor Author

@magento run Functional Tests CE

1 similar comment
@saphaljha
Copy link
Contributor Author

@magento run Functional Tests CE

@saphaljha
Copy link
Contributor Author

Hello @coderimus ,
Could you please review the PR?

coderimus
coderimus approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @saphaljha
Thank you for the fix 👍

About the solution: take into account that the method should return an object with the specific data filtered by country I think that unset data looks valid. This allowed being sure that the object will have only filtred data.
@sivaschenko can you, please, validate this PR also?

@coderimus coderimus requested a review from sivaschenko February 2, 2021 15:54
@engcom-Alfa engcom-Alfa self-assigned this Feb 3, 2021
@engcom-Alfa
Copy link
Contributor

@coderimus Could you put an appropriate label for test coverage?
Thanks!

engcom-Alfa
engcom-Alfa requested changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saphaljha .
Due to the Magento Definition of Done, all code changes must be covered by automated tests and it's required part of code contribution.
Could you cover your changes with some automated test?
Thanks!

@engcom-Alfa engcom-Alfa added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Feb 5, 2021
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

1 similar comment
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

1 similar comment
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

1 similar comment
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@saphaljha
Copy link
Contributor Author

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

3 similar comments
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

2 similar comments
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

coderimus
coderimus suggested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saphaljha after discussion with @sivaschenko we think that the provided change looks risky because there is a possibility to have 3rd party vendors and customisations relay on the object data.
As a next step, I could suggest reviewing what is the reason _loadByCountry method is applied to already populated Region? Can we ensure this method is applied only to new objects? - cc @sivaschenko

@Den4ik Den4ik mentioned this pull request Feb 16, 2021
Merged
4 tasks
@eduard13
Copy link
Contributor

Hi @saphaljha thank you for the PR, however there is another PR #32187 that provides a better and less risky implementation. Closing this one as not being actual anymore.

Thank you for your contribution.

@eduard13 eduard13 closed this Feb 22, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 22, 2021

Hi @saphaljha, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@sivaschenko sivaschenko Awaiting requested review from sivaschenko

@coderimus coderimus Awaiting requested review from coderimus

Assignees

@coderimus coderimus

@engcom-Alfa engcom-Alfa

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Component: Directory Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shipping address region leaking into billing address
6 participants
@saphaljha @engcom-Alfa @engcom-Hotel @eduard13 @coderimus @magento-engcom-team