Skip to content

Category image does not copy from catalog/tmp/category to catalog/category directory when saving category whilst using database storage method. #31646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

engcom-Kilo
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Category image does not copy from catalog/tmp/category to catalog/category directory when saving category whilst using database storage method #11995

Manual testing scenarios (*)

  1. see Category image does not copy from catalog/tmp/category to catalog/category directory when saving category whilst using database storage method #11995

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 14, 2021

Hi @engcom-Kilo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jan 14, 2021
@engcom-Kilo engcom-Kilo force-pushed the MC-30084 branch 2 times, most recently from 61e30fd to 8504921 Compare January 18, 2021 14:19
@engcom-Kilo engcom-Kilo changed the title [WIP] Category image does not copy from catalog/tmp/category to catalog/category directory when saving category whilst using database storage method. Category image does not copy from catalog/tmp/category to catalog/category directory when saving category whilst using database storage method. Jan 18, 2021
…atalog/category directory when saving category whilst using database storage method.
@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

@danielrussob
Copy link

@magento give me test instance

@magento-deployment-service
Copy link

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

@danielrussob
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@danielrussob
Copy link

issue reproduced on vanilla magento 2.4

@danielrussob
Copy link

issue solved on PR instance

@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Manual testing scenario

  1. From Admin Panel, go to Catalog - Categories
  2. Select an existing Category
  3. Expand Content
  4. Under Category Image click Upload
  5. Open a valid image from local storage
  6. Verify that the previously uploaded image appeared in Preview box
  7. Save category
  8. Open database table media_storage_file_storage
  9. Observe directory column

BEFORE applying changes provided in the PR, the path was catalog/tmp/category
tmp

AFTER switching to the PR, the category image is saved into the catalog/category directory
tmp_after2

Tested with Root and Subcategories

@aleron75
Copy link
Contributor

@magento run Functional Tests CE

@aleron75
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests BB

@aleron75
Copy link
Contributor

@magento run Functional Tests B2B

Copy link
Contributor

@aleron75 aleron75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing B2B functional test doesn't seem related to the changes from this PR.

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-8674 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed
The result is the same as in the report above #31646 (comment)

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@zakdma
Copy link
Contributor

zakdma commented Jan 28, 2021

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31646.

@magento-engcom-team magento-engcom-team merged commit 5d49d67 into magento:2.4-develop Jan 29, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 29, 2021

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Catalog Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Type: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category image does not copy from catalog/tmp/category to catalog/category directory when saving category whilst using database storage method
9 participants