31253 default store breadcrumbs returned for products which in both root categories #31822

sasha19957099 · 2021-01-25T09:02:13Z

Description (*)

Issue was related to the indexer catalog_category_product

Related Pull Requests

Fixed Issues (if relevant)

Fixes Default store (Root category A) breadcrumbs are being returned for New Store (Root category B) when Product belongs to both root categories. #31253

Manual testing scenarios (*)

Magento 2.4.1
1.Two root categories exists in Admin-Categories
2.Two stores exists with different root categories for each of it
3.Each Stores should have atleast one store view.
4.Each Root category should have one sub-category.
5.Product should belong to both stores. i.e. Assign product to all root and sub categories.
6.Run query
{
"store": "engchildren"
}
query {
products(filter: { url_key: { eq: "gabrielle-micro-sleeve-top"} }){
items {
categories {
name
id
url_path
breadcrumbs {
category_id
category_name
category_level
}
}
}
}
}

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Default store (Root category A) breadcrumbs are being returned for New Store (Root category B) when Product belongs to both root categories - fixed catalog_category_product index

…ded tests

…are being returned for New Store (Root category B) when Product belongs to both root categories - added test for not relevant store

m2-assistant · 2021-01-25T09:02:16Z

Hi @sasha19957099. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

sasha19957099 · 2021-01-25T09:02:29Z

@magento run all tests

cpartica · 2021-01-26T14:42:40Z

app/code/Magento/Catalog/Model/Indexer/Category/Product/AbstractAction.php

@@ -379,13 +380,13 @@ private function addFilteringByChildProductsToSelect(Select $select, Store $stor
            []
        )->joinLeft(
            ['child_cpsd' => $this->getTable('catalog_product_entity_int')],
-            'child_cpsd.' . $linkField . ' = '. 'relation_product_entity.' . $linkField
+            'child_cpsd.' . $linkField . ' = ' . 'relation_product_entity.' . $linkField


is there a safer alternative to this?
just concatenating strings as parameters to a mysql query could lead to a sql injection

cpartica · 2021-01-26T14:43:12Z

...sts/integration/testsuite/Magento/Catalog/_files/product_in_two_root_categories_rollback.php

+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\TestFramework\Workaround\Override\Fixture\Resolver;
+
+//$objectManager = Bootstrap::getObjectManager();


don't forget to remove debug code

cpartica · 2021-01-26T15:06:12Z

app/code/Magento/Catalog/Model/Indexer/Category/Product/AbstractAction.php

@@ -171,7 +172,7 @@ protected function reindex()
    {
        foreach ($this->storeManager->getStores() as $store) {
            if ($this->getPathFromCategoryId($store->getRootCategoryId())) {
-                $this->currentStoreId = $store->getId();
+                $this->currentStore = $store;


better to move this to a method that ensures a strict type return
that way when getCurrentStore is used it can throw an error is currentStore is empty

…ned_for_products_which_in_both_root_categories

…n both root categories - fixed requested changes

sasha19957099 · 2021-01-27T13:09:50Z

@magento run all tests

sasha19957099 · 2021-01-27T14:17:28Z

@magento run Functional Tests CE

m2-assistant · 2022-03-09T08:58:07Z

Hi @sasha19957099. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

…o 31253_default_store_breadcrumbs_returned_for_products_which_in_both_root_categories

engcom-Lima · 2022-03-09T09:02:06Z

@magento run all tests

magento-automated-testing · 2022-03-09T09:02:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-03-10T06:47:02Z

@magento run all tests

magento-automated-testing · 2022-03-10T06:47:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-03-10T07:39:41Z

The code review points seem to be addressed, moving it into Pending Review column

Thanks!

engcom-Charlie · 2022-04-07T09:34:45Z

It seems that bot moved this PR from Pending Review to Changes Requested so moving back again to Pending Review.

…ned_for_products_which_in_both_root_categories

ishakhsuvarov · 2022-05-18T16:05:07Z

@magento run all tests

magento-automated-testing · 2022-05-18T16:05:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ishakhsuvarov · 2022-05-18T19:23:00Z

dev/tests/integration/testsuite/Magento/Catalog/_files/product_in_two_root_categories.php

@@ -0,0 +1,67 @@
+<?php


Please use parametrized fixture format

ishakhsuvarov · 2022-05-18T19:23:11Z

...sts/integration/testsuite/Magento/Catalog/_files/product_in_two_root_categories_rollback.php

@@ -0,0 +1,12 @@
+<?php


Please use parametrized fixture format

engcom-Alfa · 2022-05-20T09:55:04Z

Hi @sasha19957099 & @ishakhsuvarov Thanks for your contribution and collaboration.

As I have the latest updates from our internal team, our internal team resolving the PR comments to deliver within a short period along with 2.4.5 release itself in the scope of internal ticket AC-2515.

Any further updates will be posted here.

Thanks

engcom-Alfa · 2022-05-25T06:14:43Z

We raised internal PR-https://github.com/magento-gl/magento2ce/pull/303 along with this PR commits and covering the automation tests and resolved PR comments
Once Internal PR will get merged will notify here

sasha19957099 added 3 commits January 21, 2021 19:11

magento#31253:

f39a5d9

Default store (Root category A) breadcrumbs are being returned for New Store (Root category B) when Product belongs to both root categories - fixed catalog_category_product index

magento#312:default store breadcrumbs returned for another store - ad…

f9df4da

…ded tests

magento/magento2ce#31253:Default store (Root category A) breadcrumbs …

7f93862

…are being returned for New Store (Root category B) when Product belongs to both root categories - added test for not relevant store

magento-engcom-team added Component: Catalog Release Line: 2.4 labels Jan 25, 2021

m2-community-project bot added the Progress: pending review label Jan 25, 2021

sasha19957099 self-assigned this Jan 25, 2021

sasha19957099 added the PAP Partners acceleration program label Jan 25, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 25, 2021

sasha19957099 added Progress: pending review Project: GraphQL and removed Progress: review labels Jan 25, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 25, 2021

sasha19957099 requested a review from cpartica January 25, 2021 09:03

cpartica requested changes Jan 26, 2021

View reviewed changes

m2-community-project bot assigned cpartica Jan 26, 2021

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 26, 2021

cpartica requested changes Jan 26, 2021

View reviewed changes

sasha19957099 added 2 commits January 26, 2021 18:10

Merge branch '2.4-develop' into 31253_default_store_breadcrumbs_retur…

e30e7af

…ned_for_products_which_in_both_root_categories

magento#31252:default store breadcrumbs returned for products which i…

b4767d6

…n both root categories - fixed requested changes

sasha19957099 requested a review from cpartica January 27, 2021 13:16

m2-community-project bot added Progress: to approve and removed Progress: needs update labels Mar 18, 2021

m2-community-project bot added the Progress: needs update label Mar 9, 2022

Merge branch '2.4-develop' of https://github.com/magento/magento2 int…

626ff28

…o 31253_default_store_breadcrumbs_returned_for_products_which_in_both_root_categories

[BUGFIX] - Static test fixes

e8cf253

[TASK] - reverted change

b9fd820

m2-community-project bot added Progress: pending review and removed Progress: needs update labels Mar 10, 2022

engcom-Lima removed their assignment Apr 7, 2022

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Apr 7, 2022

m2-community-project bot added Progress: pending review and removed Progress: needs update labels Apr 7, 2022

Merge branch '2.4-develop' into 31253_default_store_breadcrumbs_retur…

95f9e7a

…ned_for_products_which_in_both_root_categories

ishakhsuvarov requested changes May 18, 2022

View reviewed changes

m2-community-project bot assigned ishakhsuvarov May 18, 2022

m2-community-project bot added Progress: needs update and removed Progress: pending review labels May 18, 2022

m2-community-project bot added Progress: on hold and removed Progress: needs update labels May 25, 2022

magento-devops-reposync-svc merged commit e49a100 into magento:2.4-develop May 30, 2022

31253 default store breadcrumbs returned for products which in both root categories #31822

31253 default store breadcrumbs returned for products which in both root categories #31822

Uh oh!

Conversation

sasha19957099 commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jan 25, 2021

Uh oh!

sasha19957099 commented Jan 25, 2021

Uh oh!

cpartica Jan 26, 2021

Choose a reason for hiding this comment

Uh oh!

cpartica Jan 26, 2021

Choose a reason for hiding this comment

Uh oh!

cpartica Jan 26, 2021

Choose a reason for hiding this comment

Uh oh!

sasha19957099 commented Jan 27, 2021

Uh oh!

sasha19957099 commented Jan 27, 2021

Uh oh!

m2-assistant bot commented Mar 9, 2022

Uh oh!

engcom-Lima commented Mar 9, 2022

Uh oh!

magento-automated-testing bot commented Mar 9, 2022

Uh oh!

engcom-Lima commented Mar 10, 2022

Uh oh!

magento-automated-testing bot commented Mar 10, 2022

Uh oh!

engcom-Lima commented Mar 10, 2022

Uh oh!

engcom-Charlie commented Apr 7, 2022

Uh oh!

ishakhsuvarov commented May 18, 2022

Uh oh!

magento-automated-testing bot commented May 18, 2022

Uh oh!

ishakhsuvarov May 18, 2022

Choose a reason for hiding this comment

Uh oh!

ishakhsuvarov May 18, 2022

Choose a reason for hiding this comment

Uh oh!

engcom-Alfa commented May 20, 2022

Uh oh!

engcom-Alfa commented May 25, 2022

Uh oh!

Uh oh!

sasha19957099 commented Jan 25, 2021 •

edited

Loading