-
Notifications
You must be signed in to change notification settings - Fork 9.4k
The country / region of mail sent from the admin panel is translated into the admin locale. #31875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The country / region of mail sent from the admin panel is translated into the admin locale. #31875
Conversation
…is translated into the admin locale.
Hi @engcom-Charlie. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @engcom-Charlie for the fix, please review the below comment and please note that the following Unit Test has also to be adjusted
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Sales/Test/Unit/Model/Order/Address/RendererTest.php
app/code/Magento/Customer/Block/Address/Renderer/DefaultRenderer.php
Outdated
Show resolved
Hide resolved
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
…s translated into the admin locale. #31875
Hi @engcom-Charlie, thank you for your contribution! |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)