Fixed Importing: non-default multiple value separator can't be used in custom multiple select attribute

[engcom-Charlie]

Description (*)

Fixed issue, covered by the test, refactor test

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Importing: non-default multiple value separator can't be used in custom multiple select attribute #23156

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Charlie]

@magento run all tests

[gabrieldagama]

Hi @engcom-Charlie, thanks for working on this. The changes look good, please follow a small suggestion.

Thanks!

[engcom-Charlie]

@magento run all tests

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8819 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Bravo]

❌ QA Failed

After Checking Data, no errors appear. But after trying to Import, an Undefined index error appears

[engcom-Charlie]

Hi @engcom-Alfa,

I have tried to reproduce this issue on 2.4-develop branch and its still reproducible.

I can able to reproduce the issue by the steps mentioned in your comments. Below are the errors I am getting.

Please let me know if you need any other information.

Thank you!

[engcom-Alfa]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

Hi @engcom-Alfa,

I have tried to reproduce this issue on 2.4-develop branch and its still reproducible.

I can able to reproduce the issue by the steps mentioned in your comments. Below are the errors I am getting.

Please let me know if you need any other information.

Thank you!

Thanks @engcom-Charlie for re checking it. Yeah, I re tried today after your updates, able to reproduce using the same steps!

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Should have a Magento latest instance with sample data

Manual testing scenario:

Follow the same steps defined in my last comment.

Before: ✖️ Data check to import the CSV file was getting failed

After: ✔️ Data check to import the CSV file is getting successful.

[engcom-Alfa]

Forwarding it for extended testing since a automation test job is getting failed continuously. Kind request to update the ticket with the fixes of failures @engcom-Charlie

[engcom-Charlie]

Hi @engcom-Alfa,

The failing test case is for Currency Converter API configuration.

Its failing because its not able to retrieve the currency rate from other website api. None of the code changes made in this PR are responsible for this so moving this issue further.

Thank you!

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[m2-assistant]

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.