Fix #30471 - Page layouts are hard-coded in Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Chooser\Container #31886

Bartlomiejsz · 2021-01-28T23:23:37Z

Description (*)

This is a fix for #30471 issue

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/465

Fixed Issues (if relevant)

Fixes Page layouts are hard-coded in Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Chooser\Container #30471

Manual testing scenarios (*)

Please check fixed issue for steps descrription

Questions or comments

Not sure if any kind of tests would fit here

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…ck\Adminhtml\Widget\Instance\Edit\Chooser\Container

m2-assistant · 2021-01-28T23:23:40Z

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Bartlomiejsz · 2021-01-28T23:25:23Z

@magento run all tests

ihor-sviziev · 2021-01-29T09:55:08Z

@magento run Unit Tests

ihor-sviziev

Hi @Bartlomiejsz,
Could you fix failing unit tests?

engcom-Hotel · 2021-02-01T09:50:58Z

Hello @Bartlomiejsz,
I'll check unit tests.

engcom-Hotel · 2021-02-01T11:16:25Z

@magento run all tests

engcom-Hotel · 2021-02-01T13:21:39Z

@magento run Functional Tests B2B

engcom-Hotel · 2021-02-01T15:05:29Z

@magento run Functional Tests B2B

ihor-sviziev · 2021-02-01T19:49:32Z

@magento run Functional Tests B2B

ihor-sviziev · 2021-02-02T07:16:02Z

@magento run Functional Tests B2B

engcom-Delta · 2021-02-02T09:59:55Z

✔️ QA passed
Manual testing scenario:

Create custom theme with layout: 3-columns-double-footer
Go to Content->Widgets
Click Add Widget
Select Type=Catalog Products List and Design Theme=
Click Continue
Click Storefront Properties->Layout Updates->Add Layout Update
Set Display On=All Page
Check value $pageLayouts in Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Chooser\Container

Before:
❌ The function getPageLayouts() only returns the one provided by Magento_Theme

After:
✔️ The function getPageLayouts() returns the actual list of page layouts declared by the different modules

engcom-Hotel · 2021-02-03T07:08:45Z

@magento run Functional Tests B2B

engcom-Hotel · 2021-02-03T09:03:48Z

@magento run Functional Tests B2B

engcom-Hotel · 2021-02-03T15:41:56Z

@magento run Functional Tests B2B

engcom-Hotel · 2021-02-04T08:59:04Z

@magento run all tests

engcom-Hotel · 2021-02-04T11:13:13Z

@magento run Integration Tests, WebAPI Tests

engcom-Hotel · 2021-02-04T13:21:39Z

@magento run Integration Tests

gabrieldagama · 2021-02-22T12:17:43Z

@magento run all tests

gabrieldagama · 2021-02-22T17:27:33Z

@magento run all tests

ihor-sviziev · 2021-02-24T15:38:07Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

ihor-sviziev · 2021-03-02T11:43:38Z

@magento run Functional Tests B2B

ihor-sviziev · 2021-03-05T07:20:38Z

@magento run Functional Tests B2B

…et\Block\Adminhtml\Widget\Instance\Edit\Chooser\Container #31886

m2-assistant · 2021-03-07T08:22:32Z

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Fix magento#30471 - Page layouts are hard-coded in Magento\Widget\Blo…

1b9f190

…ck\Adminhtml\Widget\Instance\Edit\Chooser\Container

magento-engcom-team added the Component: Widget label Jan 28, 2021

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jan 28, 2021

magento-engcom-team added Release Line: 2.4 Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner labels Jan 28, 2021

m2-community-project bot added the Progress: pending review label Jan 28, 2021

ihor-sviziev self-assigned this Jan 29, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jan 29, 2021

ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Award: bug fix labels Jan 29, 2021

ihor-sviziev requested changes Feb 1, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Feb 1, 2021

engcom-Hotel self-assigned this Feb 1, 2021

Merge branch '2.4-develop' into bugfix/30471_page_layouts_hardcoded

2ea06fb

ihor-sviziev added the Progress: review label Feb 1, 2021

m2-community-project bot removed the Progress: needs update label Feb 1, 2021

m2-community-project bot added the Progress: testing in progress label Feb 2, 2021

engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Feb 2, 2021

m2-community-project bot added Progress: ready for testing Progress: testing in progress Progress: extended testing and removed Progress: testing in progress Progress: ready for testing labels Feb 2, 2021

Merge branch '2.4-develop' into bugfix/30471_page_layouts_hardcoded

db81b6b

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Feb 4, 2021

Merge branch '2.4-develop' into bugfix/30471_page_layouts_hardcoded

23db47e

magento-engcom-team pushed a commit that referenced this pull request Mar 7, 2021

ENGCOM-8729: Fix #30471 - Page layouts are hard-coded in Magento\Widg…

916c67d

…et\Block\Adminhtml\Widget\Instance\Edit\Chooser\Container #31886

magento-engcom-team merged commit 7dd2aac into magento:2.4-develop Mar 7, 2021

magento-engcom-team removed Award: test coverage Award: bug fix labels Mar 7, 2021

gabrieldagama added the Type: Feature/Improvement label Mar 7, 2021

Fix #30471 - Page layouts are hard-coded in Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Chooser\Container #31886

Fix #30471 - Page layouts are hard-coded in Magento\Widget\Block\Adminhtml\Widget\Instance\Edit\Chooser\Container #31886

Uh oh!

Conversation

Bartlomiejsz commented Jan 28, 2021 • edited by engcom-Hotel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jan 28, 2021

Uh oh!

Bartlomiejsz commented Jan 28, 2021

Uh oh!

ihor-sviziev commented Jan 29, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Feb 1, 2021

Uh oh!

engcom-Hotel commented Feb 1, 2021

Uh oh!

engcom-Hotel commented Feb 1, 2021

Uh oh!

engcom-Hotel commented Feb 1, 2021

Uh oh!

ihor-sviziev commented Feb 1, 2021

Uh oh!

ihor-sviziev commented Feb 2, 2021

Uh oh!

engcom-Delta commented Feb 2, 2021

Uh oh!

engcom-Hotel commented Feb 3, 2021

Uh oh!

engcom-Hotel commented Feb 3, 2021

Uh oh!

engcom-Hotel commented Feb 3, 2021

Uh oh!

engcom-Hotel commented Feb 4, 2021

Uh oh!

engcom-Hotel commented Feb 4, 2021

Uh oh!

engcom-Hotel commented Feb 4, 2021

Uh oh!

gabrieldagama commented Feb 22, 2021

Uh oh!

gabrieldagama commented Feb 22, 2021

Uh oh!

ihor-sviziev commented Feb 24, 2021

Uh oh!

ihor-sviziev commented Mar 2, 2021

Uh oh!

ihor-sviziev commented Mar 5, 2021

Uh oh!

m2-assistant bot commented Mar 7, 2021

Uh oh!

Uh oh!

Bartlomiejsz commented Jan 28, 2021 •

edited by engcom-Hotel

Loading