Skip to content

[WIP] Removed CliCacheFlushActionGroup usage for Catalog module #31901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[WIP] Removed CliCacheFlushActionGroup usage for Catalog module #31901

wants to merge 0 commits into from

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Jan 29, 2021 •
edited by m2-assistant bot
Loading

Description

Removed CliCacheFlushActionGroup usage for Catalog module

Resolved issues:

  1. resolves [Issue] Removed CliCacheFlushActionGroup usage for Catalog module #31902: Removed CliCacheFlushActionGroup usage for Catalog module

@m2-assistant
Copy link

m2-assistant bot commented Jan 29, 2021

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 29, 2021
@sergiy-v
Copy link
Contributor Author

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jan 29, 2021
Closed
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Semantic Version Checker

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE,Functional Tests B2B

@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

1 similar comment
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

@eduard13 eduard13 self-assigned this Jan 30, 2021
@eduard13 eduard13 self-requested a review January 30, 2021 20:32
@sergiy-v
Copy link
Contributor Author

@magento run Functional Tests EE

1 similar comment
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Feb 1, 2021

@magento run Functional Tests EE

@sergiy-v sergiy-v changed the title Removed CliCacheFlushActionGroup usage for Catalog module [WIP] Removed CliCacheFlushActionGroup usage for Catalog module Feb 1, 2021
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Feb 1, 2021

Will proceed with fixing the issue for Functional Tests EE.

@sergiy-v
Copy link
Contributor Author

sergiy-v commented Feb 1, 2021

@magento run Functional Tests EE

@sergiy-v sergiy-v closed this Feb 1, 2021
@sergiy-v sergiy-v force-pushed the mftf-CliCacheFlushActionGroup-usage-catalog-p2 branch from 97d01e8 to ad0ba79 Compare February 1, 2021 14:45
@m2-assistant
Copy link

m2-assistant bot commented Feb 1, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sergiy-v
Copy link
Contributor Author

sergiy-v commented Feb 1, 2021

@eduard13 I'm sorry for the mess, I have created new PR for the changes: #31924.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 Awaiting requested review from eduard13

Assignees

@eduard13 eduard13

Labels
Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Removed CliCacheFlushActionGroup usage for Catalog module
3 participants
@sergiy-v @eduard13 @magento-engcom-team