MC-40777: Cannot save product in store view scope without Magento_Catalog::edit_product_design #31998

engcom-Echo · 2021-02-09T08:12:13Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Cannot save product in store view scope without Magento_Catalog::edit_product_design #31973

Manual testing scenarios (*)

See Cannot save product in store view scope without Magento_Catalog::edit_product_design #31973

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…alog::edit_product_design

m2-assistant · 2021-02-09T08:12:15Z

Hi @engcom-Echo. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Echo · 2021-02-09T08:12:26Z

@magento run all tests

…alog::edit_product_design

engcom-Echo · 2021-02-09T10:45:57Z

@magento run all tests

zakdma · 2021-02-10T10:55:48Z

app/code/Magento/Catalog/Model/Product/Authorization.php

+    public function __construct(
+        AuthorizationInterface $authorization,
+        ProductFactory $factory,
+        ?RequestInterface $request = null


Dont think you should use Request inside model.
Please change implementation to not involve request to model.

…alog::edit_product_design

engcom-Echo · 2021-02-12T08:12:12Z

@magento run all tests

…alog::edit_product_design

engcom-Echo · 2021-02-15T15:28:57Z

@magento run all tests

zakdma · 2021-02-16T13:36:01Z

app/code/Magento/Catalog/Model/Product/Authorization.php

@@ -129,6 +129,9 @@ private function hasProductChanged(ProductModel $product, ?array $oldProduct = n
                //No new value
                continue;
            }
+            if ($attribute->getBackendType() == 'datetime' && empty($newValue)) {


Please change second condition to $newValue === null

zakdma · 2021-02-16T13:41:35Z

...tests/integration/testsuite/Magento/Catalog/_files/product_simple_with_design_attributes.php

+    ->setCustomDesignTo('2020-01-03')
+    ->setHasOptions(true);
+/** @var ProductRepositoryInterface $productRepositoryFactory */
+$productRepository = $objectManager->create(ProductRepositoryInterface::class);


Please use get()

…alog::edit_product_design

engcom-Echo · 2021-02-16T13:46:43Z

@magento run all tests

dmitriyprime · 2021-02-17T10:35:00Z

@magento I am working on this

dmitriyprime · 2021-02-17T13:43:30Z

➖ QA failed
If administrator with restricted role changes on Schedule Design Update tab not only Schedule Update From field but for example New Theme or New Layout fields or both he/she cannot save product after changing some product attributes (for example product name) on specific store view.

…alog::edit_product_design

engcom-Echo · 2021-02-18T10:59:02Z

@magento run all tests

engcom-Oscar · 2021-02-18T13:45:58Z

✔️ QA passed

Was checked case from Manual testing scenarios

❌ Before:

✔️ After:

zakdma · 2021-02-24T12:03:10Z

@magento import code to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2021-02-24T12:06:11Z

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31998.

m2-assistant · 2021-03-03T07:42:42Z

Hi @engcom-Echo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

MC-40777: Cannot save product in store view scope without Magento_Cat…

7ad60dd

…alog::edit_product_design

magento-engcom-team added Component: Catalog Release Line: 2.4 labels Feb 9, 2021

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Progress: pending review labels Feb 9, 2021

MC-40777: Cannot save product in store view scope without Magento_Cat…

36ed67f

…alog::edit_product_design

zakdma suggested changes Feb 10, 2021

View reviewed changes

m2-community-project bot assigned zakdma Feb 10, 2021

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Feb 10, 2021

engcom-Echo and others added 2 commits February 10, 2021 14:18

Merge branch '2.4-develop' into MC-40777

804f355

MC-40777: Cannot save product in store view scope without Magento_Cat…

2cf1773

…alog::edit_product_design

MC-40777: Cannot save product in store view scope without Magento_Cat…

c391aee

…alog::edit_product_design

zakdma suggested changes Feb 16, 2021

View reviewed changes

engcom-Echo added 2 commits February 16, 2021 15:45

MC-40777: Cannot save product in store view scope without Magento_Cat…

3a36f4f

…alog::edit_product_design

MC-40777: Cannot save product in store view scope without Magento_Cat…

d2befb2

…alog::edit_product_design

zakdma approved these changes Feb 16, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Feb 16, 2021

engcom-Echo and others added 2 commits February 18, 2021 10:07

Merge branch '2.4-develop' into MC-40777

7962d85

MC-40777: Cannot save product in store view scope without Magento_Cat…

c28a878

…alog::edit_product_design

zakdma approved these changes Feb 18, 2021

View reviewed changes

engcom-Oscar self-assigned this Feb 18, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Feb 18, 2021

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Feb 18, 2021

magento-engcom-team merged commit 5854e9b into magento:2.4-develop Mar 3, 2021

MC-40777: Cannot save product in store view scope without Magento_Catalog::edit_product_design #31998

MC-40777: Cannot save product in store view scope without Magento_Catalog::edit_product_design #31998

Uh oh!

Conversation

engcom-Echo commented Feb 9, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Feb 9, 2021

Uh oh!

engcom-Echo commented Feb 9, 2021

Uh oh!

engcom-Echo commented Feb 9, 2021

Uh oh!

zakdma Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

engcom-Echo commented Feb 12, 2021

Uh oh!

engcom-Echo commented Feb 15, 2021

Uh oh!

zakdma Feb 16, 2021

Choose a reason for hiding this comment

Uh oh!

zakdma Feb 16, 2021

Choose a reason for hiding this comment

Uh oh!

engcom-Echo commented Feb 16, 2021

Uh oh!

dmitriyprime commented Feb 17, 2021

Uh oh!

dmitriyprime commented Feb 17, 2021

Uh oh!

engcom-Echo commented Feb 18, 2021

Uh oh!

engcom-Oscar commented Feb 18, 2021

Uh oh!

zakdma commented Feb 24, 2021

Uh oh!

magento-engcom-team commented Feb 24, 2021

Uh oh!

m2-assistant bot commented Mar 3, 2021

Uh oh!

Uh oh!