REST API Product update url_key doesnt re-gerenate url_rewites when single store enabled #32009

engcom-Charlie · 2021-02-09T11:55:57Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes REST API Product update url_key doesnt re-gerenate url_rewites (INSANE) #30316

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…_rewites when single store enabled

m2-assistant · 2021-02-09T11:55:59Z

Hi @engcom-Charlie. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Charlie · 2021-02-09T11:56:54Z

@magento run all tests

danielrussob · 2021-02-09T17:41:48Z

@magento give me test instance

magento-deployment-service · 2021-02-09T17:41:51Z

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

danielrussob · 2021-02-09T17:41:59Z

@magento give me 2.4-develop instance

magento-deployment-service · 2021-02-09T17:42:00Z

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-02-09T17:48:57Z

Hi @danielrussob, here is your Magento Instance: https://f2f49e8e4d9a6bab831636876b374738-2-4-develop.instances.magento-community.engineering
Admin access: https://f2f49e8e4d9a6bab831636876b374738-2-4-develop.instances.magento-community.engineering/admin_82a2
Login: 27440e6a
Password: 59588b770344

magento-deployment-service · 2021-02-09T17:48:59Z

Hi @danielrussob, here is your Magento Instance: https://f2f49e8e4d9a6bab831636876b374738.instances.magento-community.engineering
Admin access: https://f2f49e8e4d9a6bab831636876b374738.instances.magento-community.engineering/admin_1700
Login: 18318ab5
Password: bc5105d4da01

danielrussob · 2021-02-09T17:59:07Z

Issue reproduced on vanilla 2.4

SKU: 24-MB01

Payload:

{
  "product": {
    "custom_attributes": [
      {
        "attribute_code": "url_key",
        "value": "nuovissimo-url-key-ahaha"
      }
    ]
  }
}

danielrussob · 2021-02-09T17:59:51Z

Issue solved on new instance

SKU: 24-MB01

Payload:

{
  "product": {
    "custom_attributes": [
      {
        "attribute_code": "url_key",
        "value": "nuovissimo-url-key-ahaha"
      }
    ]
  }
}

danielrussob · 2021-02-09T18:20:08Z

Checking commit 558d527 in data 10 september 18 there was a refactor on foreach that could cause bug

aleron75 · 2021-02-09T18:22:04Z

app/code/Magento/Catalog/Model/Product.php

@@ -828,9 +828,6 @@ public function getStoreIds()
        if (!$this->hasStoreIds()) {
            $storeIds = [];
            if ($websiteIds = $this->getWebsiteIds()) {
-                if (!$this->isObjectNew() && $this->_storeManager->isSingleStoreMode()) {
-                    $websiteIds = array_keys($websiteIds);


Hi @engcom-Charlie, thanks for your PR.

I agree that removing this code solves the issue and, as we read in the issue, this code doesn't seem to have any meaning. Actually, @danielrussob found the point in time where the array_keys was introduced causing the error.

But there is a unit test asserting that the method isSingleStoreMode() is called once; indeed now it fails because the method is no more called.

So in order for this PR to be processed, we also need to remove that expectation from the failing unit test.

danielrussob · 2021-02-09T18:23:31Z

app/code/Magento/Catalog/Model/Product.php

@@ -828,9 +828,6 @@ public function getStoreIds()
        if (!$this->hasStoreIds()) {
            $storeIds = [];
            if ($websiteIds = $this->getWebsiteIds()) {
-                if (!$this->isObjectNew() && $this->_storeManager->isSingleStoreMode()) {
-                    $websiteIds = array_keys($websiteIds);


engcom-Bravo · 2021-02-11T12:29:36Z

✔️ QA Passed

Manual testing scenario

From Admin Panel, go to Stores - Configuration - General and set Single Store Mode to Yes
Create a Simple product with setting URL Key under _Search Engine Optimization. Save the product
Open Swagger, and perform {{magento_url}}/rest/all/V1/products/{{sku}} PUT request to change the URL Key

{
  "product": {
    "custom_attributes": [
        {
            "attribute_code": "url_key",
            "value": "my-new-url"
        }
    ]
  }
}

Go to Marketing - URL Rewrites and check if the Request Path has been changed for the previously created Simple Product

BEFORE applying changes provided in the PR, the Request Path did not change

AFTER switching to the PR, the Request Path changed according to the value set in the PUT request

magento-engcom-team · 2021-02-12T21:04:47Z

Hi @danielrussob, thank you for the review.
ENGCOM-8754 has been created to process this Pull Request

engcom-Bravo · 2021-02-15T09:39:25Z

✔️ QA Passed

The result is the same as in the report above #32009 (comment)

…ewites when single store enabled #32009

m2-assistant · 2021-03-07T08:22:32Z

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento#30316: REST API Product update url_key doesnt re-gerenate url…

494eb40

…_rewites when single store enabled

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Feb 9, 2021

magento-engcom-team added Component: Catalog Release Line: 2.4 labels Feb 9, 2021

m2-community-project bot added the Progress: pending review label Feb 9, 2021

Merge branch '2.4-develop' into 30316

883f89b

danielrussob requested review from danielrussob and aleron75 February 9, 2021 18:01

danielrussob assigned danielrussob and aleron75 Feb 9, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Feb 9, 2021

aleron75 reviewed Feb 9, 2021

View reviewed changes

danielrussob added the Award: bug fix label Feb 9, 2021

danielrussob requested changes Feb 9, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Feb 9, 2021

engcom-Charlie and others added 2 commits February 10, 2021 10:49

fixed unit test

35a1aa8

Merge branch '2.4-develop' into 30316

3644e17

engcom-Bravo self-assigned this Feb 11, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Feb 11, 2021

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Feb 11, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Feb 11, 2021

engcom-Bravo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Progress: testing in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Progress: ready for testing labels Feb 11, 2021

m2-community-project bot added Progress: ready for testing Progress: testing in progress Progress: accept and removed Progress: testing in progress Progress: ready for testing labels Feb 11, 2021

danielrussob approved these changes Feb 12, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: accept labels Feb 12, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Feb 15, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Feb 15, 2021

magento-engcom-team pushed a commit that referenced this pull request Mar 7, 2021

ENGCOM-8754: REST API Product update url_key doesnt re-gerenate url_r…

f79ebaa

…ewites when single store enabled #32009

magento-engcom-team merged commit 2305d63 into magento:2.4-develop Mar 7, 2021

gabrieldagama added the Type: Bug Fix label Mar 7, 2021

REST API Product update url_key doesnt re-gerenate url_rewites when single store enabled #32009

REST API Product update url_key doesnt re-gerenate url_rewites when single store enabled #32009

Uh oh!

Conversation

engcom-Charlie commented Feb 9, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Feb 9, 2021

Uh oh!

engcom-Charlie commented Feb 9, 2021

Uh oh!

danielrussob commented Feb 9, 2021

Uh oh!

magento-deployment-service bot commented Feb 9, 2021

Uh oh!

danielrussob commented Feb 9, 2021

Uh oh!

magento-deployment-service bot commented Feb 9, 2021

Uh oh!

magento-deployment-service bot commented Feb 9, 2021

Uh oh!

magento-deployment-service bot commented Feb 9, 2021

Uh oh!

danielrussob commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielrussob commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielrussob commented Feb 9, 2021

Uh oh!

aleron75 Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

danielrussob Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

danielrussob Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

engcom-Bravo commented Feb 11, 2021

Manual testing scenario

Uh oh!

magento-engcom-team commented Feb 12, 2021

Uh oh!

engcom-Bravo commented Feb 15, 2021

Uh oh!

m2-assistant bot commented Mar 7, 2021

Uh oh!

Uh oh!

danielrussob commented Feb 9, 2021 •

edited

Loading

danielrussob commented Feb 9, 2021 •

edited

Loading