Skip to content

MC-40651: A Configuration of a Configurable Product is reset when editing it in the Wish List #32120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 18, 2021
Merged

MC-40651: A Configuration of a Configurable Product is reset when editing it in the Wish List #32120

merged 4 commits into from
Feb 18, 2021

Conversation

SmVladyslav
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes A Configuration of a Configurable Product is reset when editing it in the Wish List #32119

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 11, 2021

Hi @SmVladyslav. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Feb 11, 2021
@zakdma
Copy link
Contributor

zakdma commented Feb 11, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32120.

@SmVladyslav
Copy link
Contributor Author

@magento run all tests

zakdma
zakdma suggested changes Feb 12, 2021
View reviewed changes
...shlist/Test/Mftf/Test/StorefrontUpdateConfigurableProductAttributeOptionFromWishlistTest.xml
<createData entity="ConfigurableProductAddChild" stepKey="addConfigurableProductSecondChild">
<requiredEntity createDataKey="createConfigurableProduct"/>
<requiredEntity createDataKey="createSecondChildProduct"/>
</createData>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please always perform

<magentoCron groups="index" stepKey="reindexInvalidatedIndices"/>

after new product attribute added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@SmVladyslav
Copy link
Contributor Author

@magento run all tests

@SmVladyslav
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests CE, Unit Tests

@SmVladyslav
Copy link
Contributor Author

@magento run Functional Tests B2B

@engcom-Oscar
Copy link

engcom-Oscar commented Feb 16, 2021 •
edited
Loading

✔️ QA passed

Was checked case from Manual testing scenarios

❌ Before:

(/) A Customer is redirected to the editing Product page
(x) The displayed price is =As low as $100.00
(x) The option “black + $100.00” is not pre-selected in the “Color” drop-down

✔️ After:

A Customer redirected to the editing Product page

  • The displayed price = $200.00
  • The option “black +100$ pre-selected in the “Color” drop-down
    Screenshot from 2021-02-16 16-10-08

@zakdma
Copy link
Contributor

zakdma commented Feb 17, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

@zakdma
Copy link
Contributor

zakdma commented Feb 17, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32120.

@magento-engcom-team magento-engcom-team merged commit 4b01d69 into magento:2.4-develop Feb 18, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2021

Hi @SmVladyslav, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakdma zakdma zakdma approved these changes

Assignees

@zakdma zakdma

Labels
Area: Frontend Component: Catalog Component: Swatches Component: Wishlist Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Type: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A Configuration of a Configurable Product is reset when editing it in the Wish List
5 participants
@SmVladyslav @zakdma @magento-engcom-team @engcom-Oscar @gabrieldagama