Customers that have unsubscribed to the newsletter in the time span from when the queue was created and the actual sending of the newsletter still receive newsletters #32186

engcom-Charlie · 2021-02-16T12:33:19Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Customers that have unsubscribed to the newsletter in the time span from when the queue was created and the actual sending of the newsletter still receive newsletters #32116

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-02-16T12:33:22Z

Hi @engcom-Charlie. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Charlie · 2021-02-16T12:34:22Z

@magento run all tests

Den4ik

Hi @engcom-Charlie. Thanks for PR. Can you have a look at my comment below?

Another suggestion for code improvement:

Add call Magento\Newsletter\Model\Subscriber->setStatusChanged(true) into Magento\Newsletter\Model\Subscriber->setStatus
Call setStatus instead of setSubscriberStatus at unsubscribe method
Check isStatusChanged and compare with Subscriber::STATUS_UNSUBSCRIBED in the plugin

What do you think?

Thanks!

app/code/Magento/Newsletter/etc/di.xml

app/code/Magento/Newsletter/Model/Plugin/RemoveSubscriberFromQueue.php

…ce model; refactor

engcom-Charlie · 2021-02-17T12:54:38Z

@magento run all tests

engcom-Charlie · 2021-02-18T12:57:24Z

@magento run all tests

Den4ik · 2021-02-18T16:01:42Z

Hi @engcom-Charlie
Thanks for your work and sorry that confuse you. I discussed changes with @sivaschenko

it would be better to introduce a new class instead of adding new public method to existing API class. I believe in this case it can be easily done as the added method in quite independent

engcom-Charlie · 2021-02-19T09:52:42Z

@magento run all tests

sivaschenko · 2021-02-19T12:34:45Z

app/code/Magento/Newsletter/Model/RemoveSubscriberFromQueueLink.php

+    public function execute(int $subscriberId): void
+    {
+        $this->connection->delete(
+            $this->connection->getTableName('newsletter_queue_link'),


@engcom-Charlie I believe the table name should be retrieved from ResourceConnection

I think is better to add normal resource model QueueLink that extends AbstractDb and use getMainTable in query.
@sivaschenko what do you think?

I don't think we need to introduce a new class for a simple database operation.

Also, implementing granular commands is a better approach comparing to using resource models in terms of maintainability and extensibility.

engcom-Charlie · 2021-02-22T11:48:13Z

@magento run all tests

magento-engcom-team · 2021-02-25T09:16:44Z

Hi @Den4ik, thank you for the review.
ENGCOM-8815 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team · 2021-02-25T13:16:36Z

Hi @sivaschenko, thank you for the review.
ENGCOM-8815 has been created to process this Pull Request

engcom-Alfa · 2021-02-26T07:35:08Z

✔️ QA Passed

Manual testing scenario:

Subscribe 2 customers to the newsletter;
Confirm their subscription;
Create a newsletter queue that is to execute after a few minutes (say 5 for example);
Unsubscribe one of the customers (before the queue executes);

Before: ✖️ Both customers receive the newsletter email

After: ✔️ An unsubscribed customer did not receive the email.
Only іsubscribed users have received emails.

…e time span from when the queue was created and the actual sending of the newsletter still receive newsletters #32186

m2-assistant · 2021-03-18T17:18:30Z

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento#32116

35468fc

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Feb 16, 2021

magento-engcom-team added Component: Newsletter Release Line: 2.4 labels Feb 16, 2021

m2-community-project bot added the Progress: pending review label Feb 16, 2021

Den4ik requested changes Feb 16, 2021

View reviewed changes

app/code/Magento/Newsletter/etc/di.xml Outdated Show resolved Hide resolved

app/code/Magento/Newsletter/Model/Plugin/RemoveSubscriberFromQueue.php Outdated Show resolved Hide resolved

m2-community-project bot assigned Den4ik Feb 16, 2021

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Feb 16, 2021

added method for removing a subscriber from the queue into the resour…

23bfcdd

…ce model; refactor

engcom-Charlie and others added 2 commits February 18, 2021 11:09

removed disabling dbIsolation

d594fa7

Merge branch '2.4-develop' into 32116

0ecec5d

engcom-Charlie added 3 commits February 19, 2021 11:45

Merge branch '2.4-develop' into 32116

d98dc43

moved removing subscriber queue to separate class

ec464f5

improved variable name

64066c4

sivaschenko reviewed Feb 19, 2021

View reviewed changes

m2-community-project bot assigned sivaschenko Feb 19, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Feb 19, 2021

used resourceConnection

f3c3a1d

engcom-Charlie requested review from sivaschenko and Den4ik February 22, 2021 13:41

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Feb 25, 2021

Den4ik added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 25, 2021

engcom-Alfa self-assigned this Feb 25, 2021

m2-community-project bot added Progress: testing in progress Progress: review and removed Progress: ready for testing Progress: testing in progress labels Feb 25, 2021

sivaschenko approved these changes Feb 25, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Feb 25, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Feb 26, 2021

engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Feb 26, 2021

m2-community-project bot added Progress: ready for testing Progress: testing in progress Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: ready for testing Progress: extended testing labels Feb 26, 2021

gabrieldagama mentioned this pull request Mar 18, 2021

Customers that have unsubscribed to the newsletter in the time span from when the queue was created and the actual sending of the newsletter still receive newsletters #32116

Closed

5 tasks

magento-engcom-team pushed a commit that referenced this pull request Mar 18, 2021

ENGCOM-8815: Customers that have unsubscribed to the newsletter in th…

514c7b9

…e time span from when the queue was created and the actual sending of the newsletter still receive newsletters #32186

magento-engcom-team merged commit 65b6c44 into magento:2.4-develop Mar 18, 2021

gabrieldagama added the Type: Bug Fix label Mar 18, 2021

Customers that have unsubscribed to the newsletter in the time span from when the queue was created and the actual sending of the newsletter still receive newsletters #32186

Customers that have unsubscribed to the newsletter in the time span from when the queue was created and the actual sending of the newsletter still receive newsletters #32186

Uh oh!

Conversation

engcom-Charlie commented Feb 16, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Feb 16, 2021

Uh oh!

engcom-Charlie commented Feb 16, 2021

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

engcom-Charlie commented Feb 17, 2021

Uh oh!

engcom-Charlie commented Feb 18, 2021

Uh oh!

Den4ik commented Feb 18, 2021

Uh oh!

engcom-Charlie commented Feb 19, 2021

Uh oh!

sivaschenko Feb 19, 2021

Choose a reason for hiding this comment

Uh oh!

Den4ik Feb 19, 2021

Choose a reason for hiding this comment

Uh oh!

sivaschenko Feb 25, 2021

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Feb 22, 2021

Uh oh!

magento-engcom-team commented Feb 25, 2021

Uh oh!

magento-engcom-team commented Feb 25, 2021

Uh oh!

engcom-Alfa commented Feb 26, 2021

Uh oh!

m2-assistant bot commented Mar 18, 2021

Uh oh!

Uh oh!