[Sales] Fixed order address retriever for prevent populating data from shipping to billing

[Den4ik]

Description (*)

Fixed order address retriever that preventing populate data from shipping address to billing address on presentation layer

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Shipping address region leaking into billing address #31608

Manual testing scenarios (*)

1. Described in Shipping address region leaking into billing address #31608

Questions or comments

Replace #31615

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Den4ik. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Den4ik]

@magento run all tests

[Den4ik]

@magento run all tests

[Den4ik]

@magento run all tests

[Den4ik]

@magento run Functional Tests EE

[eduard13]

Hi @Den4ik, thank you for fix and the test coverage 👍 . I've left couple of comments below, and few questions. Could you please check and fix them.
Feel free to reach me if there are any questions.

Thank you.

[Den4ik]

@magento run all tests

[Den4ik]

Note: action group can't extend another one if it already extends action group

[Den4ik]

@magento run all tests

[eduard13]

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

[eduard13]

@magento run Functional Tests EE

[eduard13]

Good job @Den4ik 👍

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-8805 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

Manual testing scenario

1. Go to Storefront as a Guest Customer, and Add a Product to Cart
2. Proceed to Checkout
3. Fill in all the required fields(email, First Name, Last Name...)
4. Select Croatia as Country, Grad Zagreb as State/Province
   
5. Click Next
6. Uncheck the My billing and shipping address are the same checkbox
7. Fill in all the required fields, set United Kingdom as Country
8. Click Update
9. Place Order
10. From Admin Panel, check the Order Information

BEFORE applying changes provided in the PR, the UK Billing address contained State/Province from Croatia

AFTER switching to the PR

• correct address is displayed in the Order email
  
• also tested the Send Email, Invoice, Ship, Reorder, Credit Memo. in all cases the Billing address is correct.

[m2-assistant]

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.