Email may not be sent if Magento has enabled asynchronous email sending on multiple websites. #32239

engcom-Kilo · 2021-02-22T11:51:50Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Email may not be sent if Magento has enabled asynchronous email sending on multiple websites #31950

Manual testing scenarios (*)

see Email may not be sent if Magento has enabled asynchronous email sending on multiple websites #31950

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…mail sending on multiple websites.

m2-assistant · 2021-02-22T11:51:52Z

Hi @engcom-Kilo. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Kilo · 2021-02-22T11:52:42Z

@magento run all tests

ihor-sviziev · 2021-02-22T14:03:32Z

app/code/Magento/Sales/Model/Order/Email/Sender/CreditmemoSender.php

@@ -100,12 +100,11 @@ public function __construct(
     */
    public function send(Creditmemo $creditmemo, $forceSyncMode = false)
    {
+        $this->identityContainer->setStore($creditmemo->getStore());


It feels more like a workaround as it's changing the shared object that was injected through DI. Right?

Could you provide info on where it used? Can we create a new identity container using the factory, set the correct store, and pass it further where it used?

@ihor-sviziev
It's not injected via di, CreditemmoSender extends from abstract Sender which has dependency on identity interface. Here we use creditmemo identity container implementation for this interface. As far as I found, the creditmemo identity container not used in other places.
As you may see, such workaround has been used from the beginning(and it's true for almost all senders, including abstract one), set store just been called to late which led to issues.
Yes, it'll be more cleaner to create creditmemo identity container via factory, but we already have coupling between objects to high for this sender and adding new dependency will make it even worse.

Ok. I see there used shared="false" in order to prevent state changing. Let's keep it as is for now.

magento2/app/code/Magento/Sales/etc/di.xml

Line 334 in 91aaeec

<argument name="identityContainer" xsi:type="object" shared="false">Magento\Sales\Model\Order\Email\Container\OrderIdentity</argument>

Note: seems like it used only here

magento2/app/code/Magento/Sales/Model/Order/Email/Sender.php

Lines 144 to 150 in c4570d2

protected function getTemplateOptions()

{

return [

'area' => \Magento\Framework\App\Area::AREA_FRONTEND,

'store' => $this->identityContainer->getStore()->getStoreId()

];

}

magento-engcom-team · 2021-02-22T15:04:49Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8807 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

dmitriyprime · 2021-02-24T11:11:15Z

@magento I am working on this

dmitriyprime · 2021-02-24T11:30:58Z

✔️ QA passed
If asynchronous email sending is enabled on site B where "Stores > Configuration > Sales > Sales Emails > Order > Enabled" setting is set to "Yes" orders, invoices, shipments and credit memos email sending works as expected.

Before:

After:

zakdma · 2021-02-24T12:02:49Z

@magento import code to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2021-02-24T12:04:58Z

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32239.

m2-assistant · 2021-03-03T07:42:41Z

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

MC-40950: Email may not be sent if Magento has enabled asynchronous e…

c4570d2

…mail sending on multiple websites.

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Progress: pending review labels Feb 22, 2021

magento-engcom-team added Component: Sales Release Line: 2.4 labels Feb 22, 2021

ihor-sviziev reviewed Feb 22, 2021

View reviewed changes

m2-community-project bot assigned ihor-sviziev Feb 22, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Feb 22, 2021

ihor-sviziev approved these changes Feb 22, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Feb 22, 2021

ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Feb 22, 2021

zakdma approved these changes Feb 23, 2021

View reviewed changes

m2-community-project bot assigned zakdma Feb 23, 2021

magento-engcom-team merged commit 5c360b8 into magento:2.4-develop Mar 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Email may not be sent if Magento has enabled asynchronous email sending on multiple websites. #32239

Email may not be sent if Magento has enabled asynchronous email sending on multiple websites. #32239

Uh oh!

engcom-Kilo commented Feb 22, 2021

Uh oh!

m2-assistant bot commented Feb 22, 2021

Uh oh!

engcom-Kilo commented Feb 22, 2021

Uh oh!

ihor-sviziev Feb 22, 2021 •

edited

Loading

Uh oh!

engcom-Kilo Feb 22, 2021

Uh oh!

ihor-sviziev Feb 22, 2021

Uh oh!

magento-engcom-team commented Feb 22, 2021

Uh oh!

dmitriyprime commented Feb 24, 2021

Uh oh!

dmitriyprime commented Feb 24, 2021

Uh oh!

zakdma commented Feb 24, 2021

Uh oh!

magento-engcom-team commented Feb 24, 2021

Uh oh!

m2-assistant bot commented Mar 3, 2021

Uh oh!

Uh oh!

	protected function getTemplateOptions()
	{
	return [
	'area' => \Magento\Framework\App\Area::AREA_FRONTEND,
	'store' => $this->identityContainer->getStore()->getStoreId()
	];
	}

Email may not be sent if Magento has enabled asynchronous email sending on multiple websites. #32239

Email may not be sent if Magento has enabled asynchronous email sending on multiple websites. #32239

Uh oh!

Conversation

engcom-Kilo commented Feb 22, 2021

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Feb 22, 2021

Uh oh!

engcom-Kilo commented Feb 22, 2021

Uh oh!

ihor-sviziev Feb 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

engcom-Kilo Feb 22, 2021

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev Feb 22, 2021

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Feb 22, 2021

Uh oh!

dmitriyprime commented Feb 24, 2021

Uh oh!

dmitriyprime commented Feb 24, 2021

Uh oh!

zakdma commented Feb 24, 2021

Uh oh!

magento-engcom-team commented Feb 24, 2021

Uh oh!

m2-assistant bot commented Mar 3, 2021

Uh oh!

Uh oh!

ihor-sviziev Feb 22, 2021 •

edited

Loading