Skip to content

MC-23989: Mini cart missing when you edit inline welcome message for guest and use special characters #32251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2021
Merged

MC-23989: Mini cart missing when you edit inline welcome message for guest and use special characters #32251

merged 7 commits into from
Mar 11, 2021

Conversation

engcom-Echo
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes: #32250

Manual testing scenarios (*)

  1. See: Mini cart missing when you edit inline welcome message for guest and use special characters #32250

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 23, 2021

Hi @engcom-Echo. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Feb 23, 2021
@engcom-Echo
Copy link
Contributor Author

@magento run all tests

@engcom-Echo
Copy link
Contributor Author

@magento run all tests

zakdma
zakdma suggested changes Feb 23, 2021
View reviewed changes
app/code/Magento/Theme/view/frontend/templates/html/header.phtml Outdated
</span>
<!-- /ko -->
<!-- ko ifnot: customer().fullname -->
<span class="not-logged-in"
data-bind='html:"<?= $block->escapeHtml($welcomeMessage) ?>"'></span>
data-bind="html: "<?= $escaper->escapeHtml($welcomeMessage) ?>"></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution looks unreliable. Please tru to leave quotes as was but change escaper method to escapeHtmlAttribute
Please add tests to cover changes

@zakdma
Copy link
Contributor

zakdma commented Mar 3, 2021

@magento run all tests

@zakdma
Copy link
Contributor

zakdma commented Mar 3, 2021

@magento run Database Compare, Functional Tests B2B, Functional Tests EE

@zakdma
Copy link
Contributor

zakdma commented Mar 4, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32251.

@zakdma
Copy link
Contributor

zakdma commented Mar 4, 2021

@magento run all tests

@zakdma
Copy link
Contributor

zakdma commented Mar 4, 2021

@magento run Functional Tests B2B

1 similar comment
@zakdma
Copy link
Contributor

zakdma commented Mar 4, 2021

@magento run Functional Tests B2B

@zakdma
Copy link
Contributor

zakdma commented Mar 5, 2021

@magento run all tests

@zakdma
Copy link
Contributor

zakdma commented Mar 9, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32251.

@magento-engcom-team magento-engcom-team merged commit 2dace84 into magento:2.4-develop Mar 11, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2021

Hi @engcom-Echo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakdma zakdma zakdma approved these changes

Assignees

@zakdma zakdma

Labels
Area: Frontend Component: Theme Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for testing Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mini cart missing when you edit inline welcome message for guest and use special characters
3 participants
@engcom-Echo @zakdma @magento-engcom-team