Fix syntax error in jQuery cookie when samesite option not set

[aapokiiso]

Description (*)

If the samesite option was not set, the cookie would be malformed due to a dangling lax being appended to it. For example calling $.cookie('foo', 'bar', {domain: 'foobar.com'}) would call document.cookie = foo=bar; domain=foobar.comlax;

Manual testing scenarios (*)

1. Open browser dev tools.
2. Add the following logpoint to lib/jquery/jquery.cookie.js for debugging:
   
3. Type jQuery.cookie('foo', 'bar', {domain: 'foobar.com'}) to the dev tools console.
4. Notice that the cookie syntax is invalid.
   

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fix syntax error in jQuery cookie when samesite option not set #32297: Fix syntax error in jQuery cookie when samesite option not set

[m2-assistant]

Hi @aapokiiso. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[aapokiiso]

@magento run all tests

[mrtuvn]

Fail report tests static seem not related with this changes

[ihor-sviziev]

Feels like it will work not correctly.
THe default value for samesite should be lax. So I would suggest to change it to something like this:

Suggested change

	options.samesite ? '; samesite=' + options.samesite : '',
	'; samesite=' + (options.samesite ? options.samesite : 'lax'),

[ihor-sviziev]

@sivaschenko @sidolov seems like this is critical issue. Please prioritize it

[ihor-sviziev]

@magento create issue

[ihor-sviziev]

@aapokiiso will you be able to update your PR as suggested?

[hostep]

This should also be fixed over here: https://github.com/magento/magento2/blob/2.4.2/lib/web/mage/cookies.js#L79 I think.

https://jsfiddle.net/wzt746hm/

[ihor-sviziev]

@hostep maybe you could create an alternative pull request that will fix the issue in all places?
Update: I'm working on a fix already

[ihor-sviziev]

Hi @aapokiiso,
Unfortunately, we didn't get any response from you for 2 weeks, so I prepared a new PR that fixes the same issue #32462.
I'll close this PR in favor of #32462.

[m2-assistant]

Hi @aapokiiso, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.