Replace repetitive actions with Action Groups in AdminConfigurableProductChildrenOutOfStockTest #32293

kate-kyzyma · 2021-02-26T05:49:44Z

Description (*)

The test is refactored according to the best practices followed by MFTF.

Related Pull Requests

Fixed Issues (if relevant)

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Replace repetitive actions with Action Groups in AdminConfigurableProductChildrenOutOfStockTest #32378: Replace repetitive actions with Action Groups in AdminConfigurableProductChildrenOutOfStockTest

m2-assistant · 2021-02-26T05:49:46Z

Hi @kate-kyzyma. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

kate-kyzyma · 2021-02-26T05:54:17Z

@magento run all tests

gabrieldagama · 2021-03-04T17:48:15Z

@magento create issue

kate-kyzyma · 2021-03-15T07:40:19Z

@magento run Functional Tests EE, Functional Tests B2B, Static Tests

…hildrenOutOfStockTest

kate-kyzyma · 2021-03-17T07:54:33Z

@magento run all tests

kate-kyzyma · 2021-03-17T12:14:10Z

@magento run Functional Tests B2B

kate-kyzyma · 2021-04-09T10:44:54Z

@magento run Functional Tests B2B

eduard13

Thank you @kate-kyzyma for the improvements. Can we implement the new ActionGroup through all the tests that have <fillField selector="{{AdminProductFormSection.productQuantity}}"...?
Thank you.

engcom-Charlie · 2021-09-02T13:25:05Z

Hi @kate-kyzyma, @eduard13,

Thanks for your contribution!

I am working on the requested changes. I will implement the new ActionGroup from this PR “AdminFillProductQtyOnProductFormActionGroup” through all the tests that have <fillField selector="{{AdminProductFormSection.productQuantity}}".

Thank you!

…AdminConfigurableProductChildrenOutOfStockTest

engcom-Charlie · 2021-09-03T09:21:10Z

I have merged magento 2.4-develop branch in this PR repo.

NOTE: It has been found that "AdminFillProductQtyOnProductFormActionGroup" i.e. app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminFillProductQtyOnProductFormActionGroup.xml file is already present on magento 2.4-develop branch so it got removed from this PR changes after merge.

Now will use “AdminFillProductQtyOnProductFormActionGroup” through all the tests that have <fillField selector="{{AdminProductFormSection.productQuantity}}". Working on it.

engcom-Charlie · 2021-09-06T05:12:29Z

@magento run all tests

magento-automated-testing · 2021-09-06T05:12:36Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-10-14T05:49:37Z

@magento run all tests

magento-automated-testing · 2021-10-14T05:49:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…hildrenOutOfStockTest

eduard13 · 2021-10-14T05:50:05Z

@magento run all tests

magento-automated-testing · 2021-10-14T05:50:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-10-14T05:50:47Z

Hi @eduard13, thank you for the review.
ENGCOM-9259 has been created to process this Pull Request

…hildrenOutOfStockTest

eduard13 · 2021-10-20T11:41:17Z

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE

magento-automated-testing · 2021-10-20T11:41:24Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…hildrenOutOfStockTest

kate-kyzyma · 2021-10-22T11:40:53Z

@magento run all tests

magento-automated-testing · 2021-10-22T11:40:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

kate-kyzyma · 2021-10-25T13:15:36Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

magento-automated-testing · 2021-10-25T13:15:39Z

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

…hildrenOutOfStockTest # Conflicts: # app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminProductTypeSwitchingOnEditingTest/AdminConfigurableProductTypeSwitchingToVirtualProductTest.xml

kate-kyzyma · 2021-10-25T13:24:15Z

@magento run all tests

magento-automated-testing · 2021-10-25T13:24:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…hildrenOutOfStockTest

eduard13 · 2021-11-09T18:55:39Z

@magento run all tests

magento-automated-testing · 2021-11-09T18:55:43Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-11-10T05:44:50Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-11-10T05:45:15Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-11-10T05:45:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…nfigurableProductChildrenOutOfStockTest #32293

Refactoring the test

b8e289a

magento-engcom-team added Component: Catalog Component: ConfigurableProduct Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 26, 2021

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 4, 2021

m2-community-project bot added the Progress: pending review label Mar 4, 2021

m2-assistant bot mentioned this pull request Mar 4, 2021

[Issue] Replace repetitive actions with Action Groups in AdminConfigurableProductChildrenOutOfStockTest #32378

Closed

4 tasks

Merge branch '2.4-develop' into Refactoring-AdminConfigurableProductC…

291a59f

…hildrenOutOfStockTest

eduard13 self-assigned this Jun 2, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jun 2, 2021

eduard13 requested changes Jun 2, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jun 2, 2021

eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 2, 2021

engcom-Charlie self-assigned this Sep 2, 2021

Merge remote-tracking branch 'magento2/2.4-develop' into Refactoring-…

904b5a7

…AdminConfigurableProductChildrenOutOfStockTest

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Oct 14, 2021

Merge branch '2.4-develop' into Refactoring-AdminConfigurableProductC…

81c139e

…hildrenOutOfStockTest

magento-engcom-team added the Component: Swatches label Oct 14, 2021

Merge branch '2.4-develop' into Refactoring-AdminConfigurableProductC…

16bed42

…hildrenOutOfStockTest

Merge branch '2.4-develop' into Refactoring-AdminConfigurableProductC…

6f9781a

…hildrenOutOfStockTest

Merge branch '2.4-develop' into Refactoring-AdminConfigurableProductC…

0c2ae41

…hildrenOutOfStockTest # Conflicts: # app/code/Magento/ConfigurableProduct/Test/Mftf/Test/AdminProductTypeSwitchingOnEditingTest/AdminConfigurableProductTypeSwitchingToVirtualProductTest.xml

Merge branch '2.4-develop' into Refactoring-AdminConfigurableProductC…

f52abb1

…hildrenOutOfStockTest

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Nov 24, 2021

magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 5, 2022

ENGCOM-9259: Replace repetitive actions with Action Groups in AdminCo…

1fc382d

…nfigurableProductChildrenOutOfStockTest #32293

magento-devops-reposync-svc merged commit a1d4bfd into magento:2.4-develop Apr 5, 2022

Replace repetitive actions with Action Groups in AdminConfigurableProductChildrenOutOfStockTest #32293

Replace repetitive actions with Action Groups in AdminConfigurableProductChildrenOutOfStockTest #32293

Uh oh!

Conversation

kate-kyzyma commented Feb 26, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Feb 26, 2021

Uh oh!

kate-kyzyma commented Feb 26, 2021

Uh oh!

gabrieldagama commented Mar 4, 2021

Uh oh!

kate-kyzyma commented Mar 15, 2021

Uh oh!

kate-kyzyma commented Mar 17, 2021

Uh oh!

kate-kyzyma commented Mar 17, 2021

Uh oh!

kate-kyzyma commented Apr 9, 2021

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Sep 2, 2021

Uh oh!

engcom-Charlie commented Sep 3, 2021

Uh oh!

engcom-Charlie commented Sep 6, 2021

Uh oh!

magento-automated-testing bot commented Sep 6, 2021

Uh oh!

eduard13 commented Oct 14, 2021

Uh oh!

magento-automated-testing bot commented Oct 14, 2021

Uh oh!

eduard13 commented Oct 14, 2021

Uh oh!

magento-automated-testing bot commented Oct 14, 2021

Uh oh!

magento-engcom-team commented Oct 14, 2021

Uh oh!

eduard13 commented Oct 20, 2021

Uh oh!

magento-automated-testing bot commented Oct 20, 2021

Uh oh!

kate-kyzyma commented Oct 22, 2021

Uh oh!

magento-automated-testing bot commented Oct 22, 2021

Uh oh!

kate-kyzyma commented Oct 25, 2021

Uh oh!

magento-automated-testing bot commented Oct 25, 2021

Uh oh!

kate-kyzyma commented Oct 25, 2021

Uh oh!

magento-automated-testing bot commented Oct 25, 2021

Uh oh!

eduard13 commented Nov 9, 2021

Uh oh!

magento-automated-testing bot commented Nov 9, 2021

Uh oh!

magento-automated-testing bot commented Nov 10, 2021

Uh oh!

magento-automated-testing bot commented Nov 10, 2021

Uh oh!

magento-automated-testing bot commented Nov 10, 2021

Uh oh!

Uh oh!

kate-kyzyma commented Feb 26, 2021 •

edited by m2-assistant bot

Loading