Some strings not translatable in M2.4.1

[engcom-Kilo]

Description (*)

Translation load happens to late, skipping all observers subscribed on controller action predispatch

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Some strings not translatable in M2.4.1 #31849

Manual testing scenarios (*)

1. Some strings not translatable in M2.4.1 #31849

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Kilo. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Kilo]

@magento run all tests

[mrtuvn]

@magento run Functional Tests EE, Functional Tests B2B

[mrtuvn]

@engcom-Kilo Can you check with coverage if we remove unneccessary part load translate in here ? Maybe we call load for translate part twice

trace paths
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Theme/Plugin/LoadDesignPlugin.php <= this call to desginLoader for load translate

https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/View/DesignLoader.php#L55 <= area load translate part
Actually this call load for design first -> then load to translate -> then check design change

LoadDesignPlugin is already known caused high load make write a lot cache to redis localstorage on server. We should addressing this

[ihor-sviziev]

@engcom-Kilo feels like your test coverage isn’t covering the case with translation. Can we write some integration test for that?

[engcom-Kilo]

@engcom-Kilo Can you check with coverage if we remove unneccessary part load translate in here ? Maybe we call load for translate part twice

trace paths
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Theme/Plugin/LoadDesignPlugin.php <= this call to desginLoader for load translate

https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/View/DesignLoader.php#L55 <= area load translate part
Actually this call load for design first -> then load to translate -> then check design change

LoadDesignPlugin is already known caused high load make write a lot cache to redis localstorage on server. We should addressing this

Hello @mrtuvn
Thanks for your notice. I've seen this plugin, there will be no additional loading because of local cache

magento2/lib/internal/Magento/Framework/App/AreaList.php

Line 128 in dfd17e9

if (!isset($this->_areaInstances[$code])) {

magento2/lib/internal/Magento/Framework/App/Area.php

Line 204 in dfd17e9

if (isset($this->_loadedParts[$part])) {

[engcom-Kilo]

@engcom-Kilo feels like your test coverage isn’t covering the case with translation. Can we write some integration test for that?

Hello @ihor-sviziev
Unfortunately I haven't found possibility to verify this changes with integration test as

magento2/dev/tests/integration/framework/Magento/TestFramework/Annotation/AppArea.php

Line 83 in f258736

$this->_application->loadArea($area);

called on test start, which invokes

magento2/lib/internal/Magento/Framework/App/Area.php

Line 245 in f258736

$this->_translator->loadData(null, false);

before front controller, and translations are working anyway, with changes or without.

[engcom-Kilo]

@magento run all tests

[ihor-sviziev]

@magento run Database Compare, Functional Tests B2B, WebAPI Tests

[ihor-sviziev]

✔ Approved.

Failing tests looks not related to changes form this PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8881 has been created to process this Pull Request

[ihor-sviziev]

@magento run Functional Tests B2B

[dmitriyprime]

✔️ QA passed

Before:

After:

[zakdma]

@magento import code to https://github.com/magento-tsg/magento2ce

[magento-engcom-team]

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32326.

[m2-assistant]

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.