Skip to content

Base price storage website price mode #32371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wassuupp
Copy link

@wassuupp wassuupp commented Mar 4, 2021

Fix V1/products/base-prices endpoint to update prices for Catalog Price Mode - Website

V1/products/base-prices endpoint does not work with Catalog Price Mode - Website
Function was added to affect prices for all store views inside changed website

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Issue] Base price storage website price mode #30132

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2021

Hi @wassuupp. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@wassuupp
Copy link
Author

wassuupp commented Mar 4, 2021

@magento run all tests

@gabrieldagama gabrieldagama added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Mar 4, 2021
@wassuupp
Copy link
Author

wassuupp commented Mar 4, 2021

@magento run WebAPI Tests

1 similar comment
@nuzil
Copy link
Contributor

nuzil commented Mar 5, 2021

@magento run WebAPI Tests

@nuzil
Copy link
Contributor

nuzil commented Mar 5, 2021

@magento run WebAPI Tests

@nuzil
Copy link
Contributor

nuzil commented Mar 5, 2021

@magento run WebAPI Tests

@nuzil
Copy link
Contributor

nuzil commented Mar 6, 2021

@magento run WebAPI Tests

@nuzil
Copy link
Contributor

nuzil commented Mar 7, 2021

@magento run WebAPI Tests

1 similar comment
@nuzil
Copy link
Contributor

nuzil commented Mar 7, 2021

@magento run WebAPI Tests

@nuzil
Copy link
Contributor

nuzil commented Mar 8, 2021

@magento run WebAPI Tests

@nuzil
Copy link
Contributor

nuzil commented Mar 8, 2021

@magento run WebAPI Tests

@nuzil
Copy link
Contributor

nuzil commented Mar 8, 2021

@magento run all tests

@nuzil
Copy link
Contributor

nuzil commented Mar 8, 2021

@magento run all tests

@engcom-Charlie
Copy link
Contributor

As per the process, since the PR raised and approved by same community contributor ie. @nuzil, requesting other community members to review the PR again.

So moving this PR to Pending Review.

Thank you!

@wassuupp
Copy link
Author

wassuupp commented Dec 27, 2021

@engcom-Charlie , @engcom-Alfa . Excuse for the lack of description.

  1. Switch price mode to "Website".
  2. Create at least one additional store view inside website which you would like to be tested.
  3. Change price for website product using API request.
  4. Open this product using admin for one store view, then for another store view.
    You`ll observe that price was changed only for default store view, despite on checkbox "Use Default Value" value.
    According to the logic, the price should be changed for all store views among website.

@nuzil
Copy link
Contributor

nuzil commented Apr 6, 2022

@engcom-Charlie @engcom-Alfa
Hey guys, can I ping you and ask for update here?

@sidolov sidolov removed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. labels Apr 6, 2022
@ishakhsuvarov ishakhsuvarov self-requested a review April 12, 2022 16:25
@engcom-Alfa
Copy link
Contributor

@engcom-Charlie @engcom-Alfa Hey guys, can I ping you and ask for update here?

HI @nuzil Delayed due to various reasons and apologise please!
It is being discussed and will be progressed faster tomorrow
Thanks for your patience

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 14, 2022
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

  1. Have a Magento installed with latest 2.4-develop code updates
  2. Make sure to create multi stores, and 1 store having at least 2 store views as shown in below screenshot (make sure store websites are working fine!).
    image

Manual testing scenario:

  1. Admin login: Stores> Configuration> Catalog> Catalog> Price : Set Catalog Price Mode - Website

  2. Create a new product that is linked to all 3 websites

  3. View the product edit pages in admin side and check given price is set with all websites scope.

  4. Rest API - Request a Post call with rest endpoints - {{MagentoInstance}}/rest/default/V1/products/base-prices; Where the request body has to be like: { "prices": [ { "price": 22, "store_id": 2, "sku": "BasePrice12", "extension_attributes": {} } ] } Where the store_id should be as per the store_id available for created 2 store views' store.

  5. Admin : Product edit page> Change the scope of the store view 1 i.e under one store, and check the updated price.

  6. Change the scope of the store view 2 i.e under same one store, and check the updated price.

Before: ✖️ Price was not getting updated in both the store views under one store.

After: ✔️ Price is getting updated in both the store views under one store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Catalog Partner: Comwrap partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Base price storage website price mode