Update ListProduct.php #32389

mamsincl · 2021-03-05T17:42:21Z

use current() method of ArrayIterator object instead of current() php function in Magento\Catalog\Block\Product\ListProduct
to prevent exception of Call to a member function getId() on bool using Magento 2.4.x with PHP7.4

Description

ArrayIterator PHP object behaves differently under PHP7.4 and PHP7.3.
With the earlier version, native PHP array functions (including current()) can handle object as array, but not with PHP7.4
Using object's implemented method instead of native function.

Related Pull Requests

Fixed Issues (if relevant)

Fixes ArrayIterator incompatible method current() php 7.4 #32088

Manual testing scenarios (*)

open previously broken PDP

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

use `current()` method of ArrayIterator object instead of `current()` php function

m2-assistant · 2021-03-05T17:42:24Z

Hi @mamsincl. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mamsincl · 2021-03-05T17:42:54Z

@magento run all tests

mamsincl · 2021-03-07T12:47:30Z

@magento run Functional Tests EE, Unit Tests, WebAPI Tests

mamsincl · 2021-03-07T15:08:15Z

I checked All automated tests passed successfully (all builds are green) checkbox, as the small modification of the PR does not introduce any new public method which requires any additional automated/functional/unit tests

The failed tests ~~- might be caused by the general condition of branch 2.4-develop -~~ are:

Functional Tests EE
Unit Tests
WebAPI Tests

Update
related unit test checked, modified and PRd, awaiting test results

modify return value of GetIteration on catCollectionMock

mamsincl · 2021-03-08T09:03:20Z

@magento run all tests

mamsincl · 2021-03-08T11:17:45Z

Failed tests re-triggered
@magento run Functional Tests EE, Functional Tests B2B

note:

previously succeeded Functional Tests B2B failed as Admin user create Partial Invoice for order with Virtual product on Custom stock from Main Website - not related
Functional Tests EE failed as Apply Catalog Price Rule in Magento EE - not related

mamsincl · 2021-03-08T13:30:37Z

I am marking PR as all automated test passed successfully: Functional Tests EE failed a different reason this time, re-triggered again (and last time)

@magento run Functional Tests EE

note:

Functional Tests EE failed as MC-32285: Product Source Grid Verification for multiple product sources.

magento-engcom-team · 2021-03-09T08:54:51Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8906 has been created to process this Pull Request

magento-engcom-team · 2021-03-09T08:54:52Z

@mamsincl thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

brucemead · 2021-03-11T19:21:28Z

Please add Ayko Partner label.

ihor-sviziev · 2021-03-11T19:25:17Z

@sidolov @gabrieldagama, could you check with author why partner label not assigned automatically?

brucemead · 2021-03-11T19:26:40Z

@ihor-sviziev I've just added @mamsincl to our team so that will be why

magento-engcom-team · 2021-03-11T19:29:53Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8906 has been created to process this Pull Request

engcom-Oscar · 2021-03-15T08:48:05Z

@engcom-Foxtrot can you please check this PR, it require dev-experience.

engcom-Foxtrot · 2021-03-16T13:39:08Z

QA passed

m2-assistant · 2021-03-18T17:18:31Z

Hi @mamsincl, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Update ListProduct.php

e5b3bb3

use `current()` method of ArrayIterator object instead of `current()` php function

magento-engcom-team added Component: Catalog Release Line: 2.4 labels Mar 5, 2021

m2-community-project bot added the Progress: pending review label Mar 5, 2021

Update unit test of Block/Product/ListProduct

b13fcbb

modify return value of GetIteration on catCollectionMock

ihor-sviziev added Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Mar 9, 2021

ihor-sviziev approved these changes Mar 9, 2021

View reviewed changes

m2-community-project bot assigned ihor-sviziev Mar 9, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Mar 9, 2021

sivaschenko added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 11, 2021

ihor-sviziev approved these changes Mar 11, 2021

View reviewed changes

magento-engcom-team added Partner: AYKO partners-contribution Pull Request is created by Magento Partner labels Mar 11, 2021

m2-community-project bot added Progress: extended testing and removed Progress: ready for testing labels Mar 15, 2021

engcom-Foxtrot self-assigned this Mar 16, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing labels Mar 16, 2021

m2-community-project bot added Progress: extended testing and removed Progress: ready for testing labels Mar 16, 2021

engcom-Foxtrot added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Mar 16, 2021

m2-community-project bot added Progress: ready for testing Progress: extended testing and removed Progress: extended testing Progress: ready for testing labels Mar 16, 2021

engcom-Oscar added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Mar 17, 2021

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Mar 17, 2021

gabrieldagama mentioned this pull request Mar 18, 2021

ArrayIterator incompatible method current() php 7.4 #32088

Closed

5 tasks

magento-engcom-team pushed a commit that referenced this pull request Mar 18, 2021

ENGCOM-8906: Update ListProduct.php #32389

a85f3e2

magento-engcom-team merged commit 47fff39 into magento:2.4-develop Mar 18, 2021

gabrieldagama added the Type: Bug Fix label Mar 18, 2021

hostep mentioned this pull request Sep 9, 2021

Product Display Page: Error: Call to a member function getId() on bool in vendor/magento/module-catalog/Block/Product/ListProduct.php:464 #34039

Closed

4 tasks

Update ListProduct.php #32389

Update ListProduct.php #32389

Uh oh!

Conversation

mamsincl commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Mar 5, 2021

Uh oh!

mamsincl commented Mar 5, 2021

Uh oh!

mamsincl commented Mar 7, 2021

Uh oh!

mamsincl commented Mar 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mamsincl commented Mar 8, 2021

Uh oh!

mamsincl commented Mar 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mamsincl commented Mar 8, 2021

Uh oh!

magento-engcom-team commented Mar 9, 2021

Uh oh!

magento-engcom-team commented Mar 9, 2021

Uh oh!

brucemead commented Mar 11, 2021

Uh oh!

ihor-sviziev commented Mar 11, 2021

Uh oh!

brucemead commented Mar 11, 2021

Uh oh!

magento-engcom-team commented Mar 11, 2021

Uh oh!

engcom-Oscar commented Mar 15, 2021

Uh oh!

engcom-Foxtrot commented Mar 16, 2021

Uh oh!

m2-assistant bot commented Mar 18, 2021

Uh oh!

Uh oh!

mamsincl commented Mar 5, 2021 •

edited

Loading

mamsincl commented Mar 7, 2021 •

edited

Loading

mamsincl commented Mar 8, 2021 •

edited

Loading