Fix missing video when advanced js bundling used

[ihor-sviziev]

Description (*)

This PR fixes issue when a video is missing in the product gallery when advanced JS bundling is enabled and used.

This happened because the event gallery:loaded was already triggered before this code was executed.

In order to fix the issue I looked how with this event we working in different places, so I did same in this piece of code as well.

magento2/app/code/Magento/ConfigurableProduct/view/frontend/web/js/configurable.js

Lines 106 to 108 in fbfac3e

	gallery.data('gallery') ?
	this._onGalleryLoaded(gallery) :
	gallery.on('gallery:loaded', this._onGalleryLoaded.bind(this, gallery));

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes youtube video on the product page does not work magesuite/magesuite#82

Manual testing scenarios (*)

1. Configure advanced JS bundling, I used this one https://github.com/magesuite/magepack
2. Go to a product page that contains youtube or vimeo video
3. See gallery, try to find the video

Actual result: (before this PR)
❌ No video appeared, just image shown

Expected result: (after this PR)
✔ Video should appear in gallery

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fix missing video when advanced js bundling used #32501: Fix missing video when advanced js bundling used

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[gabrieldagama]

@magento create issue

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Functional Tests B2B

[eduard13]

Hi @ihor-sviziev, I'm just wondering, can't we cover this fix by a MFTF test, since it's more suitable for such cases?

Thank you.

[ihor-sviziev]

@eduard13 I don't believe it is good idea to add advanced js bundling during mftf test. it will for sure affect all the tests that running in parallel

[eduard13]

Since it's only Advanced JS bundling related, there is no way to cover that by automated tests.

Thank you for clarifying it.

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-8934 has been created to process this Pull Request

[magento-engcom-team]

Hi @ptylek, thank you for the review.
ENGCOM-8934 has been created to process this Pull Request

[dmitriyprime]

✔️ QA passed

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.