Make product SKU not null

[ihor-sviziev]

Description (*)

Fixes issue when we weren't able to create product with null SKU through magento, but still could make it in DB. That's a mistake for sure that we should fix.

I think test coverage isn't needed for this case, as Magento itself worked fine and you weren't able to create such a product from it.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Table structure issue catalog_product_entity (sku field is allowed nulls) #27411
2. Fixes Table structure issue catalog_product_entity (sku field is allowed nulls) #32525

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[hws47a]

Hi @ihor-sviziev, the change make total sense for me, however, it could be not backward compatible as

The following is a list of prohibited DB Schema changes:

Modifying field type, default value, or property

As we are changing the type from basically ?string to string

Do you know somebody who we can ask for guidance?
Alternatively, we may target it to the 2.5-develop branch.

[ihor-sviziev]

@sidolov @sivaschenko what do you think about this PR? Can we accept it?

[hws47a]

I agree that there is no need for tests as product SKU piece should be covered many-many times and it doesn't make sense to inject the wrong value into DB to trigger the error

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8947 has been created to process this Pull Request

[magento-engcom-team]

Hi @hws47a, thank you for the review.
ENGCOM-8947 has been created to process this Pull Request

[engcom-Oscar]

✔️ QA passed

Was checked case from Manual testing scenarios

1. Add a new product directly in the database.
2. Leave out NULL for the field SKU.
3. Go to the product edit page in the Admin.

❌ Before:
Product is added with NULL SKU.
When attempting to edit the product in the Admin, the error is thrown.

✔️ After:
Product with NULL SKU can't be added.

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.