Skip to content

[BUGFIX][issue#32596] Prevent reset available_sort_by when updating a… #32597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lewisvoncken
Copy link
Contributor

… category through the API

Description (*)

Solves the issue that the available_sort_by will be reset to use config value when a category is updated through the api.

Fixed Issues (if relevant)

  1. Fixes Category Update API resets available_sort_by to use config value #32596

Manual testing scenarios (*)

  1. Create a Category in the admin and specify a value for available_sort_by
  2. Execute the following api (change the id based on your created category)
<?php

$curl = curl_init();

curl_setopt_array($curl, array(
  CURLOPT_URL => 'https://example.com/rest/all/V1/categories/1321',
  CURLOPT_RETURNTRANSFER => true,
  CURLOPT_ENCODING => '',
  CURLOPT_MAXREDIRS => 10,
  CURLOPT_TIMEOUT => 0,
  CURLOPT_FOLLOWLOCATION => true,
  CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1,
  CURLOPT_CUSTOMREQUEST => 'PUT',
  CURLOPT_POSTFIELDS =>'{
    "category": {
        "name": "Example Category",
        "parent_id": "25",
        "id": "1321",
        "custom_attributes": [
            {
                "attribute_code": "url_key",
                "value": "example-category"
            }
        ]
    }
}',
  CURLOPT_HTTPHEADER => array(
    'Content-Type: application/json',
    'Authorization: Bearer xxxxxxxxxxx',
    'Cookie: PHPSESSID=2kansl4q65fupe9jn1ptrl6j2q; XDEBUG_SESSION=PHPSTORM'
  ),
));

$response = curl_exec($curl);

curl_close($curl);
echo $response;

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 25, 2021

Hi @lewisvoncken. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@gabrieldagama gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 25, 2021
@bgorski bgorski self-requested a review March 27, 2021 09:08
@bgorski bgorski self-assigned this Mar 27, 2021
@bgorski
Copy link
Contributor

bgorski commented Mar 27, 2021

@magento run all tests

Copy link
Contributor

@bgorski bgorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewisvoncken thank you for your contribution! B2B Functional Tests, Integration Tests and WebAPI Tests are currently failing. While Functional Tests may or may not be related to this particular PR, WebAPI and Integration Tests definitely are and they would require adjusting on your end before we can merge this (they're all about an empty array expectation which is no longer true when the modified code returns null).

@engcom-Foxtrot
Copy link
Contributor

Hello, @lewisvoncken. Unfortunately, I'm closing and re-creating this PR, as I was not able to push any changes to this PR branch. Please feel free to push any updates to #33001.

@m2-assistant
Copy link

m2-assistant bot commented May 12, 2021

Hi @lewisvoncken, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Partner: Experius partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category Update API resets available_sort_by to use config value
5 participants