-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[BUGFIX][issue#32596] Prevent reset available_sort_by when updating a… #32597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… category through the API
Hi @lewisvoncken. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lewisvoncken thank you for your contribution! B2B Functional Tests, Integration Tests and WebAPI Tests are currently failing. While Functional Tests may or may not be related to this particular PR, WebAPI and Integration Tests definitely are and they would require adjusting on your end before we can merge this (they're all about an empty array expectation which is no longer true when the modified code returns null).
Hello, @lewisvoncken. Unfortunately, I'm closing and re-creating this PR, as I was not able to push any changes to this PR branch. Please feel free to push any updates to #33001. |
Hi @lewisvoncken, thank you for your contribution! |
… category through the API
Description (*)
Solves the issue that the available_sort_by will be reset to use config value when a category is updated through the api.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)