-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Modified the PR template to include README.md update reqirement if necessary #32610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the PR template to include README.md update reqirement if necessary #32610
Conversation
… should be updated if necessary
Hi @bgorski. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run WebAPI Tests |
Hi @dobooth ! Could you please help us with the review? Thanks! |
Co-authored-by: Donald Booth <[email protected]>
Hi @sidolov, thank you for the review. |
@magento create issue |
@magento run all tests |
…irement if necessary #32610
Hi @bgorski, thank you for your contribution! |
Description (*)
With the introduction of the README.md template, there is a requirement of describing module installation, structure and extension points in the readme.
We need to pay special attention to README.md always being up to date, because an outdated readme can do more harm than good. This is why all code contributors need to be aware that they are supposed to modify README.md as well when they create modifications that affect any of readme predefined sections.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*) - THIS SECTION CONTAINS THE CHECKBOX THAT I ADDED
Resolved issues: