Skip to content

Updated colinmollenhour/php-redis-session-abstract to PHP 8 Compatible version #32710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Updated colinmollenhour/php-redis-session-abstract to PHP 8 Compatible version #32710

merged 1 commit into from
Apr 11, 2021

Conversation

sivaschenko
Copy link
Member

@sivaschenko sivaschenko commented Apr 10, 2021

Description (*)

Updated colinmollenhour/php-redis-session-abstract to PHP 8 Compatible version (1.4.4)

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/533

Fixed Issues (if relevant)

Fixes #32709

Manual testing scenarios (*)

No manual testing required

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2021

Hi @sivaschenko. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Apr 10, 2021
@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

@magento import pr to magento-commerce/magento-engcom

@magento-engcom-team
Copy link
Contributor

@sivaschenko, an error occurred during the Pull Request import.

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes from this PR.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8997 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 03bd130 into magento:2.4-develop Apr 11, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2021

Hi @sivaschenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko deleted the php8-redis-session branch April 13, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for testing Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update colinmollenhour/php-redis-session-abstract to PHP 8 Compatible version
3 participants