Skip to content

Elasticsearch mappings cannot be changed #32755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2021
Merged

Elasticsearch mappings cannot be changed #32755

merged 3 commits into from
Apr 29, 2021

Conversation

engcom-Kilo
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Elasticsearch mappings cannot be changed #24363

Manual testing scenarios (*)

  1. see Elasticsearch mappings cannot be changed #24363

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2021

Hi @engcom-Kilo. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Apr 15, 2021
@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

zakdma
zakdma suggested changes Apr 15, 2021
View reviewed changes
@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

zakdma
zakdma suggested changes Apr 20, 2021
View reviewed changes
app/code/Magento/Elasticsearch7/Test/Unit/Model/Client/ElasticsearchTest.php
@@ -93,12 +98,21 @@ protected function setUp(): void
->willReturn(['version' => ['number' => '7.0.0']]);

$this->objectManager = new ObjectManagerHelper($this);
$dynamicTemplatesProvider = new DynamicTemplatesProvider(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should get it using ObjectManger. It is more safe in terms of extensibility and also no need to provide constructor paramaters in this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object Manager for unit test will create dynamic template provider with mock mappers with processTemplates() method return null.
Also, Object Manager already deprecated
https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/TestFramework/Unit/Helper/ObjectManager.php#L16

@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

@dmitriyprime dmitriyprime self-assigned this Apr 21, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Apr 21, 2021

@magento run Functional Tests CE, Functional Tests B2B

@zakdma
Copy link
Contributor

zakdma commented Apr 28, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32755.

@magento-engcom-team magento-engcom-team merged commit 68de8ce into magento:2.4-develop Apr 29, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2021

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakdma zakdma zakdma approved these changes

Assignees

@zakdma zakdma

@dmitriyprime dmitriyprime

Labels
Component: Elasticsearch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elasticsearch mappings cannot be changed
5 participants
@engcom-Kilo @mrtuvn @zakdma @magento-engcom-team @dmitriyprime