Do not trigger url rewrites re-generation for all store views #32808

ihor-sviziev · 2021-04-21T16:19:31Z

Description (*)

During creating a new website, Store Group and Store view using php bin/magento setup:upgrade - we noticed that some URL rewrites for categories on different stores were re-generated in DB, that's absolutely not obvious and for sure not expected behavior. Such behavior, especially for us changed URLs for some categories w/o creating any redirect from old -> new URL (for some reason, we had incorrect url_path values in DB, that's another story).
As a result of this issue - some advertised categories started returning 404 pages, and we basically started burning our money.

Root cause analyze

Investigation showed, that app/code/Magento/CatalogUrlRewrite/Model/Category/Plugin/Store/Group.php plugin was executed due to 2 step saving of group:

at first, we just creating a new group

later we're assigning it to a website

magento2/app/code/Magento/Store/Model/Config/Importer/Processor/Create.php

Lines 165 to 195 in 6729b6e

    
           private function createGroups(array $items, array $data) 
        
           { 
        
               foreach ($items as $groupData) { 
        
                   $websiteId = $groupData['website_id']; 
        
                   unset( 
        
                       $groupData['group_id'], 
        
                       $groupData['website_id'] 
        
                   ); 
        
                   $website = $this->detectWebsiteById( 
        
                       $data, 
        
                       $websiteId 
        
                   ); 
        
                   $group = $this->groupFactory->create(); 
        
                   if (!isset($groupData['root_category_id'])) { 
        
                       $groupData['root_category_id'] = 0; 
        
                   } 
        
                   $group->setData($groupData); 
        
                   $group->getResource()->save($group); 
        
                   $group->getResource()->addCommitCallback(function () use ($data, $group, $website) { 
        
                       $store = $this->detectStoreById($data, (int)$group->getDefaultStoreId()); 
        
                       $group->setDefaultStoreId($store->getStoreId()); 
        
                       $group->setWebsite($website); 
        
                       $group->getResource()->save($group); 
        
                   }); 
        
               } 
        
           }

As a store group still don't have any store IDs assigned (the store will be created on the next step) - $group->getStoreIds() returns an empty array, we're setting this value to the category and trying to generate URL rewrites

magento2/app/code/Magento/CatalogUrlRewrite/Model/Category/Plugin/Store/Group.php

Lines 155 to 157 in a2b9380

    
           $category->setStoreId(Store::DEFAULT_STORE_ID); 
        
           $category->setStoreIds($storeIds); 
        
           $urls[] = $this->categoryUrlRewriteGenerator->generate($category);

Then it goes to this method, which tries to fetch a list of store Ids:

magento2/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGenerator.php

Lines 116 to 143 in c051134

    
               /** 
        
                * Generate list of urls for global scope 
        
                * 
        
                * @param \Magento\Catalog\Model\Category|null $category 
        
                * @param bool $overrideStoreUrls 
        
                * @param int|null $rootCategoryId 
        
                * @return \Magento\UrlRewrite\Service\V1\Data\UrlRewrite[] 
        
                */ 
        
               protected function generateForGlobalScope( 
        
                   Category $category = null, 
        
                   $overrideStoreUrls = false, 
        
                   $rootCategoryId = null 
        
               ) { 
        
                   $mergeDataProvider = clone $this->mergeDataProviderPrototype; 
        
                   $categoryId = $category->getId(); 
        
                   foreach ($category->getStoreIds() as $storeId) { 
        
                       if (!$this->isGlobalScope($storeId) 
        
                           && $this->isOverrideUrlsForStore($storeId, $categoryId, $overrideStoreUrls) 
        
                       ) { 
        
                           $category = clone $category; // prevent undesired side effects on original object 
        
                           $category->setStoreId($storeId); 
        
                           $this->updateCategoryUrlForStore($storeId, $category); 
        
                           $mergeDataProvider->merge($this->generateForSpecificStoreView($storeId, $category, $rootCategoryId)); 
        
                       } 
        
                   } 
        
                   $result = $mergeDataProvider->getData(); 
        
                   return $result; 
        
               }

Here we don't have any saved store_ids, so it fetches the list of stores where this category used as a root.

magento2/app/code/Magento/Catalog/Model/Category.php

Lines 534 to 570 in 68c7282

    
           public function getStoreIds() 
        
           { 
        
               if ($this->getInitialSetupFlag()) { 
        
                   return []; 
        
               } 
        
               $storeIds = $this->getData('store_ids'); 
        
               if ($storeIds) { 
        
                   return $storeIds; 
        
               } 
        
               if (!$this->getId()) { 
        
                   return []; 
        
               } 
        
               $nodes = []; 
        
               foreach ($this->getPathIds() as $id) { 
        
                   $nodes[] = $id; 
        
               } 
        
               $storeIds = []; 
        
               $storeCollection = $this->_storeCollectionFactory->create()->loadByCategoryIds($nodes); 
        
               foreach ($storeCollection as $store) { 
        
                   $storeIds[$store->getId()] = $store->getId(); 
        
               } 
        
               $entityStoreId = $this->getStoreId(); 
        
               if (!in_array($entityStoreId, $storeIds)) { 
        
                   array_unshift($storeIds, $entityStoreId); 
        
               } 
        
               if (!in_array(0, $storeIds)) { 
        
                   array_unshift($storeIds, 0); 
        
               } 
        
               $this->setData('store_ids', $storeIds); 
        
               return $storeIds; 
        
           }

As a result - we're re-generating category URL rewrites for all store views with the same root category ID.

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

Install magento, so you'll have 1 website, 1 store group, 1 store view
Create some categories structure
Run php bin/magento app:config:dump scopes to dump all the stores data into the config.php
Create a DB dump
Go to Admin, and create a new website, store group and a store view (re-use the same root category for that)
Run php bin/magento app:config:dump scopes to dump all the stores data into the config.php, save the file
Apply the DB dump from the step 4 in order to emulate the case, when we didn't have 2nd website, store group, etc
Run php bin/magento setup:upgrade or php bin/magento app:config:import to create a new website, store group, store view
Compare data in the url_rewrites table with a backup file for the store 1.

Expected result:
✔ URL rewrites for store 1 shouldn't be touched when we creating a new website / store group / store view

Actual result:
❌ URL rewrites for store 1 are re-generated when we creating a new website / store group / store view

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Do not trigger url rewrites re-generation for all store views #32954: Do not trigger url rewrites re-generation for all store views

m2-assistant · 2021-04-21T16:19:33Z

Hi @ihor-sviziev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev · 2021-04-21T16:19:37Z

@magento run all tests

ihor-sviziev · 2021-04-22T07:10:14Z

@magento run Functional Tests EE, WebAPI Tests

gabrieldagama · 2021-04-22T16:27:12Z

Hi @ihor-sviziev, thanks for contributing! Can you provide more details on the impact of this fix? Thanks!

Fix unit tests

ihor-sviziev · 2021-04-23T22:45:22Z

@magento run all tests

ihor-sviziev · 2021-04-23T23:23:34Z

Hi @gabrieldagama,
I updated the PR description

ihor-sviziev · 2021-04-24T13:14:55Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-04-24T13:14:57Z

No builds to run for your request.

ihor-sviziev · 2021-04-27T21:04:36Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-04-27T21:04:38Z

No builds to run for your request.

gabrieldagama · 2021-04-29T16:34:24Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-04-29T16:34:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-05-05T19:19:33Z

@magento create issue

Den4ik · 2021-05-05T19:27:50Z

@ihor-sviziev Thanks for collaboration and detailed description.
Do we really need save group 2 times at https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Store/Model/Config/Importer/Processor/Create.php#L187-L193 ?

ihor-sviziev · 2021-05-06T03:15:44Z

@Den4ik, in theory, we might change it, but I don't know why it was done in this way and wonder if it would cause some regression. Also, potentially, there might be similar code in some other piece or custom extension with the same behavior. My current changes fix all cases at once, so should cover all cases

Den4ik · 2021-05-06T09:49:32Z

@ihor-sviziev May be we could little bit research and if it's possible reduce count of save calls that will have a positive effect on performance?

ihor-sviziev · 2021-05-06T10:21:55Z

@Den4ik, in general, it's a good idea to do such research and get rid of such pieces. But in the case of fixing this issue - that's not relevant - I won't break any functionality.

Den4ik

✔️ Approve. All looks good for me.
As we discussed in Slack research should be done as separate work.

magento-engcom-team · 2021-05-06T10:37:49Z

Hi @Den4ik, thank you for the review.
ENGCOM-9074 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2021-09-24T10:27:34Z

Hi @ihor-sviziev , @Den4ik
Thanks for the collaboration & contribution!

❌ QA not Passed

URL Re-Write regenerates for all the store views

Execution steps followed as below

Installed a Magento freshly having PR changes, so by default l have 1 website, 1 store group, 1 store view.
Created a 3 categories inside default category and one product for better analysis. Noted the below URL Re Writes table and the data of the table is below:

ID	Store View	Request Path	Target Path	Redirect Type
1	Main Website Main Website Store Default Store View	no-route	cms/page/view/page_id/1	No
2	Main Website Main Website Store Default Store View	home	cms/page/view/page_id/2	No
3	Main Website Main Website Store Default Store View	enable-cookies	cms/page/view/page_id/3	No
4	Main Website Main Website Store Default Store View	privacy-policy-cookie-restriction-mode	cms/page/view/page_id/4	No
5	Main Website Main Website Store Default Store View	mks1.html	catalog/category/view/id/3	No
6	Main Website Main Website Store Default Store View	mks1/mks2.html	catalog/category/view/id/4	No
7	Main Website Main Website Store Default Store View	mks1/mks3.html	catalog/category/view/id/5	No
8	Main Website Main Website Store Default Store View	mksprod1.html	catalog/product/view/id/1	No
9	Main Website Main Website Store Default Store View	mks1/mks3/mksprod1.html	catalog/product/view/id/1/category/5	No
10	Main Website Main Website Store Default Store View	mks1/mksprod1.html	catalog/product/view/id/1/category/3	No

Ran the command php bin/magento app:config:dump scopes
Created a DB dump
Created a new store with new website and store view, setting the same default category. Checked the new store domain is able to open in the front end as shown in the below screenshot.

Where the default main store had the domain with the url local.prurlrewriteafter.com, and now the additional store is with local.prurlrewriteafter.fr. Both stores front end are working fine.
Noted the updated URL Re Write table again and the relevant table data is below

ID	Store View	Request Path	Target Path	Redirect Type
1	Main Website Main Website Store Default Store View	no-route	cms/page/view/page_id/1	No
2	Main Website Main Website Store Default Store View	home	cms/page/view/page_id/2	No
3	Main Website Main Website Store Default Store View	enable-cookies	cms/page/view/page_id/3	No
4	Main Website Main Website Store Default Store View	privacy-policy-cookie-restriction-mode	cms/page/view/page_id/4	No
5	Main Website Main Website Store Default Store View	mks1.html	catalog/category/view/id/3	No
6	Main Website Main Website Store Default Store View	mks1/mks2.html	catalog/category/view/id/4	No
7	Main Website Main Website Store Default Store View	mks1/mks3.html	catalog/category/view/id/5	No
8	Main Website Main Website Store Default Store View	mksprod1.html	catalog/product/view/id/1	No
9	Main Website Main Website Store Default Store View	mks1/mks3/mksprod1.html	catalog/product/view/id/1/category/5	No
10	Main Website Main Website Store Default Store View	mks1/mksprod1.html	catalog/product/view/id/1/category/3	No
11	FrenchWebsite FrenchStore FrenchStoreView	mks1.html	catalog/category/view/id/3	No
12	FrenchWebsite FrenchStore FrenchStoreView	mks1/mks2.html	catalog/category/view/id/4	No
13	FrenchWebsite FrenchStore FrenchStoreView	mks1/mks3.html	catalog/category/view/id/5	No
14	FrenchWebsite FrenchStore FrenchStoreView	no-route	cms/page/view/page_id/1	No
15	FrenchWebsite FrenchStore FrenchStoreView	home	cms/page/view/page_id/2	No
16	FrenchWebsite FrenchStore FrenchStoreView	enable-cookies	cms/page/view/page_id/3	No
17	FrenchWebsite FrenchStore FrenchStoreView	privacy-policy-cookie-restriction-mode	cms/page/view/page_id/4	No

Ran php bin/magento app:config:dump scopes
Applied the DB dump back to Magento instance from the step 4.
Ran php bin/magento setup:upgrade and followed by static deploy and re indexed as well.
Noted the updated URL Re Write table again and the relevant table data is below

ID	Store View	Request Path	Target Path	Redirect Type
1	Main Website Main Website Store Default Store View	no-route	cms/page/view/page_id/1	No
2	Main Website Main Website Store Default Store View	home	cms/page/view/page_id/2	No
3	Main Website Main Website Store Default Store View	enable-cookies	cms/page/view/page_id/3	No
4	Main Website Main Website Store Default Store View	privacy-policy-cookie-restriction-mode	cms/page/view/page_id/4	No
8	Main Website Main Website Store Default Store View	mksprod1.html	catalog/product/view/id/1	No
9	Main Website Main Website Store Default Store View	mks1/mks3/mksprod1.html	catalog/product/view/id/1/category/5	No
10	Main Website Main Website Store Default Store View	mks1/mksprod1.html	catalog/product/view/id/1/category/3	No
15	Main Website Main Website Store Default Store View	mks1.html	catalog/category/view/id/3	No
16	Main Website Main Website Store Default Store View	mks1/mks2.html	catalog/category/view/id/4	No
17	Main Website Main Website Store Default Store View	mks1/mks3.html	catalog/category/view/id/5	No
21	FrenchWebsite FrenchStore FrenchStoreView	mks1.html	catalog/category/view/id/3	No
22	FrenchWebsite FrenchStore FrenchStoreView	mks1/mks2.html	catalog/category/view/id/4	No
23	FrenchWebsite FrenchStore FrenchStoreView	mks1/mks3.html	catalog/category/view/id/5	No
24	FrenchWebsite FrenchStore FrenchStoreView	no-route	cms/page/view/page_id/1	No
25	FrenchWebsite FrenchStore FrenchStoreView	home	cms/page/view/page_id/2	No
26	FrenchWebsite FrenchStore FrenchStoreView	enable-cookies	cms/page/view/page_id/3	No
27	FrenchWebsite FrenchStore FrenchStoreView	privacy-policy-cookie-restriction-mode	cms/page/view/page_id/4	No

✔️ Expected result After Fix

Along with the default store's front end, the newly created front end should also work fine!
The URL Rewrite data should not be re generated

❌ Actual result After Fix

If we hit the store's front end domain, redirecting to main default store domain.
URL Rewrite data updated with newly generated record IDs.

engcom-Alfa

Based on the above comment, moving it back to to Request Changes

engcom-Charlie · 2021-10-11T14:55:46Z

Hi @ihor-sviziev,

Thank you for your contribution!

I am trying to understand and reproduce this issue on my local. Followed below steps but I am getting the same results on 2.4 develop and PR branch.

Setup fresh magento instance
Added 2 new sub categories under Default Category. Created 2 products under one sub category and 1 in other. Eg.(Electronics and Cloths are sub categories and lamp, geyser are products under Electronics and t-shirt product is under cloths)
Checked url_rewrite table: total 12 records were present.
Execute php bin/magento app:config:dump scopes command
Took Db dump at this stage
Added one website, store and view against default category
Checked the url_rewrite table again. Now total 18 records were present
Executed php bin/magento app:config:dump scopes again
Applied the DB dump back to Magento instance from the step 5.
Executed php bin/magento setup:upgrade, At this, it asked about “do you want to continue with creating the website” of step 7 , I have opted for Yes option
Tried to browse the site again, its accessible and checked url_rewrite table again. Its having 18 records
Executed php bin/magento app:config:import cmd : Got nothing to import message here

On both the branches ie. on 2.4 develop and on this PR branch, url_rewrite_ids of few records are getting changed after step 9 on, so can you please confirm once and give us some more information on this.

Thank you in advance!

ihor-sviziev · 2021-10-11T16:48:34Z

Please ping me in slack for further details

…

On Mon, 11 Oct 2021 at 17:55 Indrani ***@***.***> wrote: Hi @ihor-sviziev <https://github.com/ihor-sviziev>, Thank you for your contribution! I am trying to understand and reproduce this issue on my local. Followed below steps but I am getting the same results on 2.4 develop and PR branch. 1. Setup fresh magento instance 2. Added 2 new sub categories under Default Category. Created 2 products under one sub category and 1 in other. Eg.(Electronics and Cloths are sub categories and lamp, geyser are products under Electronics and t-shirt product is under cloths) 3. Checked url_rewrite table: total 12 records were present. 4. Execute php bin/magento app:config:dump scopes command 5. Took Db dump at this stage 6. Added one website, store and view against default category 7. Checked the url_rewrite table again. Now total 18 records were present 8. Executed php bin/magento app:config:dump scopes again 9. Applied the DB dump back to Magento instance from the step 5. 10. Executed php bin/magento setup:upgrade, At this, it asked about “do you want to continue with creating the website” of step 7 , I have opted for Yes option 11. Tried to browse the site again, its accessible and checked url_rewrite table again. Its having 18 records 12. Executed php bin/magento app:config:import cmd : Got nothing to import message here On both the branches ie. on 2.4 develop and on this PR branch, url_rewrite_ids of few records are getting changed after step 9 on, so can you please confirm once and give us some more information on this. Thank you in advance! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32808 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOJOUMHRSG6W4O6ADQPDPLUGL3H5ANCNFSM43KV2QRQ> .

engcom-Charlie · 2021-10-12T12:56:46Z

Hi @ihor-sviziev, Thanks for the information over slack.

@engcom-Alfa, I have tried to reproduce the issue on 2.4 develop with below steps. Some URL rewrites for categories on stores were re-generated in DB and hence issue is reproducible.

1.	Setup fresh magento instance
2.	Added 2 new sub categories under Default Category. Created 2 products under one sub category and 1 in other. Eg.(Electronics and Cloths are sub categories and lamp, geyser are products under Electronics and t-shirt product is under cloths)
3.	Added 2 websites, 2 stores and 2 store views.
4.	Checked url_rewrite table: total 24 records were present.

5.	Execute php bin/magento app:config:dump scopes command
6.	Took Db dump at this stage
7.	Added one website(Spanish), store and view against default category
8.	Checked the url_rewrite table again. Now total 30 records were present

9.	Executed php bin/magento app:config:dump scopes again
10.	Applied the DB dump back to Magento instance from the step 6. 
11.	Executed php bin/magento setup:upgrade, At this, it asked about “do you want to continue with creating the website Spanish” of step 7 , I have opted for Yes option

12.	Checked url_rewrite table again. Its having 30 records. Here, check that the url_rewrite_ids of url rewrites were changed. You can see new ids for old records. This is the issue.

After doing php bin/magento setup:upgrade, the URL rewrites for categories should not be re-generated in this scenario. As the issue exists on mainline so moving this PR further.

Thank you!

engcom-Alfa · 2021-10-18T15:28:11Z

Hi @ihor-sviziev, Thanks for the information over slack.

@engcom-Alfa, I have tried to reproduce the issue on 2.4 develop with below steps. Some URL rewrites for categories on stores were re-generated in DB and hence issue is reproducible.

1.	Setup fresh magento instance
2.	Added 2 new sub categories under Default Category. Created 2 products under one sub category and 1 in other. Eg.(Electronics and Cloths are sub categories and lamp, geyser are products under Electronics and t-shirt product is under cloths)
3.	Added 2 websites, 2 stores and 2 store views.
4.	Checked url_rewrite table: total 24 records were present.

5.	Execute php bin/magento app:config:dump scopes command
6.	Took Db dump at this stage
7.	Added one website(Spanish), store and view against default category
8.	Checked the url_rewrite table again. Now total 30 records were present

9.	Executed php bin/magento app:config:dump scopes again
10.	Applied the DB dump back to Magento instance from the step 6. 
11.	Executed php bin/magento setup:upgrade, At this, it asked about “do you want to continue with creating the website Spanish” of step 7 , I have opted for Yes option

12.	Checked url_rewrite table again. Its having 30 records. Here, check that the url_rewrite_ids of url rewrites were changed. You can see new ids for old records. This is the issue.

After doing php bin/magento setup:upgrade, the URL rewrites for categories should not be re-generated in this scenario. As the issue exists on mainline so moving this PR further.

Thank you!

Hi @ihor-sviziev and @engcom-Charlie , Thanks for collaboration and coming back with proper steps to reproduce it! I am able to work on it now!

engcom-Alfa · 2021-10-19T10:13:22Z

✔️ QA Passed

Manual testing scenario:

Setup fresh Magento instance
Add 2 new sub categories under Default Category. Create 2 products under one created sub category and 1 product in other.
Added 2 websites, 2 stores and 2 store views. Make sure newly created both stores are working fine with their frontend website links.
Check url_rewrite table in the database.
Execute php bin/magento app:config:dump scopes command
Take a DB dump at this stage
Add one more new store website(Spanish), store and store view using default category, make sure it is also working
Check the url_rewrite table in the DB again. Now total records count will be more (comparing step 4)! Make note of all records.
Execute php bin/magento app:config:dump scopes again
Apply the DB dump back to Magento instance from the step 6.
Execute the php bin/magento setup:upgrade command, At this, it asks about “do you want to continue with creating the website Spanish” of step 7; opt for Yes.
Check url_rewrite table again. Make note of all records.
Compare url_rewrite_ids of url rewrite noted table records from step 8 and step12. (Using diff checker tools would give more clarity)

Before: ✖️ New url_rewrite_ids were getting generated to old records

After: ✔️ New url_rewrite_ids are not getting generated to old records, they are retained as it is!

It is a specific case were the DB dump is involved when we are having multi store views, and has no impact on other features, and hence no additional regression is required on this.

…views #32808

m2-assistant · 2021-10-28T02:10:44Z

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Do not trigger url rewrites re-generation for all store views

181507c

magento-engcom-team added Component: CatalogUrlRewrite Release Line: 2.4 labels Apr 21, 2021

ihor-sviziev added the Severity: S1 Affects critical data or functionality and forces users to employ a workaround. label Apr 21, 2021

m2-community-project bot added the Progress: pending review label Apr 21, 2021

Do not trigger url rewrites re-generation for all store views

43d6603

Fix unit tests

ihor-sviziev marked this pull request as ready for review April 23, 2021 23:27

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 29, 2021

m2-assistant bot mentioned this pull request May 5, 2021

[Issue] Do not trigger url rewrites re-generation for all store views #32954

Closed

5 tasks

Den4ik self-assigned this May 5, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels May 5, 2021

Den4ik added Award: bug fix Award: category of expertise labels May 5, 2021

Den4ik approved these changes May 6, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels May 6, 2021

Den4ik added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label May 6, 2021

engcom-Alfa self-assigned this Sep 16, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Sep 16, 2021

engcom-Alfa requested changes Sep 24, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: testing in progress labels Sep 24, 2021

engcom-Charlie self-assigned this Oct 11, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Oct 12, 2021

m2-community-project bot added Progress: testing in progress Progress: accept and removed Progress: ready for testing Progress: testing in progress labels Oct 19, 2021

magento-engcom-team pushed a commit that referenced this pull request Oct 28, 2021

ENGCOM-9074: Do not trigger url rewrites re-generation for all store …

306d4df

…views #32808

magento-engcom-team merged commit 2f2b173 into magento:2.4-develop Oct 28, 2021

	private function createGroups(array $items, array $data)
	{
	foreach ($items as $groupData) {
	$websiteId = $groupData['website_id'];

	unset(
	$groupData['group_id'],
	$groupData['website_id']
	);

	$website = $this->detectWebsiteById(
	$data,
	$websiteId
	);

	$group = $this->groupFactory->create();
	if (!isset($groupData['root_category_id'])) {
	$groupData['root_category_id'] = 0;
	}

	$group->setData($groupData);

	$group->getResource()->save($group);
	$group->getResource()->addCommitCallback(function () use ($data, $group, $website) {
	$store = $this->detectStoreById($data, (int)$group->getDefaultStoreId());
	$group->setDefaultStoreId($store->getStoreId());
	$group->setWebsite($website);
	$group->getResource()->save($group);
	});
	}
	}

	$category->setStoreId(Store::DEFAULT_STORE_ID);
	$category->setStoreIds($storeIds);
	$urls[] = $this->categoryUrlRewriteGenerator->generate($category);

	/**
	* Generate list of urls for global scope
	*
	* @param \Magento\Catalog\Model\Category\|null $category
	* @param bool $overrideStoreUrls
	* @param int\|null $rootCategoryId
	* @return \Magento\UrlRewrite\Service\V1\Data\UrlRewrite[]
	*/
	protected function generateForGlobalScope(
	Category $category = null,
	$overrideStoreUrls = false,
	$rootCategoryId = null
	) {
	$mergeDataProvider = clone $this->mergeDataProviderPrototype;
	$categoryId = $category->getId();
	foreach ($category->getStoreIds() as $storeId) {
	if (!$this->isGlobalScope($storeId)
	&& $this->isOverrideUrlsForStore($storeId, $categoryId, $overrideStoreUrls)
	) {
	$category = clone $category; // prevent undesired side effects on original object
	$category->setStoreId($storeId);
	$this->updateCategoryUrlForStore($storeId, $category);
	$mergeDataProvider->merge($this->generateForSpecificStoreView($storeId, $category, $rootCategoryId));
	}
	}
	$result = $mergeDataProvider->getData();
	return $result;
	}

	public function getStoreIds()
	{
	if ($this->getInitialSetupFlag()) {
	return [];
	}

	$storeIds = $this->getData('store_ids');
	if ($storeIds) {
	return $storeIds;
	}

	if (!$this->getId()) {
	return [];
	}

	$nodes = [];
	foreach ($this->getPathIds() as $id) {
	$nodes[] = $id;
	}

	$storeIds = [];
	$storeCollection = $this->_storeCollectionFactory->create()->loadByCategoryIds($nodes);
	foreach ($storeCollection as $store) {
	$storeIds[$store->getId()] = $store->getId();
	}

	$entityStoreId = $this->getStoreId();
	if (!in_array($entityStoreId, $storeIds)) {
	array_unshift($storeIds, $entityStoreId);
	}
	if (!in_array(0, $storeIds)) {
	array_unshift($storeIds, 0);
	}

	$this->setData('store_ids', $storeIds);
	return $storeIds;
	}

Do not trigger url rewrites re-generation for all store views #32808

Do not trigger url rewrites re-generation for all store views #32808

Uh oh!

Conversation

ihor-sviziev commented Apr 21, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Root cause analyze

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Apr 21, 2021

Uh oh!

ihor-sviziev commented Apr 21, 2021

Uh oh!

ihor-sviziev commented Apr 22, 2021

Uh oh!

gabrieldagama commented Apr 22, 2021

Uh oh!

ihor-sviziev commented Apr 23, 2021

Uh oh!

ihor-sviziev commented Apr 23, 2021

Uh oh!

ihor-sviziev commented Apr 24, 2021

Uh oh!

magento-automated-testing bot commented Apr 24, 2021

Uh oh!

ihor-sviziev commented Apr 27, 2021

Uh oh!

magento-automated-testing bot commented Apr 27, 2021

Uh oh!

gabrieldagama commented Apr 29, 2021

Uh oh!

magento-automated-testing bot commented Apr 29, 2021

Uh oh!

Den4ik commented May 5, 2021

Uh oh!

Den4ik commented May 5, 2021

Uh oh!

ihor-sviziev commented May 6, 2021

Uh oh!

Den4ik commented May 6, 2021

Uh oh!

ihor-sviziev commented May 6, 2021

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented May 6, 2021

Uh oh!

engcom-Alfa commented Sep 24, 2021

Uh oh!

engcom-Alfa left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Oct 11, 2021

Uh oh!

ihor-sviziev commented Oct 11, 2021 via email

Uh oh!

engcom-Charlie commented Oct 12, 2021

Uh oh!

engcom-Alfa commented Oct 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Alfa commented Oct 19, 2021

Uh oh!

m2-assistant bot commented Oct 28, 2021

Uh oh!

Uh oh!

ihor-sviziev commented Apr 21, 2021 •

edited by m2-assistant bot

Loading

engcom-Alfa commented Oct 18, 2021 •

edited

Loading