Only add referrer param to login url if referrer is a GET request

[mfickers]

Description (*)

This fixes a bug where, after an unsuccessful login attempt, the URL /customer/account/loginPost was added as referrer param to the login URL on redirect.
A second, successful login attempt would then redirect the user to this URL, displaying a 404 page because the route only handles POST requests.

This is fixed by checking if the current request is a GET request before adding the URL as referrer parameter.

Fixed Issues (if relevant)

1. Fixes Login on second attempt after one unsuccessful try redirects customer to 404 page #32885

Manual testing scenarios (*)

1. Visit /customer/account/login without a referrer parameter in the URL
2. Make an unsuccessful login attempt
3. There should be no referrer parameter added to the URL after redirect

Questions or comments

This does not break the general referrer functionality. I've made sure that e.g. the redirect after login when adding an item to the wishlist still works as expected.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @mfickers. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[mrtuvn]

@magento run all tests

[mrtuvn]

Can you cover this changes with some kind of automation tests

[mfickers]

@mrtuvn I've added an integration test to make sure there is no referer parameter on an unsuccessful login attempt.

[mfickers]

@magento run all tests

[mrtuvn]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[mrtuvn]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[mrtuvn]

Seem fail tests not related with your changes

[mrtuvn]

Changes seem ok with me

[magento-engcom-team]

Hi @mrtuvn, thank you for the review.
ENGCOM-9057 has been created to process this Pull Request

[dmitriyprime]

✔️ QA passed

❌ Before:

✔️ After:

[m2-assistant]

Hi @mfickers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.