-
Notifications
You must be signed in to change notification settings - Fork 9.4k
MFTF: Checkout With Enabled Captcha #32986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Checkout With Enabled Captcha #32986
Conversation
Hi @DmitryTsymbal. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi just curious! Is there any case test cover checkout without captcha |
@magento create issue |
@@ -33,6 +33,12 @@ | |||
<data key="label">Contact Us</data> | |||
<data key="value">contact_us</data> | |||
</entity> | |||
<entity name="StorefrontCaptchaOnCheckoutConfigData"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitryTsymbal Please add a new entity changes at the end of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shikhamis11 , thanks for noticing. I have moved new entity to the end of the file. Please check
@magento run Functional Tests B2B, WebAPI Tests, Database Compare |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @shikhamis11, thank you for the review.
|
Hi @Den4ik, thank you for the review. |
#33200 |
Hello @mrtuvn , sorry for the long reply. Does it work for you, or do we need some special cases to cover? Thanks! |
Thanks you better let do it at another seperate one |
✔️ QA Passed Preconditions:
Manual testing scenario: 1 - Login to store front Actual Result: ✔️
Tested all the manual scenarios, no impact on regression testing. |
Hi @DmitryTsymbal, thank you for your contribution! |
This PR contains MFTF test for placing an order with enabled captcha
Steps to reproduce:
1 - Create customer
2 - Create product
3 - Login as customer
4- Add Product into shopping cart
5 - Place an order with incorrect captcha values
6 - Place an order with correct captcha values
7 - Perform assertions
Resolved issues: