Skip to content

Customer address in admin order details like company name in not work website wise #33004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

Customer address in admin order details like company name in not work website wise #33004

merged 1 commit into from
May 25, 2021

Conversation

engcom-Kilo
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Customer address in admin order details like company name in not work website wise #23254

Manual testing scenarios (*)

  1. see Customer address in admin order details like company name in not work website wise #23254

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 13, 2021

Hi @engcom-Kilo. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels May 13, 2021
@engcom-Kilo
Copy link
Contributor Author

@magento run all test

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@engcom-Kilo
Copy link
Contributor Author

@magento run all test

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-9089 has been created to process this Pull Request

@dmitriyprime dmitriyprime self-assigned this May 17, 2021
@dmitriyprime
Copy link
Contributor

✔️ QA passed

Before:
before

After:
after

@zakdma
Copy link
Contributor

zakdma commented May 21, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

@zakdma
Copy link
Contributor

zakdma commented May 21, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-33004.

@magento-engcom-team magento-engcom-team merged commit 3e281f0 into magento:2.4-develop May 25, 2021
@m2-assistant
Copy link

m2-assistant bot commented May 25, 2021

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

kanevbg
kanevbg reviewed Apr 3, 2024
View reviewed changes
app/code/Magento/Sales/Model/Order/Address/Renderer.php
$storeId = $address->getOrder()->getStoreId();
$this->addressConfig->setStore($storeId);
$orderStore = $address->getOrder()->getStore();
$this->storeManager->setCurrentStore($orderStore);
Copy link

@kanevbg kanevbg Apr 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the current store but not resetting results in lost context for following algorithms. So that's more of architectural issue then it is of concrete problem.
EDIT: I'd suggest to finally {} restore the original store ID in the store manager to prevent unexpected behavior on following algorithms (which may be custom/third-party).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanevbg kanevbg kanevbg left review comments

@nuzil nuzil nuzil approved these changes

Assignees

@nuzil nuzil

@dmitriyprime dmitriyprime

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Sales Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customer address in admin order details like company name in not work website wise
6 participants
@engcom-Kilo @magento-engcom-team @dmitriyprime @zakdma @nuzil @kanevbg