#32615: [GraphQL] Add assign customer to cart mutation #33106

khrystynastolbova · 2021-05-31T14:01:24Z

Description (*)

This pull request adds 'assignCustomerToGuestCart' mutation.
The mutation assigns a logged in customer and merge customer's shopping cart items to the specified guest shopping cart.

Related Pull Requests

Fixed Issues (if relevant)

Fixes Add assign customer to cart mutation #32615

Manual testing scenarios (*)

mutation {
  assignCustomerToGuestCart(
    cart_id: "SCJUI4KfzhmTJfoCfy38xTmLccu71234"
  ){
  items {
      quantity
      product {
        sku
      }
    }
  }
}

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-05-31T14:01:27Z

Hi @khrystynastolbova. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

khrystynastolbova · 2021-05-31T14:01:56Z

@magento run all tests

magento-automated-testing · 2021-05-31T14:01:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

khrystynastolbova · 2021-07-08T13:20:05Z

@magento run all tests

magento-automated-testing · 2021-07-08T13:20:14Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

danielrussob · 2021-07-27T16:30:02Z

@magento give me test instance

magento-deployment-service · 2021-07-27T16:30:06Z

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

danielrussob · 2021-07-27T16:30:46Z

@magento run Functional Tests EE

magento-automated-testing · 2021-07-27T16:30:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-deployment-service · 2021-07-27T16:34:00Z

Hi @danielrussob, here is your Magento Instance: https://67a329ab19fabd89241ecba5d0a1ba0c.instances.magento-community.engineering
Admin access: https://67a329ab19fabd89241ecba5d0a1ba0c.instances.magento-community.engineering/admin_dce7
Login: 758b1698
Password: 6b497827c60a

danielrussob · 2021-07-27T16:37:00Z

app/code/Magento/QuoteGraphQl/Model/Resolver/AssignCustomerToGuestCart.php

+        }
+
+        $currentUserId = $context->getUserId();
+        $guestMaskedCartId = $args['cart_id'];


Hello @khrystynastolbova,
thank you for your contribution

could you add a check on cart_id?

if (empty($args['cart_id'])) {
throw new GraphQlInputException(__('Required parameter "cart_id" is missing'));
}

Hi @danielrussob, actually cart_id is a required field at the schema level, and personally don't see the reason to have an additional check for that.

aleron75 · 2021-07-27T16:36:05Z

app/code/Magento/QuoteGraphQl/Model/Resolver/AssignCustomerToGuestCart.php

+        $guestMaskedCartId = $args['cart_id'];
+        $storeId = (int)$context->getExtensionAttributes()->getStore()->getId();
+
+        $this->getCartForUser->execute($guestMaskedCartId,null, $storeId);


Hello, please add a space after $guestMaskedCartId, parameter (i.e. before null parameter) to avoid coding style complains. Thanks!

aleron75 · 2021-07-27T16:47:37Z

app/code/Magento/QuoteGraphQl/Model/Resolver/AssignCustomerToGuestCart.php

+            $this->guestCartManagementInterface->assignCustomer($guestMaskedCartId, $currentUserId, $storeId);
+        } catch (NoSuchEntityException $e) {
+            $message = $e->getMessage();
+            if (str_contains($message, 'No such entity with cartId = ')) {


I may be wrong but don't you think that checking against a specific string could be fragile?
Let me explain: in case the exception message changes or is translated, this condition could be not satisfiable anymore.

I don't get the reason for changing the exception message here, can you elaborate on this to identify together an alternative solution?

Thank you!

Hi @aleron75. You are right it could be fragile. I just wanted to avoid displaying non hashed cartId for the client

Maybe that will be enough

} catch (NoSuchEntityException $e) { $message = __('Could not find a cart with ID "%masked_cart_id"', ['masked_cart_id' => $guestMaskedCartId]); }

@khrystynastolbova approved 👍

engcom-Bravo · 2021-08-26T09:16:32Z

Thank you @khrystynastolbova @engcom-Hotel
I am working on this.

engcom-Hotel

Since it is auto moving to the "Ready for testing" bucket, moving back to "Change requested".

engcom-Bravo · 2021-09-01T08:25:22Z

@engcom-Hotel assignCustomerToGuestCart Mutation will merge customer cart into guest cart.
Customer cart become inactive and the guest cart remains active only for guest cart new masked id is being generated.
That is why you are seeing new cart_id (quote masked id) but quote Id remains same.

Below is the mutation

mutation {
  assignCustomerToGuestCart(
    cart_id:"cxOBoVAfw9JYUisVNnwKT51ObBI98gwI",
  ) {
    items {
      id
      product {
        name
        sku
      }
      quantity
    }
  }
}

Before Merging customer cart to guest cart in can be found active in database as below

After merge guest cart can't be found in database with same masked ID

Guest Cart can be found and active with new maskId

engcom-Hotel · 2021-09-01T12:22:44Z

✔️

Hello @engcom-Bravo,

Thanks for the clarification!

As per the screenshots attached in the coment, it is clear that the actual cart_id is not changing only the masked_id is updating (might be due to security reasons).

Please refer to my comment for the scenarios on which I have tested this PR.

Tested all the manual scenarios, no impact on regression testing.

Thanks

…33106

m2-assistant · 2021-10-24T04:27:44Z

Hi @khrystynastolbova, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

32615: [GraphQL] Add assign customer to cart mutation

36971ef

magento-engcom-team added the Component: QuoteGraphQl label May 31, 2021

magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 31, 2021

m2-community-project bot added the Progress: pending review label May 31, 2021

sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 24, 2021

32615: add method's descriptions

9ced6e0

danielrussob requested review from danielrussob and aleron75 July 27, 2021 16:29

danielrussob assigned danielrussob and aleron75 Jul 27, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jul 27, 2021

danielrussob requested changes Jul 27, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jul 27, 2021

aleron75 reviewed Jul 27, 2021

View reviewed changes

m2-community-project bot added Progress: review and removed Progress: needs update labels Jul 27, 2021

m2-community-project bot added the Progress: needs update label Aug 4, 2021

engcom-Bravo self-assigned this Aug 26, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Aug 26, 2021

engcom-Bravo removed their assignment Aug 26, 2021

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Aug 26, 2021

engcom-Bravo self-assigned this Aug 26, 2021

m2-community-project bot added Progress: ready for testing Progress: testing in progress and removed Progress: needs update Progress: ready for testing labels Aug 26, 2021

engcom-Hotel requested changes Aug 27, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: testing in progress labels Aug 27, 2021

m2-community-project bot added Progress: ready for testing Progress: testing in progress and removed Progress: needs update Progress: ready for testing labels Sep 1, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Sep 2, 2021

sidolov mentioned this pull request Oct 24, 2021

Add assign customer to cart mutation #32615

Closed

magento-engcom-team pushed a commit that referenced this pull request Oct 24, 2021

ENGCOM-9171: #32615: [GraphQL] Add assign customer to cart mutation #…

a5847b3

…33106

magento-engcom-team merged commit b370b01 into magento:2.4-develop Oct 24, 2021

keharper mentioned this pull request Nov 11, 2021

GraphQL: Add docs for assignCustomerToGuestCart mutation magento/devdocs#9248

Closed

8 tasks

karyna-t mentioned this pull request Nov 16, 2021

add documentation for assignCustomerToGuestCart mutation magento/devdocs#9252

Merged

#32615: [GraphQL] Add assign customer to cart mutation #33106

#32615: [GraphQL] Add assign customer to cart mutation #33106

Uh oh!

Conversation

khrystynastolbova commented May 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented May 31, 2021

Uh oh!

khrystynastolbova commented May 31, 2021

Uh oh!

magento-automated-testing bot commented May 31, 2021

Uh oh!

khrystynastolbova commented Jul 8, 2021

Uh oh!

magento-automated-testing bot commented Jul 8, 2021

Uh oh!

danielrussob commented Jul 27, 2021

Uh oh!

magento-deployment-service bot commented Jul 27, 2021

Uh oh!

danielrussob commented Jul 27, 2021

Uh oh!

magento-automated-testing bot commented Jul 27, 2021

Uh oh!

magento-deployment-service bot commented Jul 27, 2021

Uh oh!

danielrussob Jul 27, 2021

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 30, 2021

Choose a reason for hiding this comment

Uh oh!

aleron75 Jul 27, 2021

Choose a reason for hiding this comment

Uh oh!

aleron75 Jul 27, 2021

Choose a reason for hiding this comment

Uh oh!

khrystynastolbova Jul 30, 2021

Choose a reason for hiding this comment

Uh oh!

khrystynastolbova Jul 30, 2021

Choose a reason for hiding this comment

Uh oh!

aleron75 Jul 30, 2021

Choose a reason for hiding this comment

Uh oh!

engcom-Bravo commented Aug 26, 2021

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Bravo commented Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Hotel commented Sep 1, 2021

Uh oh!

m2-assistant bot commented Oct 24, 2021

Uh oh!

Uh oh!

khrystynastolbova commented May 31, 2021 •

edited

Loading

engcom-Bravo commented Sep 1, 2021 •

edited

Loading