Update zip_codes.xml patterns for Guernsey & Jersey #33128

DrJohnM · 2021-06-02T16:45:29Z

Update zip_codes.xml patterns for Guernsey to support GY10 postcodes for the Island of Sark e.g. https://en.wikipedia.org/wiki/GY_postcode_area

Description (*)

Guernsey postcodes for the island of Sark start with GY10 e.g. "GY10 1PB" which the previous "pattern" did not cover.

Source:

https://en.wikipedia.org/wiki/GY_postcode_area
https://en.wikipedia.org/wiki/JE_postcode_area
https://www.loqate.com/en-gb/demos/capture/ (search for "Sark Post Office")

Manual testing scenarios (*)

Add product to basket
Go to checkout
Select "Guernsey" as country for shipping address
Use postcode of "GY10 1PB" (Sark Post Office)

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Update zip_codes.xml patterns for Guernsey #33144: Update zip_codes.xml patterns for Guernsey

Update zip_codes.xml patterns for Guernsey to support GY10 postcodes for the Island of Sark e.g. https://en.wikipedia.org/wiki/GY_postcode_area

m2-assistant · 2021-06-02T16:45:31Z

Hi @DrJohnM. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

DrJohnM · 2021-06-02T16:57:51Z

@magento run all tests

magento-automated-testing · 2021-06-02T16:57:56Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

DrJohnM · 2021-06-03T10:26:51Z

@magento run Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-06-03T10:26:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

gabrieldagama · 2021-06-03T16:41:07Z

@magento create issue

Den4ik · 2021-06-03T21:05:07Z

@magento run Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-06-03T21:05:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-06-03T21:45:44Z

Guernsey postcodes start from GY. Why do we allow all chars in patterns?

Updates to restrict postcodes to GY, inline with suggestion from contributor "Den4ik".

DrJohnM · 2021-06-04T16:17:23Z

Guernsey postcodes start from GY. Why do we allow all chars in patterns?

Updates made https://github.com/magento/magento2/pull/33128/files

DrJohnM · 2021-06-04T16:17:46Z

@magento run all tests

magento-automated-testing · 2021-06-04T16:17:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

DrJohnM · 2021-06-04T21:27:04Z

@magento run Integration Tests

magento-automated-testing · 2021-06-04T21:27:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

orlangur · 2021-06-07T00:21:12Z

app/code/Magento/Directory/etc/zip_codes.xml

@@ -258,7 +258,8 @@
    </zip>
    <zip countryCode="GG">
        <codes>
-            <code id="pattern_1" active="true" example="AB1 2CD">^[a-zA-Z]{2}[0-9]{1}\s[0-9]{1}[a-zA-Z]{2}$</code>
+            <code id="pattern_1" active="true" example="GY1 2AB">^GY[0-9]{1}\s[0-9]{1}[a-zA-Z]{2}$</code>
+            <code id="pattern_2" active="true" example="GY10 1PB">^GY[0-9]{2}\s?[0-9]{1}[a-zA-Z]{2}$</code>


Just expand a single pattern instead of adding a new one (GY[0-9]{1} -> GY[0-9]{2}).

Would be really nice to cover this revealed case with a unit test.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

Just expand a single pattern instead of adding a new one (GY[0-9]{1} -> GY[0-9]{2}).

@orlangur postcode could have digit from 0-9 or 10.

I suggest another pattern ^GY([0-9]|10)\s[0-9][a-zA-Z]{2}

Applied updates via d2e11d0

I also fixed another bug with Jersey postcodes if customers enter postcodes without spaces.

Den4ik · 2021-06-23T19:03:08Z

@engcom-Alfa Thanks for the comment. I believe that writing postcodes by small chars is incorrect, but may be it make sense.
2-3. Good point

@DrJohnM Could you update PR?

engcom-Bravo · 2021-09-07T04:09:00Z

@DrJohnM @Den4ik And @engcom-Alfa Thanks for your contribution!
@DrJohnM I am working on the requested changes.

engcom-Bravo · 2021-09-07T07:13:27Z

@magento run all tests

magento-automated-testing · 2021-09-07T07:13:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-09-07T08:32:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-09-07T10:09:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Bravo · 2021-09-07T10:13:51Z

Hi @Den4ik ,

I have updated PR with requested changes.

Requesting you for review.

Thank You!

magento-automated-testing · 2021-09-07T10:53:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-10-13T20:40:28Z

Hi @sidolov, thank you for the review.
ENGCOM-9122 has been created to process this Pull Request

m2-assistant · 2021-10-24T04:27:38Z

Hi @DrJohnM, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Update zip_codes.xml patterns for Guernsey

4265688

Update zip_codes.xml patterns for Guernsey to support GY10 postcodes for the Island of Sark e.g. https://en.wikipedia.org/wiki/GY_postcode_area

magento-engcom-team added Component: Directory Release Line: 2.4 labels Jun 2, 2021

m2-community-project bot added the Progress: pending review label Jun 2, 2021

sidolov pushed a commit to sidolov/quality-patches that referenced this pull request Jun 3, 2021

Automatically generated patch for magento/magento2#33128

96e887d

sidolov mentioned this pull request Jun 3, 2021

Automatically generated patch for magento/magento2#33128 sidolov/quality-patches#37

Closed

m2-assistant bot mentioned this pull request Jun 3, 2021

[Issue] Update zip_codes.xml patterns for Guernsey #33144

Closed

5 tasks

gabrieldagama added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 3, 2021

Update zip_codes.xml

54630ee

Updates to restrict postcodes to GY, inline with suggestion from contributor "Den4ik".

orlangur requested changes Jun 7, 2021

View reviewed changes

m2-community-project bot assigned orlangur Jun 7, 2021

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Jun 7, 2021

m2-community-project bot assigned Den4ik Jun 7, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Jun 7, 2021

Den4ik added Progress: needs update and removed Progress: ready for testing labels Jun 23, 2021

Den4ik self-requested a review June 23, 2021 19:03

engcom-Bravo self-assigned this Sep 7, 2021

m2-community-project bot added Progress: ready for testing Progress: needs update and removed Progress: needs update Progress: ready for testing labels Sep 7, 2021

engcom-Bravo added 2 commits September 7, 2021 12:32

Merge remote-tracking branch 'magento2/2.4-develop' into patch-1

3937246

33144-Updated pattern for Guernsey and Jersey

830595e

m2-community-project bot added Progress: pending review and removed Progress: needs update labels Sep 7, 2021

sidolov approved these changes Oct 13, 2021

View reviewed changes

m2-community-project bot assigned sidolov Oct 13, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Oct 13, 2021

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Oct 13, 2021

magento-engcom-team pushed a commit that referenced this pull request Oct 24, 2021

ENGCOM-9122: Update zip_codes.xml patterns for Guernsey & Jersey #33128

5efef94

magento-engcom-team merged commit a6350a6 into magento:2.4-develop Oct 24, 2021

Update zip_codes.xml patterns for Guernsey & Jersey #33128

Update zip_codes.xml patterns for Guernsey & Jersey #33128

Uh oh!

Conversation

DrJohnM commented Jun 2, 2021 • edited by sdzhepa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Manual testing scenarios (*)

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Jun 2, 2021

Uh oh!

DrJohnM commented Jun 2, 2021

Uh oh!

magento-automated-testing bot commented Jun 2, 2021

Uh oh!

DrJohnM commented Jun 3, 2021

Uh oh!

magento-automated-testing bot commented Jun 3, 2021

Uh oh!

gabrieldagama commented Jun 3, 2021

Uh oh!

Den4ik commented Jun 3, 2021

Uh oh!

magento-automated-testing bot commented Jun 3, 2021

Uh oh!

Den4ik commented Jun 3, 2021

Uh oh!

DrJohnM commented Jun 4, 2021

Uh oh!

DrJohnM commented Jun 4, 2021

Uh oh!

magento-automated-testing bot commented Jun 4, 2021

Uh oh!

DrJohnM commented Jun 4, 2021

Uh oh!

magento-automated-testing bot commented Jun 4, 2021

Uh oh!

orlangur Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

Den4ik Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

DrJohnM Jun 7, 2021

Choose a reason for hiding this comment

Uh oh!

Den4ik commented Jun 23, 2021

Uh oh!

engcom-Bravo commented Sep 7, 2021

Uh oh!

engcom-Bravo commented Sep 7, 2021

Uh oh!

magento-automated-testing bot commented Sep 7, 2021

Uh oh!

magento-automated-testing bot commented Sep 7, 2021

Uh oh!

magento-automated-testing bot commented Sep 7, 2021

Uh oh!

engcom-Bravo commented Sep 7, 2021

Uh oh!

magento-automated-testing bot commented Sep 7, 2021

Uh oh!

magento-engcom-team commented Oct 13, 2021

Uh oh!

m2-assistant bot commented Oct 24, 2021

Uh oh!

Uh oh!

DrJohnM commented Jun 2, 2021 •

edited by sdzhepa

Loading