MFTF: Allow shipment update emails to be disabled

[kate-kyzyma]

Description (*)

I have covered the fix #33166 for #33165 issue by MFTF tests

Related Pull Requests

#33166

Fixed Issues (if relevant)

1. Fixes Cannot disable shipment update emails #33165

Manual testing scenarios (*)

See #33165

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @kate-kyzyma. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[kate-kyzyma]

@eduard13 please, review my PR.

Thanks.

[eduard13]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[eduard13]

@magento run Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[eduard13]

@magento run Integration Functional Tests CE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[eduard13]

Thank you @kate-kyzyma for the test coverage.
The failed tests are related to the related PR.

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-9124 has been created to process this Pull Request

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-9124 has been created to process this Pull Request

[eduard13]

Hi @engcom-Charlie, basically the reported by you errors were actually the expected ones. However, I've also added the fix in this PR, so we'll have the green tests.

Could you please double check this one?

Thank you.

[engcom-Charlie]

Moving this in Ready for testing as #33166 is still in testing in progress.

[engcom-Charlie]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Charlie]

✔️ QA Passed

The newly created auto tests are valid.

The test case is working fine and green in build. Please find the Allure report for the same.

@kate-kyzyma and @eduard13 as #33166 is already in Merge in Progress so please remove the issue fix which is added by you and only keep MFTF test case fix in this ticket

[eduard13]

Hi @engcom-Charlie, thank you for checking it, however the fix won't cause any conflicts with the related PR, so there is no reason to remove it.

What do you think?

Thanks.

[engcom-Charlie]

Hi @eduard13,

Thanks for replying.

#33166 ticket is having the issue fix which is in Merge in progress.

This ticket #33232 is specifically for MFTF test coverage which is working fine. I think, when it will get merge, since its also having the above fix in it, it will cause unnecessary conflicts at the time of merging.

So I have requested that you can remove the fix made in 33166 and only go with the MFTF test case related PR change in this ticket.

Thank you!

[eduard13]

Hi @engcom-Charlie, since this PR contains exactly the same changes on the same lines, code (there is no difference), then normally there should be no conflicts with these 2 PRs.

[engcom-Charlie]

Hi @eduard13, as you confirmed in #33232 (comment) moving this ticket to Merge in Progress.

Thank you!

[slavvka]

@magento give me test instance

[magento-deployment-service]

Hi @slavvka. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @slavvka, here is your Magento Instance: https://324f47a5fb1916b6b11fb90de0ad884b.instances.magento-community.engineering
Admin access: https://324f47a5fb1916b6b11fb90de0ad884b.instances.magento-community.engineering/admin_cc54
Login: 92c9f635
Password: 0c4332f56433

[m2-assistant]

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.