Fix multiselect with a lot of options not saved to DB

[jakwinkler]

Description (*)

Code fix to #33486

Fixed Issues (if relevant)

1. Fixes Multiselect attribute, not all options are saved in database.  #33486

Manual testing scenarios (*)

1. Create a new multiselect attribute
2. Add at least 150 options to an attribute
3. Add an attribute to the main attribute set
4. create a product and assign ALL options to the product
5. After save operation, all values should be assigned to the product

Questions or comments

1. Who tested this feature and why it was tested on very small data set?

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @qsolutions-pl. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[jakwinkler]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

That will work for newly created installation, but will not for older. Could you create some patch that will migrate all data from varchar to text table?

Also, could you create some integration test for covering this case?

[ihor-sviziev]

@sivaschenko @sidolov @gabrieldagama, I think the prio should be P2 for this issue.

[jakwinkler]

@ihor-sviziev added integration tests :-)

[jakwinkler]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[m2-assistant]

Hi @qsolutions-pl, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[jakwinkler]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[jakwinkler]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

✅ @qsolutions-pl Looks like very good job

[magento-engcom-team]

Hi @Den4ik, thank you for the review.
ENGCOM-9225 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Magento latest instance installed with sample data

Manual testing scenario:

1. Create a new attribute type multiselect, and add ~150 options to the attribute.

2. Create a new attribute set and use the above created attribute into this attribute set.

3. Create a new product by selecting the above created attribute set (Select all the attribute options while creating a new product.)

4. View the same created product in the same product created page.

Before: ✖️ All the attribute options were not getting selected after creating a product

After: ✔️ All the attribute options are getting selected after creating a product

Since it is a specific case and not impacting any other feature overall, there is no additional regression is required!

[Den4ik]

@sidolov @gabrieldagama PR accepted 17 days ago but still not merged. Could someone provide accurate merge progress estimate?

[magento-engcom-team]

Hi @bgorski, thank you for the review.
ENGCOM-9225 has been created to process this Pull Request

[jakwinkler]

So... new release has been pushed public, accepted pull request not merged... (not just this one)... does someone even care about community at all?

[jakwinkler]

So, what is the chance that this bugfix will be merged to 2.4.4?

[sivaschenko]

@qsolutions-pl it is currently in the "Merge in progress" status and should be merged following the queue among other high priority pull requests