[MFTF] AdminAddNewDefaultBillingShippingCustomerAddressTest refactoring #33999

AnnaAPak · 2021-09-06T08:18:20Z

Description (*)

The test is refactored according to the best practices

m2-assistant · 2021-09-06T08:18:22Z

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

AnnaAPak · 2021-09-06T08:20:36Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

magento-automated-testing · 2021-09-06T08:20:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

@AnnaAPak Thanks for work on tests.
Please look at my comments

Den4ik · 2021-09-07T11:20:26Z

...nto/Customer/Test/Mftf/ActionGroup/AdminClickEditLinkForDefaultBillingAddressActionGroup.xml

+        <waitForPageLoad stepKey="waitForFormToLoad"/>
+    </actionGroup>
+</actionGroups>
+


Please add new line at the end of file

Den4ik · 2021-09-07T11:21:12Z

...to/Customer/Test/Mftf/ActionGroup/AdminFillAndSaveCustomerlAddressInformationActionGroup.xml

+        <click selector="{{AdminCustomerAddressesSection.saveAddress}}" stepKey="clickSaveCustomerAddressOnAddUpdateAddressForm"/>
+        <waitForPageLoad stepKey="waitForNewAddressIsCreated"/>
+    </actionGroup>
+</actionGroups>


Please add new line at the end of file

AnnaAPak · 2021-09-08T08:23:42Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

magento-automated-testing · 2021-09-08T08:23:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

.../Test/Mftf/ActionGroup/AdminAssertCustomerDefaultShippingAddressAgainstEntityActionGroup.xml

eduard13

Please check the above suggestion

…tomerDefaultShippingAddressAgainstEntityActionGroup.xml Co-authored-by: Eduard Chitoraga <[email protected]>

AnnaAPak · 2021-09-10T08:57:12Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

magento-automated-testing · 2021-09-10T08:57:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-09-24T09:00:46Z

@magento run all tests

magento-automated-testing · 2021-09-24T09:00:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-09-24T11:23:23Z

It seems that all the review comment's have been taken care and rectified, so moving it further.

Thank you!

magento-automated-testing · 2021-10-13T05:25:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-10-13T05:26:31Z

Hi @eduard13, thank you for the review.
ENGCOM-9251 has been created to process this Pull Request
✳️ @eduard13, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team · 2021-10-14T12:11:32Z

Hi @Den4ik, thank you for the review.
ENGCOM-9251 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

…est refactoring #33999

AdminAddNewDefaultBillingShippingCustomerAddressTest refactored

b9ecbf5

magento-engcom-team added Component: Customer Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 6, 2021

Den4ik requested changes Sep 7, 2021

View reviewed changes

m2-community-project bot assigned Den4ik Sep 7, 2021

m2-community-project bot added the Progress: needs update label Sep 7, 2021

added new lines at the end of file

fdaf2ad

eduard13 reviewed Sep 8, 2021

View reviewed changes

.../Test/Mftf/ActionGroup/AdminAssertCustomerDefaultShippingAddressAgainstEntityActionGroup.xml Outdated Show resolved Hide resolved

m2-community-project bot assigned eduard13 Sep 8, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Sep 8, 2021

eduard13 requested changes Sep 8, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Sep 8, 2021

sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 9, 2021

Update app/code/Magento/Customer/Test/Mftf/ActionGroup/AdminAssertCus…

f87fb38

…tomerDefaultShippingAddressAgainstEntityActionGroup.xml Co-authored-by: Eduard Chitoraga <[email protected]>

engcom-Charlie self-assigned this Sep 24, 2021

m2-community-project bot removed the Progress: needs update label Sep 24, 2021

m2-community-project bot added Progress: testing in progress Progress: ready for testing and removed Progress: testing in progress labels Sep 24, 2021

eduard13 approved these changes Oct 13, 2021

View reviewed changes

Den4ik approved these changes Oct 14, 2021

View reviewed changes

eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 14, 2021

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Oct 25, 2021

magento-engcom-team pushed a commit that referenced this pull request Nov 4, 2021

ENGCOM-9251: [MFTF] AdminAddNewDefaultBillingShippingCustomerAddressT…

6513b14

…est refactoring #33999

magento-engcom-team merged commit 37f3e52 into magento:2.4-develop Nov 4, 2021

[MFTF] AdminAddNewDefaultBillingShippingCustomerAddressTest refactoring #33999

[MFTF] AdminAddNewDefaultBillingShippingCustomerAddressTest refactoring #33999

Uh oh!

Conversation

AnnaAPak commented Sep 6, 2021

Description (*)

Uh oh!

m2-assistant bot commented Sep 6, 2021

Uh oh!

AnnaAPak commented Sep 6, 2021

Uh oh!

magento-automated-testing bot commented Sep 6, 2021

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

Den4ik Sep 7, 2021

Choose a reason for hiding this comment

Uh oh!

Den4ik Sep 7, 2021

Choose a reason for hiding this comment

Uh oh!

AnnaAPak commented Sep 8, 2021

Uh oh!

magento-automated-testing bot commented Sep 8, 2021

Uh oh!

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

AnnaAPak commented Sep 10, 2021

Uh oh!

magento-automated-testing bot commented Sep 10, 2021

Uh oh!

engcom-Charlie commented Sep 24, 2021

Uh oh!

magento-automated-testing bot commented Sep 24, 2021

Uh oh!

engcom-Charlie commented Sep 24, 2021

Uh oh!

magento-automated-testing bot commented Oct 13, 2021

Uh oh!

magento-engcom-team commented Oct 13, 2021

Uh oh!

magento-engcom-team commented Oct 14, 2021

Uh oh!

Uh oh!