Skip to content

Revert "Removing the MatchMedia" #34021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrewbess
Copy link
Contributor

@andrewbess andrewbess commented Sep 8, 2021

Description (*)

This pull request (PR) reverts commit 34dcfd4 by the license reasons.
The issue #33865 has been reopened.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@andrewbess andrewbess requested a review from eduard13 September 8, 2021 08:13
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 8, 2021
@andrewbess
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@andrewbess, could you provide some more details on this?

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor Author

@andrewbess, could you provide some more details on this?

Hello @ihor-sviziev
Thank you for your question

Please read license https://creativecommons.org/licenses/by-sa/3.0/

ShareAlike — If you remix, transform, or build upon the material, you must distribute your contributions under the same license as the original.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 8, 2021
@andrewbess
Copy link
Contributor Author

The currency converter API is down again
currency-converter-api-is-down

@andrewbess andrewbess merged commit 5ae5a49 into magento:platform-health Sep 8, 2021
@m2-assistant
Copy link

m2-assistant bot commented Sep 8, 2021

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@andrewbess andrewbess deleted the revert-removing-match-media branch September 10, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Platform Health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants