-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Report cron error message where possible #34069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report cron error message where possible #34069
Conversation
Hi @fredden. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B,Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to check why tests failing - re-running
Hi @BarnyShergold, thank you for the review.
|
Hi @Den4ik, thank you for the review. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @ihor-sviziev, thank you for the review. |
@magento give me test instance |
Hi @slavvka. Thank you for your request. I'm working on Magento instance for you. |
Hi @slavvka, here is your Magento Instance: https://8d773c16d6b0de8520f3de288d61ade8.instances.magento-community.engineering |
@magento create issue |
✔️ QA Passed Manual testing scenario:
Before: ✖️ We are not getting the real error message point to actual error in cron.log file. After: ✔️ Along with the message 'Error when running a cron job', we are also getting the error because of which runtime exception happened. Since this PR is relevant to having an error messages in cron logs and has no functional impact there is no additional testing required as part of regression. |
Description
This pull request adds the error message to the new exception created in the exception handler for cron jobs. Without this, the real error message is lost.
Related Pull Requests
None
Manual testing scenarios
Questions or comments
See also Ethan3600/magento2-CronjobManager#164
Contribution checklist
Resolved issues: