-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed error DOT field with Portugal locale #34148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed error DOT field with Portugal locale #34148
Conversation
Hi @AZiniukhin. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run functional tests |
Failed to run the builds. Please try to re-run them later. |
@magento run functional tests |
Failed to run the builds. Please try to re-run them later. |
@magento run functional tests |
Failed to run the builds. Please try to re-run them later. |
@magento run functional tests |
Failed to run the builds. Please try to re-run them later. |
@magento-engcom-team - Any idea why tests won't run? |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @sidolov, thank you for the review.
|
Hi @AZiniukhin, Thank you for your contribution! I am looking into the build failures. Thank you! |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests EE,Functional Tests B2B,Static Tests,WebAPI Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
…error_DOT_field_with_Portugal_locale
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Static Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B, Functional Tests EE,Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
I have merged the 2.4-develop branch in to this PR branch and fixed the failed static test case. I have also checked that the few Functional test cases which are getting failed are not part of this PR and as also not affected because of the PR changes so moving it to Merge in Progress. Thank you! |
Description (*)
When investigating this error, it was found that it occurs due to the absence of a "short" designation of days (
do, sg, te, qu, qi, sx, sb
) in the Potrugalia locale called in fileapp/code/Magento/Customer/Block/Widget/Dob.php
'dayNamesMin' => array_values(iterator_to_array($daysData['format']['short']))
.This error is formed at the PHP level when an object is create "
new \ResourceBundle($locale, $path)
" called in filelib/internal/Magento/Framework/Locale/Bundle/DataBundle.php
in "createResourceBundle
" method that automatically returns this value without a "short" version of days.Due to the impossibility of believing in the work of PHP, in the absence of a "short" version of the days of the week, I return them to a longer version (
dom, seg, ter, qua, qui, sex, sáb
).Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)

2. Admin - Stores - Configuration - Customer - Customer Configuration - Name and Address Options - Set Show Date of Birth in Optional or Required and Save
3. Reindex and Clear Cache 4. Front-end - Create Account 5. Add DOB in customer createQuestions or comments
Contribution checklist (*)