Skip to content

Fixed error DOT field with Portugal locale #34148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AZiniukhin
Copy link
Contributor

Description (*)

When investigating this error, it was found that it occurs due to the absence of a "short" designation of days (do, sg, te, qu, qi, sx, sb) in the Potrugalia locale called in file app/code/Magento/Customer/Block/Widget/Dob.php
'dayNamesMin' => array_values(iterator_to_array($daysData['format']['short'])).
This error is formed at the PHP level when an object is create "new \ResourceBundle($locale, $path)" called in file lib/internal/Magento/Framework/Locale/Bundle/DataBundle.php in "createResourceBundle" method that automatically returns this value without a "short" version of days.
Due to the impossibility of believing in the work of PHP, in the absence of a "short" version of the days of the week, I return them to a longer version (dom, seg, ter, qua, qui, sex, sáb).

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Error DOB field with Locale PT #34130

Manual testing scenarios (*)

  1. Admin - Stores - Configuration - General - Locale Options - Set Locale to Portuguese(Portugal) and Save

Screenshot 2021-09-23 at 12 01 01

2. Admin - Stores - Configuration - Customer - Customer Configuration - Name and Address Options - Set Show Date of Birth in Optional or Required and Save

Screenshot 2021-09-23 at 12 01 25

3. Reindex and Clear Cache 4. Front-end - Create Account 5. Add DOB in customer create

Screenshot 2021-09-23 at 12 01 50

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2021

Hi @AZiniukhin. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@BarnyShergold
Copy link

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 23, 2021
@AZiniukhin
Copy link
Contributor Author

@magento run functional tests

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@AZiniukhin
Copy link
Contributor Author

@magento run functional tests

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@BarnyShergold
Copy link

@magento run functional tests

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@BarnyShergold
Copy link

@magento run functional tests

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@BarnyShergold
Copy link

@magento-engcom-team - Any idea why tests won't run?

@sidolov
Copy link
Contributor

sidolov commented Oct 13, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-9256 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Charlie
Copy link
Contributor

Hi @AZiniukhin,

Thank you for your contribution!

I am looking into the build failures.

Thank you!

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE,Functional Tests B2B,Static Tests,WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE,Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

I have merged the 2.4-develop branch in to this PR branch and fixed the failed static test case.

I have also checked that the few Functional test cases which are getting failed are not part of this PR and as also not affected because of the PR changes so moving it to Merge in Progress.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error DOB field with Locale PT
6 participants