Skip to content

Resolve height modal issue on iOS #34290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Oct 10, 2021

Description (*)

This problem can reproduce in case we have modal form with enough long content at mobile screen (iOS Devices)
If we add action (cta) button at bottom/footer of the modal. User will not able to click to proceed to next step update/edit. Make shop become very bad UX and reduce conversion rate!
Also this changes will work with android phones too

Before: (Can't scroll to bottom or click action at bottom)
defect

After apply fix: (Now button can click and content form still able scroll)
Footer/Header modal remain stay still. Content form can scrollable if content go longer than usually
after-fix-modal

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

Test case 1

  1. Add product to cart and Goto checkout via mobile
  2. Click on minicart icon to trigger modal
  3. Previously (Modal have scroll for both header and footer) -> Now only modal content scroll, header and footer of modal stay still in user device viewport

Test case 2
Add custom modal form with long content enough (like image in above description)
Active modal and go to mobile screen to visible

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Resolve height modal issue on iOS #34467: Resolve height modal issue on iOS

@m2-assistant
Copy link

m2-assistant bot commented Oct 10, 2021

Hi @mrtuvn. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Alfa engcom-Alfa added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Oct 12, 2021
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Oct 13, 2021
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-9254 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 14, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 16, 2021

@maegnto run WebAPI Tests, Unit Tests, Functional Tests EE, Functional Tests CE

@mrtuvn mrtuvn added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 16, 2021
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Oct 16, 2021

Manually test check for test regression

@engcom-Alfa
Copy link
Contributor

@magento create issue

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

  1. Have a fresh Magento 2.4-develop installed

Manual testing scenario:

  1. Create a new UI custom modal with multiple fields so that scroll will be enabled. Also make sure to have a button in the bottom of the screen as a footer.

  2. Open the screen in the IOS device.

  3. Scroll the screen downwards half way thru and check the footer button (Make sure you have some more fields in the screen to scrolldown still!)

Before: ✖️ Button was not visible on the screen

image

After: ✔️ Button is visible on the screen

image

Since it was particular with custom modal and UI screen issue for IOS device only, there is no other impact with any other features to test.

@engcom-Alfa
Copy link
Contributor

@magento Functional Tests CE, Functional Tests EE, Unit Tests, WebAPI Tests

@engcom-Alfa
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Unit Tests, WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Oct 28, 2021
@engcom-Alfa
Copy link
Contributor

After QA Pass, executed all the auto-tests that were failing. All the jobs are passed now. Hence moving this PR to Merge In progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Resolve height modal issue on iOS
4 participants