-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Resolve height modal issue on iOS #34290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve height modal issue on iOS #34290
Conversation
Hi @mrtuvn. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @sidolov, thank you for the review.
|
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@maegnto run WebAPI Tests, Unit Tests, Functional Tests EE, Functional Tests CE |
Manually test check for test regression |
@magento create issue |
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ Button was not visible on the screen After: ✔️ Button is visible on the screen Since it was particular with custom modal and UI screen issue for IOS device only, there is no other impact with any other features to test. |
@magento Functional Tests CE, Functional Tests EE, Unit Tests, WebAPI Tests |
@magento run Functional Tests CE, Functional Tests EE, Unit Tests, WebAPI Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
After QA Pass, executed all the auto-tests that were failing. All the jobs are passed now. Hence moving this PR to Merge In progress. |
Description (*)
This problem can reproduce in case we have modal form with enough long content at mobile screen (iOS Devices)
If we add action (cta) button at bottom/footer of the modal. User will not able to click to proceed to next step update/edit. Make shop become very bad UX and reduce conversion rate!
Also this changes will work with android phones too
Before: (Can't scroll to bottom or click action at bottom)

After apply fix: (Now button can click and content form still able scroll)

Footer/Header modal remain stay still. Content form can scrollable if content go longer than usually
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Test case 1
Test case 2
Add custom modal form with long content enough (like image in above description)
Active modal and go to mobile screen to visible
Questions or comments
Contribution checklist (*)
Resolved issues: