Skip to content

Fix call_user_func_array in Magento Framework #34300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2021
Merged

Fix call_user_func_array in Magento Framework #34300

merged 3 commits into from
Oct 15, 2021

Conversation

SilinMykola
Copy link
Contributor

@SilinMykola SilinMykola commented Oct 11, 2021 •
edited by ihor-sviziev
Loading

Description (*)

Change calls call_user_func_array() in Magento lib.

Related Pull Requests

Related Issues (if relevant)

  1. Fixes Fix call_user_func_array in the codebase with test coverage #34301

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 11, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 11, 2021

Hi @SilinMykola. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

@SilinMykola, do we have some test failures that this changes fixes? If no - please add test coverage.

@ihor-sviziev ihor-sviziev self-assigned this Oct 11, 2021
@SilinMykola
Copy link
Contributor Author

@ihor-sviziev hi! Both classes have Unit tests coverage. This changed provides compatibility with PHP8.

@ihor-sviziev ihor-sviziev linked an issue Oct 12, 2021 that may be closed by this pull request
Fix call_user_func_array in the codebase with test coverage #34301
Closed
@SilinMykola SilinMykola changed the title Fix call_user_func_array in lib Fix call_user_func_array in Magento Framework Oct 12, 2021
@SilinMykola SilinMykola force-pushed the php8-compatibility/fix_call_user_func_array_in_lib branch from 3061640 to 404815b Compare October 12, 2021 13:52
@andrewbess andrewbess self-assigned this Oct 13, 2021
@SilinMykola SilinMykola force-pushed the php8-compatibility/fix_call_user_func_array_in_lib branch from 404815b to c173a8c Compare October 13, 2021 16:24
@andrewbess
Copy link
Contributor

@magento run all tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13 eduard13 self-assigned this Oct 13, 2021
@andrewbess
Copy link
Contributor

@magento run all tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess andrewbess force-pushed the php8-compatibility/fix_call_user_func_array_in_lib branch from bbd5464 to 0934250 Compare October 14, 2021 08:10
@andrewbess
Copy link
Contributor

@magento run Static Tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run all tests with env PHP 8.0

@andrewbess
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run all tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run Static Tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Oct 14, 2021

@magento run Unit Tests, Integration Tests, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Oct 14, 2021

@magento run Unit Tests, Integration Tests, Functional Tests B2B with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Oct 14, 2021

@magento run Semantic Version Checker

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit f0a6189 into magento:platform-health Oct 15, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 15, 2021

Hi @SilinMykola, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@SilinMykola SilinMykola deleted the php8-compatibility/fix_call_user_func_array_in_lib branch October 23, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@andrewbess andrewbess

@eduard13 eduard13

Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Project: Platform Health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix call_user_func_array in the codebase with test coverage
7 participants
@SilinMykola @ihor-sviziev @andrewbess @xmav @eduard13 @magento-engcom-team @magento-devops-reposync-svc