Skip to content

Fixed Critical Errors in MFTF tests #34332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2021
Merged

Fixed Critical Errors in MFTF tests #34332

merged 2 commits into from
Oct 13, 2021

Conversation

anzin
Copy link
Contributor

@anzin anzin commented Oct 13, 2021

Description (*)

Fixed failed MFTF tests for downloadable product.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [PHP8] Failed MFTF tests for downloadable product #34270

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 13, 2021

Hi @anzin. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 13, 2021
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Oct 13, 2021
@anzin
Copy link
Contributor Author

anzin commented Oct 13, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@anzin
Copy link
Contributor Author

anzin commented Oct 13, 2021

@magento run Functional Tests CE with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev
ihor-sviziev requested changes Oct 13, 2021
View reviewed changes
@ihor-sviziev ihor-sviziev linked an issue Oct 13, 2021 that may be closed by this pull request
[PHP8] Failed MFTF tests for downloadable product #34270
Closed
@anzin
Copy link
Contributor Author

anzin commented Oct 13, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@anzin anzin force-pushed the php8-compatibility/fix-critical-error-in-functional-test branch from 0e45576 to 9ba3d0a Compare October 13, 2021 10:41
@anzin
Copy link
Contributor Author

anzin commented Oct 13, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@anzin
Copy link
Contributor Author

anzin commented Oct 13, 2021

@magento run Functional Tests CE with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess andrewbess self-assigned this Oct 13, 2021
@anzin
Copy link
Contributor Author

anzin commented Oct 13, 2021

@magento run WebAPI Tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@xmav
Copy link
Contributor

xmav commented Oct 13, 2021

@magento run Unit Tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

@magento run all tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13 eduard13 self-assigned this Oct 13, 2021
@anzin
Copy link
Contributor Author

anzin commented Oct 13, 2021

@magento run Unit Tests with env PHP 8.0

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit cd5f68a into magento:platform-health Oct 13, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 13, 2021

Hi @anzin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess approved these changes

@eduard13 eduard13 eduard13 approved these changes

@ihor-sviziev ihor-sviziev Awaiting requested review from ihor-sviziev

Assignees

@ihor-sviziev ihor-sviziev

@andrewbess andrewbess

@eduard13 eduard13

Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Platform Health Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PHP8] Failed MFTF tests for downloadable product
7 participants
@anzin @xmav @andrewbess @ihor-sviziev @eduard13 @magento-engcom-team @magento-devops-reposync-svc