Make the title of the "Show Password" checkbox translatable #34370

densen45 · 2021-10-18T12:13:01Z

Description (*)

The title of the "Show Password" checkbox (Customer Login, Customer Registration, Customer Edit (Change Password section), Customer Set New Password) is not translatable. This pull request makes the title translatable.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Create an i18n translation for the string "Show Password".
Access the above mentioned pages.
Hover over the checkbox to see the title.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Make the title of the "Show Password" checkbox translatable #34857: Make the title of the "Show Password" checkbox translatable

m2-assistant · 2021-10-18T12:13:04Z

Hi @densen45. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

densen45 · 2021-10-18T12:45:22Z

@magento run all tests

magento-automated-testing · 2021-10-18T12:45:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

densen45 · 2021-10-19T05:16:14Z

@magento run all tests

magento-automated-testing · 2021-10-19T05:16:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-10-19T09:56:34Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9266 has been created to process this Pull Request

magento-engcom-team · 2021-10-19T09:56:35Z

@densen45 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

magento-engcom-team · 2021-10-20T10:32:27Z

Hi @Den4ik, thank you for the review.
ENGCOM-9266 has been created to process this Pull Request

Den4ik · 2021-11-23T12:42:56Z

It could be another issue related to multistore

densen45 · 2021-11-29T09:07:17Z

Hey @engcom-Alfa, I don't understand why the issue you describe is blocking this PR. Please help me, maybe I'm missing something.
The goal of this PR was to make the checkbox title translatable, not to fix the issue that the checkbox and the title are not displayed at all in some languages/multi language setups (before your comment I was not aware of this issue). For sure, that is a pity and should be fixed as well but I would suggest in another issue/PR.

…o translate-title-of-show-password-checkbox

engcom-Lima · 2021-12-17T06:32:47Z

@magento run all tests

magento-automated-testing · 2021-12-17T06:32:54Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-12-17T07:51:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-12-17T11:48:49Z

@magento run Functional Tests B2B, Functional Tests CE

magento-automated-testing · 2021-12-17T11:48:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-12-17T13:08:03Z

I don't see any problems with this PR and preferrer move it to merge in progress

magento-automated-testing · 2021-12-18T07:06:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-12-20T08:11:33Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9266 has been created to process this Pull Request

engcom-Alfa · 2021-12-21T11:32:12Z

@magento create issue

engcom-Alfa · 2021-12-21T11:34:03Z

✔️ QA Passed

Preconditions:

Have Magento latest installed.
Make sure to configure other language than English using the GUIDE.
Make sure to have the relevant language .csv file saved into the /app/i18n directory.
Make sure to have the translated text of "Show Password" in the csv file.

Manual testing scenario:

Admin > Store > Configure > Locale Options > Set the Locale to Other language that is configured as per pre conditions
Open the Magento front end and Navigate to Login page.

Before: ✖️ "Show Password" text was not getting translated to preferred language

After: ✔️ "Show Password" text is getting translated to preferred language

Since it is specific case relavant text translation, there is no additional testing is required as part of regression.

…ble #34370

Make the title of the "Show Password" checkbox translatable.

9610374

magento-engcom-team added Area: Frontend Component: Customer labels Oct 18, 2021

magento-engcom-team added the Release Line: 2.4 label Oct 18, 2021

m2-community-project bot added the Progress: pending review label Oct 18, 2021

densen45 force-pushed the translate-title-of-show-password-checkbox branch from befcf06 to 9610374 Compare October 19, 2021 05:46

ihor-sviziev added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Oct 19, 2021

ihor-sviziev self-assigned this Oct 19, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Oct 19, 2021

ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review Award: bug fix and removed Progress: review labels Oct 19, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Oct 19, 2021

ihor-sviziev approved these changes Oct 19, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Oct 19, 2021

Den4ik approved these changes Oct 20, 2021

View reviewed changes

m2-community-project bot assigned Den4ik Oct 20, 2021

Den4ik added the Risk: low label Oct 20, 2021

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Nov 23, 2021

Merge branch '2.4-develop' of https://github.com/magento/magento2 int…

4d0fd51

…o translate-title-of-show-password-checkbox

engcom-Lima self-assigned this Dec 17, 2021

ihor-sviziev approved these changes Dec 20, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Dec 20, 2021

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 21, 2021

m2-assistant bot mentioned this pull request Dec 21, 2021

[Issue] Make the title of the "Show Password" checkbox translatable #34857

Closed

5 tasks

m2-community-project bot added Progress: ready for testing Progress: testing in progress and removed Progress: testing in progress Progress: ready for testing labels Dec 21, 2021

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Dec 21, 2021

magento-devops-reposync-svc pushed a commit that referenced this pull request Mar 29, 2022

ENGCOM-9266: Make the title of the "Show Password" checkbox translata…

95e4d00

…ble #34370

magento-devops-reposync-svc merged commit 5f224f6 into magento:2.4-develop Mar 29, 2022

Make the title of the "Show Password" checkbox translatable #34370

Make the title of the "Show Password" checkbox translatable #34370

Uh oh!

Conversation

densen45 commented Oct 18, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Oct 18, 2021

Uh oh!

densen45 commented Oct 18, 2021

Uh oh!

magento-automated-testing bot commented Oct 18, 2021

Uh oh!

densen45 commented Oct 19, 2021

Uh oh!

magento-automated-testing bot commented Oct 19, 2021

Uh oh!

magento-engcom-team commented Oct 19, 2021

Uh oh!

magento-engcom-team commented Oct 19, 2021

Uh oh!

magento-engcom-team commented Oct 20, 2021

Uh oh!

Den4ik commented Nov 23, 2021

Uh oh!

densen45 commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Lima commented Dec 17, 2021

Uh oh!

magento-automated-testing bot commented Dec 17, 2021

Uh oh!

magento-automated-testing bot commented Dec 17, 2021

Uh oh!

ihor-sviziev commented Dec 17, 2021

Uh oh!

magento-automated-testing bot commented Dec 17, 2021

Uh oh!

Den4ik commented Dec 17, 2021

Uh oh!

magento-automated-testing bot commented Dec 18, 2021

Uh oh!

magento-engcom-team commented Dec 20, 2021

Uh oh!

engcom-Alfa commented Dec 21, 2021

Uh oh!

engcom-Alfa commented Dec 21, 2021

Uh oh!

Uh oh!

densen45 commented Oct 18, 2021 •

edited by m2-assistant bot

Loading

densen45 commented Nov 29, 2021 •

edited

Loading